Re: [cmake-developers] Patch: refactor XCode blocks writing function
Yes sure no problem I will install these hooks. Thanks! -Original Message- From: Gregor Jasny [mailto:gja...@googlemail.com] Sent: Sunday, February 21, 2016 10:40 AM To: Robert Goulet ; cmake-developers@cmake.org Subject: Re: [cmake-developers] Patch: refactor XCode blocks writing function Hello Robert, On 19/02/16 20:12, Robert Goulet wrote: > I did this refactoring of the function that writes the XCode blocks in the > project files, that adds support for any number of nested blocks. And it also > makes the code easier to expand in the future. > > One of the areas that required this for us was adding support for XCode UI > Testing (as opposed to non-UI testing), which required us to add the target > ID in a nested way that wasn't supported with the previous code. I will send > the XCode UI Testing patch separately. I will review this patch and push it into -next. One kind request: Could you please install the developer hooks locally so that you will get the same warnings and pre-commit errors like the cmake developers? As far as I remember you can set it up by calling Utilities/GitSetup/setup-hooks Thanks, Gregor -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Patch: refactor XCode blocks writing function
Hello Robert, On 19/02/16 20:12, Robert Goulet wrote: > I did this refactoring of the function that writes the XCode blocks in the > project files, that adds support for any number of nested blocks. And it also > makes the code easier to expand in the future. > > One of the areas that required this for us was adding support for XCode UI > Testing (as opposed to non-UI testing), which required us to add the target > ID in a nested way that wasn't supported with the previous code. I will send > the XCode UI Testing patch separately. I will review this patch and push it into -next. One kind request: Could you please install the developer hooks locally so that you will get the same warnings and pre-commit errors like the cmake developers? As far as I remember you can set it up by calling Utilities/GitSetup/setup-hooks Thanks, Gregor -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
[cmake-developers] Patch: refactor XCode blocks writing function
Hi all, I did this refactoring of the function that writes the XCode blocks in the project files, that adds support for any number of nested blocks. And it also makes the code easier to expand in the future. One of the areas that required this for us was adding support for XCode UI Testing (as opposed to non-UI testing), which required us to add the target ID in a nested way that wasn't supported with the previous code. I will send the XCode UI Testing patch separately. Cheers! -Robert Goulet 0001-Refactor-XCode-block-writes-to-allow-any-number-of-n.patch Description: 0001-Refactor-XCode-block-writes-to-allow-any-number-of-n.patch -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
