Re: [cmake-developers] Patch to support SVN externals in CTest update
On 9/26/2012 12:55 PM, Alexander Neundorf wrote: > On Monday 03 September 2012, Brad King wrote: >> On 09/03/2012 05:17 AM, Xavier Besseron wrote: >> > Here is the new set of patches. >> >> Wonderful, thanks! I've merged the topic with minor tweaks >> to our 'next' branch for testing: >> >> http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7fbbd921 >> >> You can fetch and checkout commit b7c97859 to get the head >> of the applied topic. > > I can confirm that it works :-) > I think this one can be closed now ? > http://public.kitware.com/Bug/view.php?id=12630 Yes, done, thanks. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Patch to support SVN externals in CTest update
On Monday 03 September 2012, Brad King wrote: > On 09/03/2012 05:17 AM, Xavier Besseron wrote: > > Here is the new set of patches. > > Wonderful, thanks! I've merged the topic with minor tweaks > to our 'next' branch for testing: > > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7fbbd921 > > You can fetch and checkout commit b7c97859 to get the head > of the applied topic. I can confirm that it works :-) I think this one can be closed now ? http://public.kitware.com/Bug/view.php?id=12630 Alex -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Patch to support SVN externals in CTest update
On 09/03/2012 05:17 AM, Xavier Besseron wrote: > Here is the new set of patches. Wonderful, thanks! I've merged the topic with minor tweaks to our 'next' branch for testing: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7fbbd921 You can fetch and checkout commit b7c97859 to get the head of the applied topic. Thanks, -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Patch to support SVN externals in CTest update
On Fri, Aug 24, 2012 at 5:09 PM, Brad King wrote:
>
> On 08/24/2012 08:50 AM, Xavier Besseron wrote:
> > I have split my changes in a series of small patches. Please find them
> > in attachment.
> > I have made sure that everything is compiling correctly and that the
> > CTest.UpdateSVN test runs successfully between each of them.
>
> Very nice, the series looks good. Please rewrite the commits to
> wrap all C++ code to 79 columns or less. This should be blank:
>
> git log origin/master.. --pickaxe-regex -S'.{80}'
>
> Also do not add a trailing blank line in the first commit to
> cmCTestSVN.cxx.
>
Here is the new set of patches.
> > Some comments about the testing:
> > - Most of the code path added by these patches is executed by the
> > current test. Indeed with this design, the root svn repository and the
> > svn external repositories just use the same SVNInfo structure and the
> > same function calls.
> > - The issue (ie incorrect author and revision number for each modified
> > file) is currently not tested for any of the version control system.
> > Probably this should be added, but this requires some work.
> > - The current organization of the ctest_update() testing uses some
> > common scripts between the different version control system. I don't
> > know yet if it is possible to add tests with svn externals in this
> > organization without breaking the test for the other VC.
> >
> > If I am not too busy, I will try to follow up on the testing part in
> > the coming weeks.
>
> The Git update test has a submodule, so you can look at how that
> works without disrupting the common test code.
>
Thanks. I will look at this.
Xavier
0001-Add-the-new-SVNInfo-structure.patch
Description: Binary data
0002-Extend-the-SVN-Revision-structure-to-include-info-ab.patch
Description: Binary data
0003-Add-the-Repositories-list-and-the-RootInfo-pointer.patch
Description: Binary data
0004-Create-the-SVNInfo-for-the-root-repository.patch
Description: Binary data
0005-Use-the-SVNInfo-structure-instead-of-the-fields-URL-.patch
Description: Binary data
0006-Add-a-LoadExternal-function-and-an-ExternalParser-cl.patch
Description: Binary data
0007-Call-LoadExternals-and-perform-operations-on-all-ele.patch
Description: Binary data
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Patch to support SVN externals in CTest update
On 08/24/2012 08:50 AM, Xavier Besseron wrote:
> I have split my changes in a series of small patches. Please find them
> in attachment.
> I have made sure that everything is compiling correctly and that the
> CTest.UpdateSVN test runs successfully between each of them.
Very nice, the series looks good. Please rewrite the commits to
wrap all C++ code to 79 columns or less. This should be blank:
git log origin/master.. --pickaxe-regex -S'.{80}'
Also do not add a trailing blank line in the first commit to
cmCTestSVN.cxx.
> Some comments about the testing:
> - Most of the code path added by these patches is executed by the
> current test. Indeed with this design, the root svn repository and the
> svn external repositories just use the same SVNInfo structure and the
> same function calls.
> - The issue (ie incorrect author and revision number for each modified
> file) is currently not tested for any of the version control system.
> Probably this should be added, but this requires some work.
> - The current organization of the ctest_update() testing uses some
> common scripts between the different version control system. I don't
> know yet if it is possible to add tests with svn externals in this
> organization without breaking the test for the other VC.
>
> If I am not too busy, I will try to follow up on the testing part in
> the coming weeks.
The Git update test has a submodule, so you can look at how that
works without disrupting the common test code.
Thanks,
-Brad
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Patch to support SVN externals in CTest update
Hello, I have split my changes in a series of small patches. Please find them in attachment. I have made sure that everything is compiling correctly and that the CTest.UpdateSVN test runs successfully between each of them. Some comments about the testing: - Most of the code path added by these patches is executed by the current test. Indeed with this design, the root svn repository and the svn external repositories just use the same SVNInfo structure and the same function calls. - The issue (ie incorrect author and revision number for each modified file) is currently not tested for any of the version control system. Probably this should be added, but this requires some work. - The current organization of the ctest_update() testing uses some common scripts between the different version control system. I don't know yet if it is possible to add tests with svn externals in this organization without breaking the test for the other VC. If I am not too busy, I will try to follow up on the testing part in the coming weeks. Let me know if you have any question or comment. Xavier On Mon, Jul 30, 2012 at 3:56 PM, Brad King wrote: > On 07/30/2012 09:45 AM, Xavier Besseron wrote: >> I am affected by the issue in bug 12630 >> (http://public.kitware.com/Bug/view.php?id=12630), so I prepared a >> patch. > > Thanks for working on this! > >> This patch adds support for svn externals during CTest update. I >> tested it successfully with svn 1.6/1.7, Linux/Windows and with >> nested externals as well. >> >> Summary of the modifications: >> - Add SVNInfo structure to hold info about each repository >> - Get the list of external repositories (using 'svn status' and >> ExternalParser) >> - Run 'svn info' for all repositories, before and after the update >> - Run 'svn log' for all repositories >> - Build the correct path for all updated files (ie add the >> external prefix and remove the svn base) >> >> Let me know if you have any questions or comments. > > The changes will be much easier to review in smaller pieces. > Please split this patch into a series. For example, the first > patch should add the SVNInfo infrastructure with no functional > changes. Each step in the series should still compile and > pass the UpdateSVN test. > > Separately, please also extend the UpdateSVN test to exercise > the new functionality. > > Thanks, > -Brad 0001-Add-the-new-SVNInfo-structure.patch Description: Binary data 0002-Extend-the-SVN-Revision-structure-to-include-info-ab.patch Description: Binary data 0003-Add-the-Repositories-list-and-the-RootInfo-pointer.patch Description: Binary data 0004-Create-the-SVNInfo-for-the-root-repository.patch Description: Binary data 0005-Use-the-SVNInfo-structure-instead-of-the-fields-URL-.patch Description: Binary data 0006-Add-a-LoadExternal-function-and-an-ExternalParser-cl.patch Description: Binary data 0007-Call-LoadExternals-and-perform-operations-on-all-ele.patch Description: Binary data -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Patch to support SVN externals in CTest update
On 07/30/2012 09:45 AM, Xavier Besseron wrote: > I am affected by the issue in bug 12630 > (http://public.kitware.com/Bug/view.php?id=12630), so I prepared a > patch. Thanks for working on this! > This patch adds support for svn externals during CTest update. I > tested it successfully with svn 1.6/1.7, Linux/Windows and with > nested externals as well. > > Summary of the modifications: > - Add SVNInfo structure to hold info about each repository > - Get the list of external repositories (using 'svn status' and > ExternalParser) > - Run 'svn info' for all repositories, before and after the update > - Run 'svn log' for all repositories > - Build the correct path for all updated files (ie add the > external prefix and remove the svn base) > > Let me know if you have any questions or comments. The changes will be much easier to review in smaller pieces. Please split this patch into a series. For example, the first patch should add the SVNInfo infrastructure with no functional changes. Each step in the series should still compile and pass the UpdateSVN test. Separately, please also extend the UpdateSVN test to exercise the new functionality. Thanks, -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] Patch to support SVN externals in CTest update
Hello, I am affected by the issue in bug 12630 (http://public.kitware.com/Bug/view.php?id=12630), so I prepared a patch. This patch adds support for svn externals during CTest update. I tested it successfully with svn 1.6/1.7, Linux/Windows and with nested externals as well. Summary of the modifications: - Add SVNInfo structure to hold info about each repository - Get the list of external repositories (using 'svn status' and ExternalParser) - Run 'svn info' for all repositories, before and after the update - Run 'svn log' for all repositories - Build the correct path for all updated files (ie add the external prefix and remove the svn base) Let me know if you have any questions or comments. Xavier ctest_svn_externals.patch Description: Binary data -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
