Re: [cmake-developers] Problem with find_path and Frameworks

2016-06-07 Thread Harry Mallon
Thanks Brad. I haven't run into a mac without /System/Library/Frameworks/Kernel.framework before but maybe it comes from XCode or something. Thanks for merging. Harry. Harry Mallon CODEX | Software Engineer 60 Poland Street | London | England | W1F 7NT E ha...@codexdigital.com | T +44 203 7000

Re: [cmake-developers] Problem with find_path and Frameworks

2016-06-07 Thread Brad King
On 06/07/2016 07:29 AM, Harry Mallon wrote: > I have updated my patch with new simplified logic and a test. Thanks. I revised the test to not depend on a specific framework path to exist on the system (it didn't on mine). Merged to 'next' for testing: find_path: Fix location of in a

Re: [cmake-developers] Problem with find_path and Frameworks

2016-06-07 Thread Harry Mallon
I have updated my patch with new simplified logic and a test. Harry Mallon CODEX | Software Engineer 60 Poland Street | London | England | W1F 7NT E ha...@codexdigital.com | T +44 203 7000 989 0001-Fix-a-problem-where-using-find_path-to-find-a-header.patch Description:

Re: [cmake-developers] Problem with find_path and Frameworks

2016-05-26 Thread Brad King
On 05/26/2016 07:24 AM, Harry Mallon wrote: > I can work around it if need be. I just felt that it was against the > stated behaviour of find_path since that function is meant to give > the folder where you can find "IOKit/pci/IOPCIDevice.h" rather than > the folder where you can find

Re: [cmake-developers] Problem with find_path and Frameworks

2016-05-26 Thread Harry Mallon
I can work around it if need be. I just felt that it was against the stated behaviour of find_path since that function is meant to give the folder where you can find "IOKit/pci/IOPCIDevice.h" rather than the folder where you can find "IOPCIDevice.h". Harry Harry Mallon CODEX | Software

Re: [cmake-developers] Problem with find_path and Frameworks

2016-05-25 Thread Eric Wing
On 5/25/16, Harry Mallon wrote: > I have quite a specific problem with find_path where > "find_path(IOKIT_INCLUDE_DIR "IOKit/pci/IOPCIDevice.h")" returns > "/System/Library/Frameworks/Kernel.framework/Headers/IOKit/pci" rather than >

Re: [cmake-developers] Problem with find_path and Frameworks

2016-05-25 Thread Brad King
On 05/25/2016 01:25 PM, Harry Mallon wrote: > I have quite a specific problem with find_path where > "find_path(IOKIT_INCLUDE_DIR "IOKit/pci/IOPCIDevice.h")" > returns "/System/Library/Frameworks/Kernel.framework/Headers/IOKit/pci" > rather than >

[cmake-developers] Problem with find_path and Frameworks

2016-05-25 Thread Harry Mallon
I have quite a specific problem with find_path where "find_path(IOKIT_INCLUDE_DIR "IOKit/pci/IOPCIDevice.h")" returns "/System/Library/Frameworks/Kernel.framework/Headers/IOKit/pci" rather than "/System/Library/Frameworks/Kernel.framework/Headers/". It is reproducible on OSX with the following