Hello all,
Sorry for bringing up an old thread, you can find the original thread
here:
http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/8658
I pushed the topic again with no changes (just a rebase), I've been
using it for a while with no issues at all.
Is it ok to merge it to
On 03/27/2014 11:16 AM, Daniele E. Domenichelli wrote:
Is it ok to merge it to next?
Yes, but let's do only one change to ExternalProject per day so
we can see how the tests do.
Thanks,
-Brad
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
On 03/27/2014 11:34 AM, Brad King wrote:
On 03/27/2014 11:16 AM, Daniele E. Domenichelli wrote:
Is it ok to merge it to next?
Yes, but let's do only one change to ExternalProject per day so
we can see how the tests do.
Please take a look at the failure on the continuous test submissions.
On 03/27/2014 02:35 PM, Brad King wrote:
Please take a look at the failure on the continuous test submissions.
fatal: Couldn't find remote ref origin/master
fatal: The remote end hung up unexpectedly
Is there a particular version requirement on Git?
Also I just noticed this line:
+
On 03/27/2014 02:35 PM, Brad King wrote:
Please take a look at the failure on the continuous test submissions.
fatal: Couldn't find remote ref origin/master
fatal: The remote end hung up unexpectedly
I see this fix, thanks:
ExternalProject: Strip out origin/ from git tag
On 27/03/14 19:45, Brad King wrote:
On 03/27/2014 02:35 PM, Brad King wrote:
Please take a look at the failure on the continuous test submissions.
fatal: Couldn't find remote ref origin/master
fatal: The remote end hung up unexpectedly
Is there a particular version requirement on Git?
I
On Mon, Nov 18, 2013 at 12:19:55 +0100, Daniele E. Domenichelli wrote:
If there are local changes, git stash is used to save the
changes and restore them after the pull. If any of these operation
fails, it tries to restore the original status and exits with a fatal
error, asking the user to
On 03/12/13 21:34, Ben Boeckel wrote:
On Mon, Nov 18, 2013 at 12:19:55 +0100, Daniele E. Domenichelli wrote:
If there are local changes, git stash is used to save the
changes and restore them after the pull. If any of these operation
fails, it tries to restore the original status and exits
On Tue, Dec 03, 2013 at 23:09:38 +0100, Daniele E. Domenichelli wrote:
git stash save automatically saves the index, that is restored using git
stash pop --index. The --keep-index does not save the index but instead
keeps it in the working tree.
This means that after stashing you will still
Hi Daniele, Brad,
On Tue, Nov 26, 2013 at 3:57 AM, Daniele E. Domenichelli
daniele.domeniche...@gmail.com wrote:
On 25/11/13 18:04, Jean-Christophe Fillion-Robin wrote:
After copying the ExternalProject.cmake in the Module directory of the
CMake installation I used for daily work, I
On 25/11/13 18:04, Jean-Christophe Fillion-Robin wrote:
After copying the ExternalProject.cmake in the Module directory of the
CMake installation I used for daily work, I didn't see any issue / side
effect.
Considering the external projects I am dealing with always specify the
SHA1, I
Hi Daniele,
After copying the ExternalProject.cmake in the Module directory of the
CMake installation I used for daily work, I didn't see any issue / side
effect.
Considering the external projects I am dealing with always specify the
SHA1, I didn't have a chance to explicitly test the case
Jc, Matt,
On 11/18/2013 10:10 AM, Jean-Christophe Fillion-Robin wrote:
Will give a try and let you know how it goes.
[snip]
On 11/18/2013 12:40 PM, Matt McCormick wrote:
I have checkout out the branch, will test it locally, and make any
notes of unexpected behavior.
Thanks for looking at this
Hello,
Please review the topic ExternalProject_GitUpdate
ExternalProject handles git remote branches by commit hash. Due to this,
the git repository ends in detached states, and local commits are discarded.
This patch uses git pull --rebase for remote branches instead of git
checkout. If there
Hi Daniele,
This is a great improvement. It is so easy to loose local change to an
external project A made while debugging/tweaking it for a better
interaction into an other project B with B depending on A.
Will give a try and let you know how it goes.
Thanks
Jc
On Mon, Nov 18, 2013 at 6:19
I am understanding properly that the last paragraph properly, this will fix
the problem that setting GIT_TAG to a named branch doesn't keep the branch
up to date with the remotes version of the branch?
Overall I really like this change to ExternalProject, and I see it being
more in line with how
Hi Daniele,
Thanks for the contribution!
Code review looks good -- I like how there is a reset --hard to the
previous head_sha and message if the stash pop does not work as
expected.
I have checkout out the branch, will test it locally, and make any
notes of unexpected behavior.
Thanks,
Matt
On 18/11/13 16:39, Robert Maynard wrote:
I am understanding properly that the last paragraph properly, this will
fix the problem that setting GIT_TAG to a named branch doesn't keep the
branch up to date with the remotes version of the branch?
Yes, exactly... setting GIT_TAG to master (or any
18 matches
Mail list logo
