Thanks!
Cheers,
Matthäus
Am 02.06.2016 um 15:44 schrieb Brad King:
> On 06/01/2016 03:00 PM, Matthäus G. Chajdas wrote:
>> done - I had to squash and force push once more, because I used the
>> wrong author in the first commit.
>>
>> Everything is now in one commit here:
>>
On 06/01/2016 03:00 PM, Matthäus G. Chajdas wrote:
> done - I had to squash and force push once more, because I used the
> wrong author in the first commit.
>
> Everything is now in one commit here:
>
Hi Brad,
done - I had to squash and force push once more, because I used the
wrong author in the first commit.
Everything is now in one commit here:
https://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=e95b62110715c06fb76b57fdfb13ea493a94c0c4
Thanks for the timely feedback!
Cheers,
On 06/01/2016 02:15 PM, Matthäus G. Chajdas wrote:
> Hopefully done
The revised history looks good. The change itself looks good.
Please also add a `Help/release/dev/FindOpenCL-imported-target.rst`
file with a release note for the feature. Look at other files
in that directory for a sample.
Hopefully done - I'm not the biggest git expert but the history looks
like I'd expect it to look like :)
Cheers,
Matthäus
Am 01.06.2016 um 19:57 schrieb Brad King:
> On 06/01/2016 01:53 PM, Matthäus G. Chajdas wrote:
>> updated to latest master and pushed again (I merged latest master into
>>
On 06/01/2016 01:53 PM, Matthäus G. Chajdas wrote:
> updated to latest master and pushed again (I merged latest master into
> this - is that fine or does it have to be a rebase? In that case I'll redo.)
Please rebase and force push.
Thanks,
-Brad
--
Powered by www.kitware.com
Please keep
Hi Brad,
updated to latest master and pushed again (I merged latest master into
this - is that fine or does it have to be a rebase? In that case I'll redo.)
Cheers,
Matthäus
Am 01.06.2016 um 17:18 schrieb Brad King:
> On 05/31/2016 03:17 PM, Matthäus G. Chajdas wrote:
>> I've just pushed
On 05/31/2016 03:17 PM, Matthäus G. Chajdas wrote:
> I've just pushed "add-opencl-imported-target" which adds an imported
> target to FindOpenCL. The whole change is rather small:
>
> https://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=6c53137a19e482140db3dc97b626af38348f2c71
>
> Good to
Hi,
I've just pushed "add-opencl-imported-target" which adds an imported
target to FindOpenCL. The whole change is rather small:
https://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=6c53137a19e482140db3dc97b626af38348f2c71
Good to merge this to next for testing?
Cheers,
Matthäus
--
