Re: [cmake-developers] Undocumented change in behavior in cmake 3.9.X (SWIG)

2017-08-17 Thread Simon Lees


On 17/08/17 22:18, Ben Boeckel wrote:
> On Thu, Aug 17, 2017 at 17:41:35 +0930, Simon Lees wrote:
>> We at openSUSE have noticed a change in behavior presumably in
>> swig_link_libraries in one package cproton_perl.so is now being
>> generated rather then libcproton_perl.so I presume the lines generating
>> the library are below (I am not familiar with the package)
>>
>> swig_add_module(cproton_perl perl perl.i)
>> swig_link_libraries(cproton_perl ${BINDING_DEPS} ${PERL_LIBRARY}
>> -lpthread -lm)
>>
>> changing to the non depreciated swig_add_libraries caries this same
>> change. I have a full build log available at [1] and a build on my
>> system should you require more info.
>>
>> I guess the question we have is was this change intentional and
>> accidentally undocumented (unless I missed it) or is there a deeper
>> issue with cmake that needs fixing here.
> 
> Looks like it was added here:
> 
> https://gitlab.kitware.com/cmake/cmake/merge_requests/767
> 
> as part of this commit:
> 
> 
> https://gitlab.kitware.com/brad.king/cmake/commit/8ed663791bdda4e726f7b3764bc75f8856724d6f
> 
> --Ben
> 

Thanks I'll update the cmake files in that package.

-- 

Simon Lees (Simotek)http://simotek.net

Emergency Update Team   keybase.io/simotek
SUSE Linux   Adelaide Australia, UTC+10:30
GPG Fingerprint: 5B87 DB9D 88DC F606 E489 CEC5 0922 C246 02F0 014B



signature.asc
Description: OpenPGP digital signature
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Undocumented change in behavior in cmake 3.9.X (SWIG)

2017-08-17 Thread Ben Boeckel
On Thu, Aug 17, 2017 at 17:41:35 +0930, Simon Lees wrote:
> We at openSUSE have noticed a change in behavior presumably in
> swig_link_libraries in one package cproton_perl.so is now being
> generated rather then libcproton_perl.so I presume the lines generating
> the library are below (I am not familiar with the package)
> 
> swig_add_module(cproton_perl perl perl.i)
> swig_link_libraries(cproton_perl ${BINDING_DEPS} ${PERL_LIBRARY}
> -lpthread -lm)
> 
> changing to the non depreciated swig_add_libraries caries this same
> change. I have a full build log available at [1] and a build on my
> system should you require more info.
> 
> I guess the question we have is was this change intentional and
> accidentally undocumented (unless I missed it) or is there a deeper
> issue with cmake that needs fixing here.

Looks like it was added here:

https://gitlab.kitware.com/cmake/cmake/merge_requests/767

as part of this commit:


https://gitlab.kitware.com/brad.king/cmake/commit/8ed663791bdda4e726f7b3764bc75f8856724d6f

--Ben
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


[cmake-developers] Undocumented change in behavior in cmake 3.9.X (SWIG)

2017-08-17 Thread Simon Lees
Hi,

We at openSUSE have noticed a change in behavior presumably in
swig_link_libraries in one package cproton_perl.so is now being
generated rather then libcproton_perl.so I presume the lines generating
the library are below (I am not familiar with the package)

swig_add_module(cproton_perl perl perl.i)
swig_link_libraries(cproton_perl ${BINDING_DEPS} ${PERL_LIBRARY}
-lpthread -lm)

changing to the non depreciated swig_add_libraries caries this same
change. I have a full build log available at [1] and a build on my
system should you require more info.

I guess the question we have is was this change intentional and
accidentally undocumented (unless I missed it) or is there a deeper
issue with cmake that needs fixing here.

Thanks

-- 

Simon Lees (Simotek)http://simotek.net

Emergency Update Team   keybase.io/simotek
SUSE Linux   Adelaide Australia, UTC+10:30
GPG Fingerprint: 5B87 DB9D 88DC F606 E489 CEC5 0922 C246 02F0 014B



signature.asc
Description: OpenPGP digital signature
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers