Re: [cmake-developers] What is necessary for including fixes from current development branch to official release
On 09/19/2014 08:59 AM, Jiri Malak wrote: I did a several fixes to CMake related to Open Watcom which were accepteed to current development branch a few month ago. Up to now they were not included to official version 3.0 branch. What I must do to be include or I doing something wrong? The current master branch is the basis for a 3.1 release. Only few changes are backported for a 3.0.x release (e.g. regressions). Nils -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] What is necessary for including fixes from current development branch to official release
On 09/19/2014 12:40 PM, Jiri Malak wrote: OK, but it was accepted before v3.0.0 was released. Do you know what rules are applied for selection what will be in new release and what cutoff date for it? On Feb. 19 2014 Brad announced the cutoff [1]. So everything that was in master before that will likely be in 3.0 while everything that went into master afterwards will likely be in 3.1. Nils [1] http://public.kitware.com/pipermail/cmake-developers/2014-February/009820.html -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] What is necessary for including fixes from current development branch to official release
The rule is (roughly): after the first release candidate for a given release, no more new features for that particular release. Only continuing work to complete new features in rc1 and fixing regressions reported from previous versions should go in subsequent release candidates. Possible exceptions may be made for bug fixes deemed important and broadly applicable and helpful. In the end, it's always a judgment call, and up to the folks preparing the releases to decide what goes in and what has to wait till next time. As Nils said, the only stuff guaranteed to be in a release is whatever is in 'master' already at the time the first release candidate is made. HTH, David C. -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] What is necessary for including fixes from current development branch to official release
On 09/19/2014 12:40 PM, Jiri Malak wrote: OK, but it was accepted before v3.0.0 was released. Do you know what rules are applied for selection what will be in new release and what cutoff date for it? On Feb. 19 2014 Brad announced the cutoff [1]. So everything that was in master before that will likely be in 3.0 while everything that went into master afterwards will likely be in 3.1. Nils [1] http://public.kitware.com/pipermail/cmake-developers/2014-February/009820.html Thanks for info. It is clear, it was too late to be included to 3.0. Do you have any idea when version 3.1 first release candidate is planned? Jiri -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] What is necessary for including fixes from current development branch to official release
On 09/19/2014 01:57 PM, Jiri Malak wrote: Thanks for info. It is clear, it was too late to be included to 3.0. Do you have any idea when version 3.1 first release candidate is planned? Mantis (the issue tracker) currently has 3.1 scheduled for 2014-11-01. For now I'd take it as a non binding rough estimate though. Nils -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] What is necessary for including fixes from current development branch to official release
On 09/19/2014 01:57 PM, Jiri Malak wrote: Thanks for info. It is clear, it was too late to be included to 3.0. Do you have any idea when version 3.1 first release candidate is planned? Mantis (the issue tracker) currently has 3.1 scheduled for 2014-11-01. For now I'd take it as a non binding rough estimate though. Nils Nils, Many Thanks for clarification. Jiri -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] What is necessary for including fixes from current development branch to official release
On Fri, Sep 19, 2014 at 1:59 AM, Jiri Malak malak.j...@gmail.com wrote: Hi, I did a several fixes to CMake related to Open Watcom which were accepteed to current development branch a few month ago. Up to now they were not included to official version 3.0 branch. What I must do to be include or I doing something wrong? I'd like to hear others opinions, but what I've done is once one of my patches is accepted, as long as it applies cleanly to the current release (and since all I mess with are modules that's usually the case) then I just email the Fedora package maintainer and he applies it within Fedora. You didn't mention if you were on Linux or Windows but if you're running a Linux distro you could probably do the same. Thanks, Richard -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] What is necessary for including fixes from current development branch to official release
On Fri, Sep 19, 2014 at 8:34 AM, Nils Gladitz nilsglad...@gmail.com wrote: On 09/19/2014 03:19 PM, Richard Shaw wrote: I'd like to hear others opinions, but what I've done is once one of my patches is accepted, as long as it applies cleanly to the current release (and since all I mess with are modules that's usually the case) then I just email the Fedora package maintainer and he applies it within Fedora. I personally rather dislike that distributions introduce behavior changes since it might result in your project not only depending on a specific version of CMake but also a specific variant as introduced by the distribution you are working on. It also results in people submitting issues with vanilla CMake which might be specific to distribution patches (e.g. [1]). I don't disagree in theory, but what do you do if you need the fix? One of the fixes I submitted fixed a problem with cross compiling that I'm not sure I could have easily worked around. I don't want to sit on my hands and wait for 3.1. I guess I could have copied the module into my project module folder and applied it locally, but that seems like a worse workaround than patching at the distro level. Thanks, Richard -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] What is necessary for including fixes from current development branch to official release
Richard Shaw wrote: On Fri, Sep 19, 2014 at 1:59 AM, Jiri Malak malak.j...@gmail.com wrote: I did a several fixes to CMake related to Open Watcom which were accepteed to current development branch a few month ago. Up to now they were not included to official version 3.0 branch. What I must do to be include or I doing something wrong? I'd like to hear others opinions, but what I've done is once one of my patches is accepted, as long as it applies cleanly to the current release (and since all I mess with are modules that's usually the case) then I just email the Fedora package maintainer and he applies it within Fedora. You didn't mention if you were on Linux or Windows but if you're running a Linux distro you could probably do the same. While I'm not too happy with the current situation either I don't think this is a good idea as it creates a hard to verify zoo of CMake versions with the same version number, but different behavior. This approach is is good for distro-specific patches, something like we ship a new Python that the upstream FindPython*.cmake does not find by default or we put our headers in a strange location, but I think that doing this for other stuff has the danger of making the Fedora packages some sort of shadow-upstream. Eike -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] What is necessary for including fixes from current development branch to official release
On 09/19/2014 03:19 PM, Richard Shaw wrote: I'd like to hear others opinions, but what I've done is once one of my patches is accepted, as long as it applies cleanly to the current release (and since all I mess with are modules that's usually the case) then I just email the Fedora package maintainer and he applies it within Fedora. You didn't mention if you were on Linux or Windows but if you're running a Linux distro you could probably do the same. I personally rather dislike that distributions introduce behavior changes since it might result in your project not only depending on a specific version of CMake but also a specific variant as introduced by the distribution you are working on. It also results in people submitting issues with vanilla CMake which might be specific to distribution patches (e.g. [1]). Nils [1] http://www.cmake.org/Bug/view.php?id=10692 -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] What is necessary for including fixes from current development branch to official release
On 09/19/2014 03:40 PM, Richard Shaw wrote: I guess I could have copied the module into my project module folder and applied it locally, but that seems like a worse workaround than patching at the distro level. I think I would personally prefer that over changing the package for the whole distro. The project is under your direct control and the modified module will be available with the project on all distributions (or platforms/operating systems) that users might try to build your project e.g. not just the distribution you happen to work on. By modifying the module on the distro level this changes behavior also for projects that did not ask for that change (which might work out in some cases but might just as well break in others). Nils -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
