Re: [cmake-developers] cmXMLWriter

2015-05-26 Thread Brad King
On 05/25/2015 09:10 AM, Daniel Pfeifer wrote:
 I wrote a simple XML writer (cmXMLWriter) that takes care of
 indentation, escaping, and balancing of end tags. I also ported all of
 CTest's  XML generation to cmXMLWriter.
 
 https://github.com/purpleKarrot/CMake/commits/xmlwriter

Thanks!  That looks much more robust and maintainable.

I've applied the changes with minor tweaks to style and
the commit messages:

 CTest: Drop stray content from Configure.xml
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=965cf8e6

 CTest: Generate NamedMeasurement elements directly into xml file
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b26e5b55

 Add cmXMLWriter class to consolidate XML generation
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=f6413400

 cmCTest: Port to cmXMLWriter
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=18825baf

 cmCTestUpdateHandler: Port to cmXMLWriter
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ed42c203

 cmCTestUploadHandler: Port to cmXMLWriter
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6cf5cc71

 cmCTestConfigureHandler: Port to cmXMLWriter
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9c0bb7d8

 cmCTest: Port GenerateNotesFile to cmXMLWriter
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a53bd63e

 cmCTestLaunch: Port to cmXMLWriter
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1dbd86fd

 cmCTestBuildHandler: Port to cmXMLWriter
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=82455a9d

 cmCTestCoverageHandler: Port to cmXMLWriter
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=8fbc509a

 cmCTest{Test,MemCheck}Handler: Port to cmXMLWriter
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b04500a7

 cmCTest: Drop unused method overloads
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=de2ef305

Thanks,
-Brad
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers


[cmake-developers] cmXMLWriter

2015-05-25 Thread Daniel Pfeifer
Hi,

I wrote a simple XML writer (cmXMLWriter) that takes care of
indentation, escaping, and balancing of end tags. I also ported all of
CTest's  XML generation to cmXMLWriter.

https://github.com/purpleKarrot/CMake/commits/xmlwriter

Please review and potentially apply.

cheers, Daniel
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers