Re: [cmake-developers] deprecate check_function_exists?

2017-01-13 Thread Stephen Sorley
Thanks Brad, I've created the merge request here: https://gitlab.kitware.com/cmake/cmake/merge_requests/394 -Stephen Sorley On Thu, Jan 12, 2017 at 9:44 AM, Brad King wrote: > On 01/11/2017 03:59 PM, Stephen Sorley wrote: > > So, could check_function_exists() be

Re: [cmake-developers] deprecate check_function_exists?

2017-01-13 Thread Brad King
On 01/11/2017 03:59 PM, Stephen Sorley wrote: > So, could check_function_exists() be explicitly deprecated in the > documentation in favor of check_symbol_exists()? Yes. Please submit a MR with proposed documentation updates. There may still be use cases for the test that

[cmake-developers] deprecate check_function_exists?

2017-01-11 Thread Stephen Sorley
There are two big issues with the check_function_exists() module that I've run into, and that others have also encountered: (1) It can't detect functions that are inlined in system headers or specified as a #define macro. (see https://cmake.org/pipermail/cmake-developers/2015-July/025766.html)