Re: [cmake-developers] [CMake] 2.8.11-rc3 generator expression error

2013-04-25 Thread Brad King
On 04/25/2013 03:34 AM, Stephen Kelly wrote: I haven't had time to investigate fully, but this patch should 'fix' the problem: [snip] I'll investigate later to see if it's the right fix and why. Great! I've turned that patch into this commit:

Re: [cmake-developers] [CMake] 2.8.11-rc3 generator expression error

2013-04-25 Thread Brad King
On 04/25/2013 11:02 AM, Stephen Kelly wrote: Brad King wrote: Great! I've turned that patch into this commit: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=de9d4a63 See commit message for an explanation that makes sense to me. The commit message is correct, but it's not the whole

Re: [cmake-developers] [CMake] 2.8.11-rc3 generator expression error

2013-04-25 Thread Stephen Kelly
Brad King wrote: I've pushed the fix-multi-config-tll-include-dirs branch to my clone. That's a much more detailed explanation, thanks. Pre-evaluating the expression as Debug regardless of the configuration involved feels like a hack. Since this all occurs at generate time already

Re: [cmake-developers] [CMake] 2.8.11-rc3 generator expression error

2013-04-25 Thread Brad King
On 4/25/2013 6:15 PM, Stephen Kelly wrote: Brad King wrote: Why can't GetIncludeDirectories just evaluate it-Value as a genex with the current configuration, and if it is a valid target name then lookup its INTERFACE_INCLUDE_DIRECTORIES and use that immediately? Good question. Reading the