Re: [cmake-developers] [PATCH] Add a test for checking that the CPack module produces correct config files

2015-08-31 Thread Domen Vrankar
> My motivation is this. I want to submit a few improvements to the way CPack > writes config files, starting with that cpack_set_if_not_set change I > mentioned a while back. This functionality is generator-independent (and > basically unrelated to actual package generation), so I thought >

Re: [cmake-developers] [PATCH] Fix a few issues in FindHDF5 module

2015-08-31 Thread Paul Romano
Thanks for the suggestions, Brad. Here is a set of three patches that breaks out the changes. For the HDF5_PREFER_PARALLEL implementation, I now use a list to set the names for find_program which does look much cleaner. I agree that having a NAMES_PER_DIR for find_program would be simpler from the

Re: [cmake-developers] nvidia nsight tegra set vcxproj properties (Ant Build) in cmake file

2015-08-31 Thread Mikhail Filimonov
Hi, guys. It looks that an error ‘ld.bfd.exe: cannot find -l-Wl,-Bdynamic’ was introduced by commit 675ef165f213a6db1f9d0dfbebf6a0afc5469494 Author: Chuck Atkins Date: Fri Aug 7 15:11:57 2015 -0400 Allow LINK_SEARCH_{START,END}_STATIC props to have default values.

Re: [cmake-developers] nvidia nsight tegra set vcxproj properties (Ant Build) in cmake file

2015-08-31 Thread Brad King
On 08/31/2015 11:16 AM, Mikhail Filimonov wrote: > It looks that an error ‘ld.bfd.exe: cannot find -l-Wl,-Bdynamic’ > > was introduced by > > commit 675ef165f213a6db1f9d0dfbebf6a0afc5469494 I discovered that problem in unrelated work last week and had prepared a commit to revert it. Chuck and

Re: [cmake-developers] FindZLIB module should find debug and, release variants

2015-08-31 Thread Brad King
On 08/28/2015 05:37 PM, Michael Scott wrote: > Okay, I've modified the patch to only add the DEBUG and RELEASE > configurations when the corresponding library is found, and not set the > generic IMPORTED_LOCATION property at all. Thanks. We also need to be compatible with projects or scripts

Re: [cmake-developers] [PATCH] Fix a few issues in FindHDF5 module

2015-08-31 Thread Brad King
On 08/31/2015 04:47 AM, Paul Romano wrote: > I'd like to offer the attached patch for consideration Thanks for working on these changes. Please split each independent fix out into its own commit with corresponding commit message explaining the change. For the HDF5_PREFER_PARALLEL

Re: [cmake-developers] CTest threshold exceeds 1024 bytes

2015-08-31 Thread Brad King
On 08/31/2015 07:36 AM, "Roman Wüger" wrote: > Attached you will find the corrected patch. Thanks. I've attached a revised version. I renamed the options and added release notes. I also started the test case. Please try completing the test and getting it to pass from there. BTW, I noticed

Re: [cmake-developers] generator expression for path slash conversion (was: ExternalProject: Use native paths as substitute for directory tokens)

2015-08-31 Thread Brad King
On 08/31/2015 09:35 AM, Kislinskiy, Stefan wrote: > As there is already a patch for such a genex in bug 15509 and the > discussion in 5939 (both linked below in Brad's reply) started 7 > years ago... It would be a great pity to let this issue seep away > again. What can I do to help fixing this

Re: [cmake-developers] New policy to address rdynamic

2015-08-31 Thread Chuck Atkins
So, from what I can tell, the Visual Studio generator and Xcode generator don't even use the CMAKE_SHARED_LIBRARY_LINK__FLAGS. I know it's the generators and not platforms since my tests pass on these platforms with Makefile and Ninja generators but fail with Visual Studio and Xcode generators.

Re: [cmake-developers] New policy to address rdynamic

2015-08-31 Thread Brad King
On 08/31/2015 03:44 PM, Chuck Atkins wrote: > the Visual Studio generator and Xcode generator > don't even use the CMAKE_SHARED_LIBRARY_LINK__FLAGS This is likely true and has not been noticed because the Platform modules do not set any value for this variable on any platform supported by those

[cmake-developers] [CMake 0015722]: ExternalProject.cmake calls 'git stash save --all' even if git doesn't support --all option

2015-08-31 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=15722 == Reported By:Kevin Godby Assigned To:

Re: [cmake-developers] [Patch] Adding Windows 10 support

2015-08-31 Thread Brad King
On 08/30/2015 06:41 PM, Gilles Khouzam wrote: > http://www.cmake.org/Bug/view.php?id=15670 > Add support for setting "Windows target platform version" in VS2015 Most of your changes look good but I think this issue needs more discussion. There is already some discussion in the issue tracker

[cmake-developers] Happy Birthday CMake!

2015-08-31 Thread Bill Hoffman
Today is the 15th birthday of CMake: http://www.kitware.com/blog/home/post/959 Thanks to everyone that has used and contributed to CMake over the years! -Bill -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware

[cmake-developers] [PATCH] Tests: Use a less strict regular expression to look for "SONAME".

2015-08-31 Thread Raphael Kubo da Costa
Commit 899458ab ("Tests: Cover NO_SONAME property for SHARED libraries") introduced a few new ExportImport tests, and the check_lib_{no}soname.cmake scripts that parse readelf(1)'s output. Make the regular expression matching the SONAME line output by readelf less strict, as the output format

Re: [cmake-developers] CTest threshold exceeds 1024 bytes

2015-08-31 Thread Roman Wüger
Hi Brad, sorry for the long response time, but I was on vacation. Attached you will find the corrected patch. Best regards Roman Am 20.08.15 um 17:30 schrieb Brad King > On 08/20/2015 06:30 AM, Roman Wüger wrote: > > > I made the "atoi" change but my problem is the test itself. > > > I

[cmake-developers] [PATCH] Fix a few issues in FindHDF5 module

2015-08-31 Thread Paul Romano
I'd like to offer the attached patch for consideration that fixes a number of issues with FindHDF5.cmake. The issues are as follows: 1. Searching for libraries related to the HL and Fortran_HL components is a bit broken at the moment; for example, if you specify the Fortran_HL component,

[cmake-developers] refactor-progress topic regressed Makefile progress

2015-08-31 Thread Brad King
Steve, The topic merged here: Merge topic 'refactor-progress' http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2985b9c0 sometimes breaks "make" progress. So far I've only been able to reproduce this when building CMake itself. In an up-to-date build tree I get output like: $ make ...

[cmake-developers] [CMake 0015721]: Indexer configuration of Eclipse CDT4 Project does not recognize symbols set by modules

2015-08-31 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == https://public.kitware.com/Bug/view.php?id=15721 == Reported By:Thomas Ruschival Assigned To:

Re: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens

2015-08-31 Thread Kislinskiy, Stefan
As there is already a patch for such a genex in bug 15509 and the discussion in 5939 (both linked below in Brad's reply) started 7 years ago... It would be a great pity to let this issue seep away again. What can I do to help fixing this finally? Stefan -Original Message- From: