[cmake-developers] fixup! Remove redundant arguments from fstream constructors

2016-06-14 Thread Daniel Pfeifer
This is a fixup for the std-fstream topic. From 1d52cfe88e98738a1f1172cd1723a07ac579d2eb Mon Sep 17 00:00:00 2001 From: Daniel Pfeifer Date: Tue, 14 Jun 2016 09:47:46 +0200 Subject: [PATCH] fixup! Remove redundant arguments from fstream constructors ---

Re: [cmake-developers] daemon-mode: Infrastructure

2016-06-14 Thread Tobias Hunger
PS: I think it would make perfect sense to ship the first cmake version with included daemon-mode with a big, fat warning that the interfaces are not finalized yet and will change in incompatible ways during the first release cycle (or maybe two:-). In my experience you only get the full feedback

Re: [cmake-developers] Questions about coding conventions

2016-06-14 Thread Brad King
On 06/13/2016 10:16 AM, Brad King wrote: >> Can't `std::ifstream` and `std::ofstream` be used directly? It seams >> that kwsys does some workarounds > > Yes, std::{o,f}stream can be used directly. On second thought, std::{i,o}fstream should not be used to open files. The cmsys::{i,o}fstream

[cmake-developers] codeblocks generator: Fix include directories being in unexpected order

2016-06-14 Thread Tobias Hunger
Hello, https://github.com/hunger/CMake/commit/a87e306fd03e7fae7409b16e4e586083822c6fe8 has a fix to not put include directories into random order while trying to make them unique. Would that be applicable for the next release? All Tests pass, with or without the patch. Best Regards, Tobias

Re: [cmake-developers] Installation of imported targets

2016-06-14 Thread Brad King
On 06/13/2016 06:12 PM, Elie Roudninski wrote: > Everything works fine except when you need to install the imported target. > You can't use the regular: > install(TARGETS myimportedlib LIBRARY DESTINATION lib) > It is not permitted for imported targets. At the moment, i usually use: >

Re: [cmake-developers] Questions about coding conventions

2016-06-14 Thread Daniel Pfeifer
On Tue, Jun 14, 2016 at 3:14 PM, Brad King wrote: > On 06/13/2016 10:16 AM, Brad King wrote: >>> Can't `std::ifstream` and `std::ofstream` be used directly? It seams >>> that kwsys does some workarounds >> >> Yes, std::{o,f}stream can be used directly. > > On second

[cmake-developers] Toward a more deterministic ninja generator

2016-06-14 Thread Nicolas Desprès
Hi, While working on something else I wrote this patch: https://github.com/nicolasdespres/CMake/commit/59e4e62ba014c6fcd4519b57b621d9434f99ff19 It makes the ninja generator more deterministic by sorting the build edge's inputs/outputs. It does not introduce any regression on my macbookpro. This

Re: [cmake-developers] Questions about coding conventions

2016-06-14 Thread clinton
- On Jun 14, 2016, at 8:09 AM, Daniel Pfeifer dan...@pfeifer-mail.de wrote: > On Tue, Jun 14, 2016 at 3:14 PM, Brad King wrote: >> On 06/13/2016 10:16 AM, Brad King wrote: Can't `std::ifstream` and `std::ofstream` be used directly? It seams that kwsys does

Re: [cmake-developers] codeblocks generator: Fix include directories being in unexpected order

2016-06-14 Thread Tobias Hunger
On Di, 2016-06-14 at 15:21 +, Tobias Hunger wrote: > Hello, > > https://github.com/hunger/CMake/commit/a87e306fd03e7fae7409b16e4e586083822c6fe > 8 https://github.com/hunger/CMake/commit/f190b069db2e430fd94b25e6287cd7fbc28661e3 Is the same thing updated based on suggestions from Stephen.