[cmake-developers] Support for Precompiled Headers

2012-06-14 Thread Daniel Pfeifer
Hi, In a private mailing with Dave Abrahams and Brad King I wrote a proposal of how I imagine PCH support should be implemented. Brad asked me to send it to this list for further discussion. Please note that even though I use present tense in the proposal, nothing descibed below is implemented

Re: [cmake-developers] Support for Precompiled Headers

2012-06-14 Thread Daniel Pfeifer
, Daniel Pfeifer dan...@pfeifer-mail.de wrote: Hi, In a private mailing with Dave Abrahams and Brad King I wrote a proposal of how I imagine PCH support should be implemented. Brad asked me to send it to this list for further discussion. Please note that even though I use present tense

Re: [cmake-developers] Support for Precompiled Headers

2012-07-03 Thread Daniel Pfeifer
2012/6/14 Daniel Pfeifer dan...@pfeifer-mail.de: 2012/6/14 David Cole david.c...@kitware.com: Sounds awesome to me! When can you submit a patch? :-) Thanks for the motivation! While I would like to contribute a patch, I have absolutely no idea where to start. Should it go

Re: [cmake-developers] Portable STD_CXX11 target property?

2012-08-20 Thread Daniel Pfeifer
2012/8/20 Rolf Eike Beer e...@sf-mail.de: Stephen Kelly wrote: Stephen Kelly steveire@... writes: Brad King wrote: I have pushed a std-cxx-target-property branch to my gitorious repo to illustrate the idea further, but I don't think there is any way to specify which c++ standard to

Re: [cmake-developers] CMake: need developer help / adopt a bug

2012-08-20 Thread Daniel Pfeifer
2012/8/20 David Cole david.c...@kitware.com: Call for CMake developers! Please adopt one or more of these bugs if you can. The following 11 bugs are on the CMake 2.8.10 roadmap, but they are UNASSIGNED. They do not have anybody actively working on them at the moment. ...

Re: [cmake-developers] Exporting dependent library targets in multiple export sets

2012-08-22 Thread Daniel Pfeifer
2012/8/22 Yury G. Kudryashov urkud.ur...@gmail.com: 2012/8/23 Brad King brad.k...@kitware.com: On 08/22/2012 04:57 PM, Yury G. Kudryashov wrote: I'm going to push the current state of my work to git pull git://gitorious.org/~urkud1/cmake/urkud-cmake.git w/export-set in a few minutes. Thanks

Re: [cmake-developers] Generator expressisons in target properties

2012-11-07 Thread Daniel Pfeifer
2012/11/6 Stephen Kelly steve...@gmail.com Stephen Kelly wrote: lots of amazing stuff So that it is fully aware of all of its [transitive] dependencies (and any includes and compile defintions requirements) and I would use it like this: add_executable(foo_exe ...)

Re: [cmake-developers] Setting include directories via target_link_libraries() ?

2012-12-10 Thread Daniel Pfeifer
2012/12/7 Stephen Kelly steve...@gmail.com Stephen Kelly wrote: I haven't tried to analyse how much of the complexity is due to whether target_use_targets or target_link_libraries is used. I think the harder parts of this topic so far have been related to exports. Like I said though, I

[cmake-developers] Fwd: EXPORT_NAME-genex

2013-05-20 Thread Daniel Pfeifer
2013/5/20 Brad King brad.k...@kitware.com We had some recent discussion about encouraging the convention of namespace:: for imported targets, but perhaps we should reconsider the value and cost. One of CMake's most powerful features in my opionion is the way it handles sub-projects. I can

Re: [cmake-developers] Fwd: EXPORT_NAME-genex

2013-05-25 Thread Daniel Pfeifer
2013/5/22 Alexander Neundorf neund...@kde.org On Monday 20 May 2013, Daniel Pfeifer wrote: 2013/5/20 Brad King brad.k...@kitware.com We had some recent discussion about encouraging the convention of namespace:: for imported targets, but perhaps we should reconsider the value

Re: [cmake-developers] Fwd: EXPORT_NAME-genex

2013-05-25 Thread Daniel Pfeifer
2013/5/25 Alexander Neundorf neund...@kde.org On Saturday 25 May 2013, Daniel Pfeifer wrote: 2013/5/22 Alexander Neundorf neund...@kde.org On Monday 20 May 2013, Daniel Pfeifer wrote: 2013/5/20 Brad King brad.k...@kitware.com We had some recent discussion about encouraging

Re: [cmake-developers] INTERFACE_LIBRARY target type

2013-09-02 Thread Daniel Pfeifer
4) The target_* commands always need to be invoked with an explicit INTERFACE option. Maybe PUBLIC should be allowed too (providing the same effect)? I don't really have a rationale. I just wrote PUBLIC a few times by accident. That might be a hint for a more intuitive interface. -- Powered

[cmake-developers] confusing documentation: VS_WINRT_EXTENSIONS

2013-09-02 Thread Daniel Pfeifer
Hi, The target property VS_WINRT_EXTENSIONS is documented as: Can be set to enable C++/CX language extensions. Is that really what this property does? I am trying to build a C++ project (no C++/CX) for ARM with Visual Studio 2012. As an example, I took the following code:

Re: [cmake-developers] confusing documentation: VS_WINRT_EXTENSIONS

2013-09-03 Thread Daniel Pfeifer
2013/9/2 Brad King brad.k...@kitware.com: On 09/02/2013 11:42 AM, Daniel Pfeifer wrote: The target property VS_WINRT_EXTENSIONS is documented as: Can be set to enable C++/CX language extensions. Is that really what this property does? [snip] So my question again: Does VS_WINRT_EXTENSIONS

Re: [cmake-developers] confusing documentation: VS_WINRT_EXTENSIONS

2013-09-03 Thread Daniel Pfeifer
2013/9/3 Brad King brad.k...@kitware.com: On 09/03/2013 03:39 AM, Daniel Pfeifer wrote: According to http://www.cmake.org/Bug/view.php?id=12930#c30721, WindowsAppContainer will not pass /ZW to the command line. Hence, setting VS_WINRT_EXTENSIONS will not enable C++/CX and the documentation

Re: [cmake-developers] confusing documentation: VS_WINRT_EXTENSIONS

2013-09-04 Thread Daniel Pfeifer
2013/9/3 Daniel Pfeifer dan...@pfeifer-mail.de: 2013/9/3 Brad King brad.k...@kitware.com: On 09/03/2013 03:39 AM, Daniel Pfeifer wrote: According to http://www.cmake.org/Bug/view.php?id=12930#c30721, WindowsAppContainer will not pass /ZW to the command line. Hence, setting VS_WINRT_EXTENSIONS

[cmake-developers] (naming-)convention for ALIAS and INTERFACE targets

2013-09-13 Thread Daniel Pfeifer
Hi Steve and all, we restarted the CMake-ification of molularized Boost with modern CMake features here: https://github.com/boost-cmake/boost-cmake We want to be able to build all Boost libraries together, but also each library on its own. Am I correct that in both cases we use the :: name in

Re: [cmake-developers] Converting CMake documentation to reStructuredText and Sphinx

2013-10-11 Thread Daniel Pfeifer
2013/10/11 Brad King brad.k...@kitware.com: On 10/11/2013 01:09 AM, Daniel Pfeifer wrote: Will it still be able to generate DocBook, so companies can include the documentation in their handbook? It can generate whatever Sphinx can generate. IIRC Sphinx does not currently support DocBook

Re: [cmake-developers] Additional properties for PCH support

2013-11-26 Thread Daniel Pfeifer
2013/11/26 Stephen Kelly steve...@gmail.com: Peter Kuemmel wrote: So, is this the right way to improve the pch situation? I don't know anything about PCH, but Daniel Pfeifer has a branch here: https://github.com/purpleKarrot/CMake/tree/WIP-PCH-Support Thanks for pointing at this branch. I

Re: [cmake-developers] RFC: add version to project() call

2014-01-14 Thread Daniel Pfeifer
2014/1/14 Brad King brad.k...@kitware.com: On 01/13/2014 01:38 PM, Alexander Neundorf wrote: does this require a policy now ? Somebody could set Foo_VERSION_MAJOR in the toplevel subdir, and have a project(Foo) call in a subdir, which would now unset Foo_VERSION_MAJOR. The same for

Re: [cmake-developers] RFC: add version to project() call

2014-01-14 Thread Daniel Pfeifer
2014/1/14 Matthew Woehlke mw_tr...@users.sourceforge.net: On 2014-01-14 10:37, Brad King wrote: On 01/13/2014 01:38 PM, Alexander Neundorf wrote: does this require a policy now ? Somebody could set Foo_VERSION_MAJOR in the toplevel subdir, and have a project(Foo) call in a subdir, which

Re: [cmake-developers] Compiler features/extensions remaining/future issues

2014-06-16 Thread Daniel Pfeifer
2014-06-15 22:24 GMT+02:00 Stephen Kelly steve...@gmail.com: Brad King wrote: On 06/13/2014 05:19 AM, Stephen Kelly wrote: 11) WriteCompilerDetectionHeader vs GenerateExportHeader IMO these two modules are solving orthogonal problems and should not be mixed. I'm not sure I agree.

Re: [cmake-developers] Optional dependencies in target INTERFACE

2014-06-30 Thread Daniel Pfeifer
2014-06-30 10:18 GMT+02:00 Stephen Kelly steve...@gmail.com: Hello, QtSQL provides abstracted access to database data. It does not depend on QtGui or QtWidgets. It also provides the header-only qsqlrelationaldelegate.h. The contents of that header depend on QtWidgets, and are wrapped in

[cmake-developers] LZMA support

2014-07-20 Thread Daniel Pfeifer
Hi, In my liblzma branch (https://github.com/purpleKarrot/CMake/commits/liblzma), I did the following: * add the liblzma source from XZ Utils * make it compile with CMake (by adding CMakeLists.txt etc.) * make it compile in VC6 (by porting the source from C99 to C90) * make cmlibarchive use

Re: [cmake-developers] LZMA support

2014-07-30 Thread Daniel Pfeifer
2014-07-30 15:58 GMT+02:00 Brad King brad.k...@kitware.com: On 07/23/2014 10:43 AM, Brad King wrote: I've merged the topic to 'next' for testing, but without the CPack or ExternalProject pieces. Likely some more portability fixes will be required after testing on the dashboard. Once that

Re: [cmake-developers] Modern cross-platform buildsystem design requirements

2014-09-10 Thread Daniel Pfeifer
Hi Steve, 2014-09-10 0:32 GMT+02:00 Stephen Kelly steve...@gmail.com: I wonder what a cmake-based buildsystem would look like for a collection of executables/targets which should be built for multiple ... I would generalize even more and finish the sentence with options at once. This

Re: [cmake-developers] cmake-gui icons

2014-10-28 Thread Daniel Pfeifer
2014-10-27 21:33 GMT+01:00 Ben Boeckel ben.boec...@kitware.com: On Mon, Oct 27, 2014 at 11:59:09 -0600, Orion Poplawski wrote: Trying to bring a bit more attention to this: Fedora is pushing to have higher resolution icons for the applications. There already is CMakeSetup128.png, but

Re: [cmake-developers] [CMake] target_include_directories target issue

2014-11-17 Thread Daniel Pfeifer
FWD to developers list. I think this is a documentation issue. Luis Felipe Dominguez Vega lfdoming...@estudiantes.uci.cu schrieb am Mon Nov 17 2014 at 5:42:55 PM: I can't see into the source code of cmake, into the cmTargetIncludeDirectoriesCommand.cxx somethink like import the

[cmake-developers] Minimal compiler requirements for CMake itself

2014-12-18 Thread Daniel Pfeifer
Hi, I would like to know what the oldest versions of GCC and Visual Studio are that should be able to compile the CMake source code. I was unable to find any information about that. I expected the oldest supported version of Visual Studio to be 6.0, but that one fails to build CMake. Don't get

Re: [cmake-developers] RFC: CMake precompiled header support and custom compiler based implementation

2015-03-20 Thread Daniel Pfeifer
On Fri, Mar 20, 2015 at 6:35 PM, Amine Khaldi amine.kha...@reactos.org wrote: Two requests please: * The option to use existing headers instead of autogenerated ones. That is an implementation detail. It should not make a difference whether the precompiled header is used through your existing

Re: [cmake-developers] RFC: CMake precompiled header support and custom compiler based implementation

2015-03-13 Thread Daniel Pfeifer
On Wed, Mar 4, 2015 at 8:53 PM, Brad King brad.k...@kitware.com wrote: On 03/03/2015 07:43 AM, Adam Strzelecki wrote: On 03/01/2015 08:02 PM, Ben Boeckel wrote: On 02/28/2015 11:59 AM, Adam Strzelecki wrote: target_precompiled_header(target path/to/precompiled_header.h)

[cmake-developers] Regarding the 'run-include-what-you-use' topic

2015-05-19 Thread Daniel Pfeifer
Hi Brad, Hi Bill, I think it is great that CMake gains support for IWYU. Without having tested it, I think the current implementation is compatible with other static analyzers like for examle clang-tidy. I think this is not good. If the options can be used for other tools than IWYU, the option

Re: [cmake-developers] Regarding the 'run-include-what-you-use' topic

2015-05-20 Thread Daniel Pfeifer
On Wed, May 20, 2015 at 7:34 PM, Bill Hoffman bill.hoff...@kitware.com wrote: I looked quickly at the clang-tidy docs and it looks interesting. I see it is setup to use the compile_commands.json file. Originally we looked at running iwyu using that file. However, it became quickly evident

Re: [cmake-developers] A policy for Policies

2015-06-07 Thread Daniel Pfeifer
On Sun, Jun 7, 2015 at 7:09 PM, Mike Gelfand mike...@mikedld.com wrote: On Sat, June 6, 2015 13:36, Stephen Kelly wrote: Code for Policies is also often complex. I often encounter Policies which are ancient and which get in the way of code clean up generally. Exactly the reason I don't

[cmake-developers] Composability of INTERFACE properties and custom targets

2015-05-29 Thread Daniel Pfeifer
Hi, in a project, I have to generate some C++ header files at build time. Targets that use these header files need to know the directory of the generated files and depend on the custom target that in turn depends on the generated files. Example: target_include_directories(lib PRIVATE

[cmake-developers] CTest: hide progress ticks in verbose output

2015-07-03 Thread Daniel Pfeifer
the progress ticks when the output is shown (-VV). Cheers, Daniel From 31290dd36fff5fd88a66069d962a9e3c80746525 Mon Sep 17 00:00:00 2001 From: Daniel Pfeifer dan...@pfeifer-mail.de Date: Fri, 3 Jul 2015 22:52:23 +0200 Subject: [PATCH] CTest: hide progress ticks in verbose output --- Source/CTest

Re: [cmake-developers] PATCH: add subcommand string(APPEND)

2015-07-06 Thread Daniel Pfeifer
On Mon, Jul 6, 2015 at 8:41 PM, Brad King brad.k...@kitware.com wrote: On 07/04/2015 06:27 PM, Daniel Pfeifer wrote: Attached is a patch that adds a subcommand string(APPEND). This allows to write string(APPEND string_variable some string) instead of set(string_variable ${string_variable

Re: [cmake-developers] PATCH: add subcommand string(APPEND)

2015-07-06 Thread Daniel Pfeifer
On Mon, Jul 6, 2015 at 10:55 PM, James Bigler jamesbig...@gmail.com wrote: list(APPEND) requires at least one element argument, right? No, see https://github.com/Kitware/CMake/blob/master/Source/cmListCommand.cxx#L236 -- Powered by www.kitware.com Please keep messages on-topic and check the

[cmake-developers] cmXMLWriter

2015-05-25 Thread Daniel Pfeifer
Hi, I wrote a simple XML writer (cmXMLWriter) that takes care of indentation, escaping, and balancing of end tags. I also ported all of CTest's XML generation to cmXMLWriter. https://github.com/purpleKarrot/CMake/commits/xmlwriter Please review and potentially apply. cheers, Daniel --

[cmake-developers] [PATCH] fixup: CTest-side support for compiler version

2015-08-11 Thread Daniel Pfeifer
Commit a5aa23 added support for reporting a compiler version to CDash (but with a hardcoded version number: the version of the compiler that was used to compile CMake). From 594c46c8f25e520d0fad984a4a00c228132cdea1 Mon Sep 17 00:00:00 2001 From: Daniel Pfeifer dan...@pfeifer-mail.de Date: Tue, 11

[cmake-developers] topic 'ctest-change-id'

2015-07-15 Thread Daniel Pfeifer
Hi, The new element `ChangeId` is added to Build.xml and Test.xml. Did you consider adding it as an attribute in `cmCTest::StartXML` instead? That would make this (very useful) information available in all xml files. cheers, Daniel -- Powered by www.kitware.com Please keep messages on-topic

Re: [cmake-developers] RFC: CMake precompiled header support and custom compiler based implementation

2015-10-28 Thread Daniel Pfeifer
en you are free to help with review, testing, and additional generators. Which generators are the most important for you? -- Daniel > Cheers, > Taylor > > On Fri, Mar 20, 2015 at 3:56 PM, Daniel Pfeifer <dan...@pfeifer-mail.de> > wrote: >> >> On Fri, Mar 20, 2015 at

Re: [cmake-developers] CTest XML outputs unsafe content

2015-08-27 Thread Daniel Pfeifer
by cmXMLWriter, this may lead to some double encodings. I have attached two patches that remove all uses of cmXMLSafe from CTest. -- Daniel From 6a5962c671373f0c4e90080abc7b7fe7cf731f77 Mon Sep 17 00:00:00 2001 From: Daniel Pfeifer dan...@pfeifer-mail.de Date: Thu, 16 Jul 2015 21:47:29 +0200 Subject: [PATCH 01

Re: [cmake-developers] RFC: CMake precompiled header support and custom compiler based implementation

2015-12-04 Thread Daniel Pfeifer
> On Friday, December 4, 2015, Daniel Pfeifer <dan...@pfeifer-mail.de> wrote: >> >> My working branch is here: >> https://github.com/purpleKarrot/CMake/commits/pch >> >> Feel free to comment, evaluate, contribute. >> >> I am nut fully dec

Re: [cmake-developers] RFC: CMake precompiled header support and custom compiler based implementation

2015-12-04 Thread Daniel Pfeifer
On Fri, Dec 4, 2015 at 9:19 PM, David Cole wrote: > Right, I was talking about the pch-binary. > > Why would CMake even need to generate a header file for pre-compiled > headers? Why not just allow the user to say which of his header files > should be the one to use for

Re: [cmake-developers] RFC: CMake precompiled header support and custom compiler based implementation

2015-12-04 Thread Daniel Pfeifer
On Fri, Dec 4, 2015 at 11:32 PM, David Cole wrote: > Makes sense. > > Can I inject my own "#include " into > the generated stream, or otherwise inject something into it? You should be able to do: target_include_directories(your_target PUBLIC public PRIVATE private )

Re: [cmake-developers] Profile Cmake scripts

2016-01-05 Thread Daniel Pfeifer
>sys 0m20.268s > > Make generation: >real 4m45.089s >user 2m56.117s >sys 0m17.481s > > Ninja generation: > real 2m48.585s > user 2m30.712s > sys 0m6.313s Generators for Xcode and Visual Studio have to generate more files. From 46a5639a27bab0b227b4

Re: [cmake-developers] Restriction on target types for GraphViz dependency graph generation

2015-12-20 Thread Daniel Pfeifer
On Wed, Dec 16, 2015 at 5:20 AM, Andrey Mishchenko wrote: > Hi, > > I noticed that the automatic dependency graph generation in CMake targeting > GraphViz only considers targets of certain types. In particular, it only > adds nodes for executables and shared, static, and

Re: [cmake-developers] Code style auto-formatting

2015-11-17 Thread Daniel Pfeifer
On Tue, Nov 17, 2015 at 10:12 PM, Robert Dailey wrote: > On Tue, Nov 17, 2015 at 6:57 AM, Paul Smith wrote: >> On Tue, 2015-11-17 at 08:14 +, Stuermer, Michael SP/HZA-ZSEP wrote: >>> In short, there is no fully automated style checking. If

Re: [cmake-developers] Review request: extract-cmMessenger branch

2016-06-09 Thread Daniel Pfeifer
On Thu, Jan 28, 2016 at 10:42 PM, Stephen Kelly wrote: > > Hi, > > I have pushed a extract-cmMessenger branch to my clone: > > https://github.com/steveire/CMake/commits/extract-cmMessenger I have rebased it to master and cherry-picked some minor changes. Once those minor

Re: [cmake-developers] CMake daemon-mode

2016-06-07 Thread Daniel Pfeifer
On Mon, Jun 6, 2016 at 7:24 PM, Brad King wrote: > On 06/06/2016 11:39 AM, Tobias Hunger wrote: > >> A big chunk of Stephen's work has not even landed in my branch yet. Since >> cmake >> reformated all the source in the meantime it is a bit tedious to apply >> patches >>

Re: [cmake-developers] CMake daemon-mode

2016-06-07 Thread Daniel Pfeifer
On Mon, Jun 6, 2016 at 5:39 PM, Tobias Hunger wrote: > Please help to support your use-cases. A while ago I wrote a graphical cache editor in GTK: https://github.com/purpleKarrot/cmake-gtk The tool reads the cache and provides a graphical view to modify it. It can then write

Re: [cmake-developers] Developer tasks - Refactoring

2016-06-06 Thread Daniel Pfeifer
On Sun, Jun 5, 2016 at 2:15 PM, Stephen Kelly <steve...@gmail.com> wrote: > On 05/19/2016 11:27 PM, Daniel Pfeifer wrote: >> On Wed, Feb 10, 2016 at 12:12 AM, Stephen Kelly <steve...@gmail.com> wrote: >>> 1) Make cmLocalGenerator not inherit cmOutputCon

Re: [cmake-developers] Questions about coding conventions

2016-06-12 Thread Daniel Pfeifer
On Sun, Jun 12, 2016 at 4:26 PM, Ben Boeckel <ben.boec...@kitware.com> wrote: > On Fri, Jun 10, 2016 at 15:30:05 +0200, Daniel Pfeifer wrote: >> Passing and returning strings: We have `const char*`, `std::string`, >> and `std::string const&`. Unifying this can affect perfo

[cmake-developers] Dogfooding: clang-tidy, include-what-you-use, link-what-you-use

2016-06-12 Thread Daniel Pfeifer
Hi, now that we have integrated include-what-you-use, clang-tidy, and just recently also a mechanism for link-what-you-use, it is time we start eating our own dog food. https://en.wikipedia.org/wiki/Eating_your_own_dog_food I have set up a dashboard build where all three mechanisms are enabled:

[cmake-developers] Questions about coding conventions

2016-06-10 Thread Daniel Pfeifer
Hi, By looking at the CMake source code, there are some inconsistencies regarding coding conventions. This is not a big problem and fixing them probably does not have a high priority. I would like to know what conventions to follow for new code. Formatting: No longer an issue. A .clang-format is

Re: [cmake-developers] Questions about coding conventions

2016-06-10 Thread Daniel Pfeifer
On Fri, Jun 10, 2016 at 5:19 PM, Tobias Hunger <tobias.hun...@qt.io> wrote: > On Fr, 2016-06-10 at 16:34 +0200, Daniel Pfeifer wrote: >> If used consistently, it indicates that you are dealing with a member. >> I personally prefer `this->` over `m_`. With semantic sy

Re: [cmake-developers] Review request: extract-cmMessenger branch

2016-06-10 Thread Daniel Pfeifer
On Fri, Jun 10, 2016 at 8:17 PM, Stephen Kelly wrote: > Tobias Hunger wrote: >> Forcing messages into one consistent format will be a pain, agreed, but >> continuing to add messages in whatever form the developer likes at the >> time of writing the code is even worse. CMake

Re: [cmake-developers] Questions about coding conventions

2016-06-10 Thread Daniel Pfeifer
On Fri, Jun 10, 2016 at 3:43 PM, Brad King <brad.k...@kitware.com> wrote: > On 06/10/2016 09:30 AM, Daniel Pfeifer wrote: >> By looking at the CMake source code, there are some inconsistencies >> regarding coding conventions. This is not a big problem and fixing >>

Re: [cmake-developers] Review request: extract-cmMessenger branch

2016-06-09 Thread Daniel Pfeifer
On Thu, Jun 9, 2016 at 2:17 PM, Brad King wrote: > On 06/09/2016 05:06 AM, Tobias Hunger wrote: >> CMake Error at src/1/app/CMakeLists.txt:70 (add_custom_target): >> Cannot find source file: >> >> unknownFile.qml >> >> Tried extensions .c .C .c++ .cc .cpp .cxx .m .M

Re: [cmake-developers] Questions about coding conventions

2016-06-10 Thread Daniel Pfeifer
On Fri, Jun 10, 2016 at 4:16 PM, Tobias Hunger <tobias.hun...@qt.io> wrote: > On Fr, 2016-06-10 at 15:30 +0200, Daniel Pfeifer wrote: >> Naming conventions: Classes are named cmLikeThis. Member functions >> and member variables are named LikeThis. Local variables are named

[cmake-developers] fixup! Remove redundant arguments from fstream constructors

2016-06-14 Thread Daniel Pfeifer
This is a fixup for the std-fstream topic. From 1d52cfe88e98738a1f1172cd1723a07ac579d2eb Mon Sep 17 00:00:00 2001 From: Daniel Pfeifer <dan...@pfeifer-mail.de> Date: Tue, 14 Jun 2016 09:47:46 +0200 Subject: [PATCH] fixup! Remove redundant arguments from fstream constructors --- Tests/Alias

Re: [cmake-developers] Questions about coding conventions

2016-06-14 Thread Daniel Pfeifer
On Tue, Jun 14, 2016 at 3:14 PM, Brad King wrote: > On 06/13/2016 10:16 AM, Brad King wrote: >>> Can't `std::ifstream` and `std::ofstream` be used directly? It seams >>> that kwsys does some workarounds >> >> Yes, std::{o,f}stream can be used directly. > > On second

Re: [cmake-developers] Questions about coding conventions

2016-06-13 Thread Daniel Pfeifer
On Mon, Jun 13, 2016 at 2:09 PM, Ben Boeckel <ben.boec...@kitware.com> wrote: > On Mon, Jun 13, 2016 at 00:03:29 +0200, Daniel Pfeifer wrote: >> Can you show an example? To be clear: We are looking for a function, >> that has a code path for `str == NULL` and a *different* c

[cmake-developers] fixup! Simplify boolean expressions

2016-06-02 Thread Daniel Pfeifer
My "Simplify boolean expressions" refactoring caused C4800 warnings for MSVC builds. A fixup is attached, as I cannot ssh at the moment. From ece15fe51c46cb93823ccd8a54243d35ebdc0d3c Mon Sep 17 00:00:00 2001 From: Daniel Pfeifer <dan...@pfeifer-mail.de> Date: Thu, 2 Jun 201

Re: [cmake-developers] Some trivial patches

2016-06-02 Thread Daniel Pfeifer
On Thu, Jun 2, 2016 at 11:15 AM, Tobias Hunger wrote: > On Mi, 2016-06-01 at 11:18 -0400, Brad King wrote: >> On 06/01/2016 05:04 AM, Tobias Hunger wrote: >> > Attached you will find a couple of really small changes that add const to a >> > method and fix a couple of typos in

Re: [cmake-developers] daemon-mode meeting last Tuesday

2016-06-24 Thread Daniel Pfeifer
On Fri, Jun 24, 2016 at 5:24 PM, Tobias Hunger <tobias.hun...@gmail.com> wrote: > Hi Daniel, > > On Fri, Jun 24, 2016 at 5:08 PM, Daniel Pfeifer <dan...@pfeifer-mail.de> > wrote: >>>> Currently cmake-gui supports switching generators, build trees, e

Re: [cmake-developers] daemon-mode meeting last Tuesday

2016-06-24 Thread Daniel Pfeifer
On Fri, Jun 24, 2016 at 4:56 PM, Tobias Hunger wrote: > Hi Brad, > > On Thu, Jun 23, 2016 at 10:46 PM, Brad King wrote: >>> * This is currently used to set sourcedirectory, builddirectory and >>> generator. >>> >>> These three should be

Re: [cmake-developers] daemon-mode meeting last Tuesday

2016-06-24 Thread Daniel Pfeifer
On Thu, Jun 23, 2016 at 2:27 PM, Tobias Hunger wrote: > * We both think it only makes sense to merge the infrastructure part into > cmake (if it passes review first of course) once we have some > functionality > that is genuinely useful. So we want to aim at having

Re: [cmake-developers] Status of pre-compiled headers

2016-06-27 Thread Daniel Pfeifer
On Mon, Jun 27, 2016 at 5:09 PM, Brad King wrote: > On 06/24/2016 12:19 PM, Oleh Kravchenko wrote: >> As far as I can see from issue tracker and the mail list archives of >> "precompiled headers" feature we are still struggling for solution. >>

Re: [cmake-developers] Status of pre-compiled headers

2016-06-27 Thread Daniel Pfeifer
On Mon, Jun 27, 2016 at 5:24 PM, Daniel Pfeifer <dan...@pfeifer-mail.de> wrote: > On Mon, Jun 27, 2016 at 5:09 PM, Brad King <brad.k...@kitware.com> wrote: >> On 06/24/2016 12:19 PM, Oleh Kravchenko wrote: >>> As far as I can see from issue tracker and the mail lis

Re: [cmake-developers] libuv in cmake (was: daemon-mode meeting last Tuesday)

2016-06-27 Thread Daniel Pfeifer
On Mon, Jun 27, 2016 at 5:02 PM, Brad King wrote: > On 06/24/2016 04:12 AM, Tobias Hunger wrote: >>> Please think about adding libuv earlier. As Brad wrote before, libuv >>> could replace some #ifdef code that we currently have >> >> Feel free to merge it at your own pace.

Re: [cmake-developers] CMake daemon for user tools

2016-01-21 Thread Daniel Pfeifer
On Wed, Jan 20, 2016 at 10:03 PM, Stephen Kelly wrote: > Milian Wolff wrote: > >>> I'm concerned that the memory usage of a daemon implementing the proposed >>> capabilities may be too large to be practical (at least without a major >>> redesign of certain structures that tend

[cmake-developers] Integration of clang-tidy

2016-04-08 Thread Daniel Pfeifer
output is recognized by CTest's diagnostic parser. I haven't checked how they look on CDash. cheers, Daniel From c1996b295d2e49134b6f5ef2be690588e5bf2732 Mon Sep 17 00:00:00 2001 From: Daniel Pfeifer <dan...@pfeifer-mail.de> Date: Fri, 8 Apr 2016 22:09:27 +0200 Subject: [PATCH] Provide

Re: [cmake-developers] more use of cmXMLWriter

2016-03-22 Thread Daniel Pfeifer
On Mon, Mar 21, 2016 at 3:39 PM Brad King <brad.k...@kitware.com> wrote: > On 03/19/2016 05:08 PM, Daniel Pfeifer wrote: > > I ported some more generators to cmXMLWriter. > > Thanks. I've applied and merged to 'next' for testing: > > cmXMLWriter: overload Element(

Re: [cmake-developers] Integration of clang-tidy

2016-04-26 Thread Daniel Pfeifer
On Mon, Apr 11, 2016 at 5:26 PM, Brad King <brad.k...@kitware.com> wrote: > On 04/08/2016 06:31 PM, Daniel Pfeifer wrote: >> I implemented the integration of `clang-tidy` along the lines of the >> `include-what-you-use` integration. >> There is a new `_

Re: [cmake-developers] Integration of clang-tidy

2016-04-27 Thread Daniel Pfeifer
On Wed, Apr 27, 2016 at 3:10 PM, Brad King <brad.k...@kitware.com> wrote: > On 04/26/2016 05:32 PM, Daniel Pfeifer wrote: >> This is a follow up patch: > > Thanks. > >> -tidy_cmd.insert(tidy_cmd.end(), orig_cmd.begin()+1, orig_cmd.end()); >> +

Re: [cmake-developers] Code style auto-formatting

2016-04-27 Thread Daniel Pfeifer
ptions from the .clang-format files. IncludeCategories and Standard should stay as they are. cheers, Daniel From 452087a4b9f05742aed38040ab8d9b970fd05719 Mon Sep 17 00:00:00 2001 From: Daniel Pfeifer <dan...@pfeifer-mail.de> Date: Wed, 27 Apr 2016 22:47:02 +0200 Subject: [PATCH 1/3] CursesD

Re: [cmake-developers] Integration of clang-tidy

2016-04-27 Thread Daniel Pfeifer
On Wed, Apr 27, 2016 at 10:47 PM, Gregor Jasny <gja...@googlemail.com> wrote: > Hallo Daniel, > > On 09/04/16 00:31, Daniel Pfeifer wrote: >> I implemented the integration of `clang-tidy` along the lines of the >> `include-what-you-use` integration. >> There is a

Re: [cmake-developers] Developer tasks - Refactoring

2016-05-19 Thread Daniel Pfeifer
17 00:00:00 2001 From: Daniel Pfeifer <dan...@pfeifer-mail.de> Date: Thu, 19 May 2016 23:11:40 +0200 Subject: [PATCH] Use enums defined in cmOutputConverter using their fully qualified name. Mostly automated: values=("RelativeRoot" "NONE" "FULL" "HOME"

Re: [cmake-developers] Developer tasks - Refactoring

2016-05-19 Thread Daniel Pfeifer
On Wed, Feb 10, 2016 at 12:12 AM, Stephen Kelly wrote: > 1) Make cmLocalGenerator not inherit cmOutputConverter > * Change enums like cmLocalGenerator::START_OUTPUT with sed. See > >https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=eac15298 > > for a similar sed

Re: [cmake-developers] Developer tasks - Refactoring

2016-05-19 Thread Daniel Pfeifer
On Thu, May 19, 2016 at 11:18 PM Daniel Pfeifer <dan...@pfeifer-mail.de> wrote: > On Wed, Feb 10, 2016 at 12:15 AM Stephen Kelly <steve...@gmail.com> wrote: > >> 1) Make cmLocalGenerator not inherit cmOutputConverter >> * Change enums like cmLocalGenerato

Re: [cmake-developers] Code style auto-formatting

2016-05-09 Thread Daniel Pfeifer
On Mon, May 9, 2016 at 11:31 AM, Rolf Eike Beer wrote: > Am Montag, 9. Mai 2016, 13:14:17 schrieb Brad King: >> On 05/02/2016 10:08 AM, Brad King wrote: >> > Next I'll look at the style updates themselves. >> >> I've made some more preparatory commits: > > […] >> Remove

Re: [cmake-developers] Code style auto-formatting

2016-05-09 Thread Daniel Pfeifer
On Mon, May 9, 2016 at 11:14 AM, Brad King wrote: > On 05/02/2016 10:08 AM, Brad King wrote: >> Next I'll look at the style updates themselves. > > I've made some more preparatory commits: > > Isolate formatted streaming blocks with clang-format off/on >

Re: [cmake-developers] [ANNOUNCE] CMake C++ coding style transition

2016-05-12 Thread Daniel Pfeifer
On Thu, May 12, 2016 at 7:58 AM, Brad King wrote: > Hi Folks, > > As discussed previously on the developer list: > > Code style auto-formatting > http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/14969 > >

Re: [cmake-developers] Integration of clang-tidy

2016-05-03 Thread Daniel Pfeifer
wrote: > On 04/27/2016 06:48 PM, Daniel Pfeifer wrote: >> It is unrelated. Clang-Tidy picks the interesting pieces from the >> compiler command line and ignores the rest. Whether cc is given or not >> makes no difference. >> But maybe we should leave the decision what

[cmake-developers] QtAutoGenerators output in Ninja

2016-07-12 Thread Daniel Pfeifer
Hi, CMake currently puts messages like "Generating moc source" into the buildlog. This conflicts with the convention "no output == all good". The messages blend nicely in the colorful output of Unix Makefiles, but when using the Ninja generator, they create quite some noise. How can this be

[cmake-developers] Script to update liblzma from upstream.

2016-06-28 Thread Daniel Pfeifer
the script is introduced, we may consider switching to the 5.2 branch. Cheers, Daniel From c0401e6f56fe5c9c77e9a80a2c2ab063930f70ed Mon Sep 17 00:00:00 2001 From: Daniel Pfeifer <dan...@pfeifer-mail.de> Date: Tue, 28 Jun 2016 23:10:11 +0200 Subject: [PATCH] Add script to update liblzma from up

Re: [cmake-developers] Please apply patch from https://github.com/hunger/CMake/commits/for-upstream to master

2016-06-29 Thread Daniel Pfeifer
On Wed, Jun 29, 2016 at 10:17 AM, Tobias Hunger wrote: > On Mi, 2016-06-29 at 09:54 +0200, Rolf Eike Beer wrote: >> Am 2016-06-29 09:35, schrieb Tobias Hunger: >> > Hello Brad, >> > >> > I currently get more than 2000 warnings when building cmake master, all >> > about >> >

Re: [cmake-developers] Patch for CM_OVERRIDE

2016-06-29 Thread Daniel Pfeifer
On Wed, Jun 29, 2016 at 7:15 AM, Roman Wüger wrote: > Hello, > > I've attached a patch for the CM_OVERRIDE commit Hi Roman, I added "override" to the destructor on purpose. The intent is to make the check fail in Visual Studio 10. See the commit message here:

Re: [cmake-developers] [PATCH] Improve encoding handling on Windows

2016-07-01 Thread Daniel Pfeifer
Hi Dāvis, On Fri, Jul 1, 2016 at 4:18 AM, Dāvis Mosāns wrote: > On Windows getenv uses ANSI codepage so it needs to be encoded to > internally used encoding (eg. UTF-8). Here we use _wgetenv instead > and encode that. Your change to the SystemTools::GetEnv function

Re: [cmake-developers] [PATCH] Improve encoding handling on Windows

2016-07-01 Thread Daniel Pfeifer
On Fri, Jul 1, 2016 at 4:12 PM, Ben Boeckel wrote: > On Fri, Jul 01, 2016 at 16:44:32 +0300, Dāvis Mosāns wrote: >> 2. change GetEnv to return std::unique_ptr which will be >> automatically deleted once out of scope and we still can check if there >> wasn't such env

Re: [cmake-developers] Debugger for CMake

2017-02-02 Thread Daniel Pfeifer
On Thu, Feb 2, 2017 at 12:02 PM, Milian Wolff wrote: > On Dienstag, 31. Januar 2017 20:55:45 CET Justin Berger wrote: > > > I liked the snapshots that were in Stephen Kelly's daemon-mode patch > much > > > > better than an interactive debugger. > > > > I'm not sure these tools

Re: [cmake-developers] What should the behaviour of NUMBER_OF_LOGICAL_CORES be?

2017-01-26 Thread Daniel Pfeifer
Hi, I agree that it should be total number of cores. In addition, cmake_host_system_information() might be extended to provide the number of cores per physical core. This aligns with the information in the XML procuded by CTest: The Site element has the attributes NumberOfLogicalCPU,

Re: [cmake-developers] Security in CMake

2016-08-22 Thread Daniel Pfeifer
Hi Egor, On Sat, Aug 20, 2016 at 1:48 PM, Egor Pugin wrote: > Hi, > > I'm working on a package manager based on cmake. Please rethink that approach. Your package manager should support CMake. It should not be based on it. Your design will be safer and more flexible.

Re: [cmake-developers] Developer tasks - Refactoring

2016-09-07 Thread Daniel Pfeifer
On Wed, Feb 10, 2016 at 12:12 AM, Stephen Kelly wrote: > 3) Compute cmGeneratorTarget state non-lazily in its constructor. > * Historically target state for generators was computed lazily because it > might need to be cleared and re-computed. That is no-longer true.

Re: [cmake-developers] [CMake] Setup/tear down steps for CTest

2016-09-08 Thread Daniel Pfeifer
On Thu, Sep 8, 2016 at 5:52 PM, Brad King wrote: > On 09/08/2016 10:15 AM, Craig Scott wrote: >> the current behaviour of DEPENDS. At the moment, if test B depends >> on test A, test B still executes if test A fails. >> It is unexpected because I'd initially have thought of

Re: [cmake-developers] Is there a way in CMake to get a list of all CTest tests added with add_test?

2016-10-06 Thread Daniel Pfeifer
On Wed, Oct 5, 2016 at 12:54 PM, Nils Gladitz wrote: > On 04.10.2016 11:20, Tobias Hunger wrote: >> >> On Mo, 2016-10-03 at 14:25 -0400, Brad King wrote: The list we need would thus be built up to contain all COMMAND arguments to add_test that are also build

[cmake-developers] variables for top level project version

2016-08-18 Thread Daniel Pfeifer
Hi! The project() command currently sets some variables in both PROJECT_ and _ form. So far good. It also sets CMAKE_PROJECT_NAME to the top level project name. This is not documented. It does not set any other variables of the form CMAKE_PROJECT_. This would be useful for the version

[cmake-developers] semantics of ctest_build(APPEND)

2016-09-26 Thread Daniel Pfeifer
Hi, the documentation of the ctest_build command states "Append semantics are defined by the dashboard server in use." I think this is not precise enough. The client side effect of APPEND is that CTest creates an Append="true" attribute in the XML. It does not append anything to the already

  1   2   >