[cmake-developers] Interface library test failures with VS60

2013-09-13 Thread Stephen Kelly

Hi there,

 http://open.cdash.org/viewTest.php?onlyfailedbuildid=3027577

shows some failures which I can't reproduce as I don't have VS6. Can you 
help finding/fixing the problem?

Thanks,

Steve.

--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


Re: [cmake-developers] Interface library test failures with VS60

2013-09-13 Thread Brad King
On 09/13/2013 07:21 AM, Stephen Kelly wrote:
  http://open.cdash.org/viewTest.php?onlyfailedbuildid=3027577
 
 shows some failures which I can't reproduce as I don't have VS6. Can you 
 help finding/fixing the problem?

Not enough of the VS generators is turned off for interface targets
and the VS 6 generator crashes on them.

Here is a fix to totally drop interface targets from the generation:

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=52ed980d

Most of this change will need to be reverted when support for the
equivalent of make iface is added to the VS generators, but for
now I'm not sure how that should work anyway.

-Brad
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


Re: [cmake-developers] Interface library test failures with VS60

2013-09-13 Thread Stephen Kelly
Brad King wrote:

 On 09/13/2013 07:21 AM, Stephen Kelly wrote:
  http://open.cdash.org/viewTest.php?onlyfailedbuildid=3027577
 
 shows some failures which I can't reproduce as I don't have VS6. Can you
 help finding/fixing the problem?
 
 Not enough of the VS generators is turned off for interface targets
 and the VS 6 generator crashes on them.
 
 Here is a fix to totally drop interface targets from the generation:
 
  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=52ed980d

Terrific, thanks.

 
 Most of this change will need to be reverted when support for the
 equivalent of make iface is added to the VS generators, but for
 now I'm not sure how that should work anyway.

This matches the current state of the other generators anyway. I don't mind 
delaying that part completely for now.

Thanks,

Steve.


--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers