Re: [cmake-developers] Preferred case for macro names?

2018-11-14 Thread Ben Boeckel
On Tue, Nov 13, 2018 at 11:36:24 +0100, Eric Noulard wrote: > > My personal tendency is to use lower case for local variables and upper > > case for global variables. May be we can normalize variables to upper case > > regarding global variables used by CMake itself (which is globally the > >

Re: [cmake-developers] Preferred case for macro names?

2018-11-14 Thread Ben Boeckel
On Tue, Nov 13, 2018 at 06:11:26 -0500, David Cole via cmake-developers wrote: > I would just like to point out that some modules (ExternalData, > ExternalProject, to name two specific examples) adopted the convention > to prefix all their provided function names with the module name and > an

Re: [cmake-developers] Preferred case for macro names?

2018-11-13 Thread David Cole via cmake-developers
I would just like to point out that some modules (ExternalData, ExternalProject, to name two specific examples) adopted the convention to prefix all their provided function names with the module name and an underscore: for example, ExternalProject_Add and ExternalData_Expand_Arguments. These

Re: [cmake-developers] Preferred case for macro names?

2018-11-13 Thread Eric Noulard
Le mar. 13 nov. 2018 à 10:41, Marc CHEVRIER a écrit : > I agree as well that trying to distinguish macros from functions is not a > good idea because functions can act in the same way as macros (i.e. > changing calling environment) but with a better control over environment > changes (changes

Re: [cmake-developers] Preferred case for macro names?

2018-11-13 Thread Eric Noulard
Le mar. 13 nov. 2018 à 00:21, Craig Scott a écrit : > > > On Tue, Nov 13, 2018 at 9:51 AM Joachim Wuttke > wrote: > >> My understanding was that prevalent usage in modern CMake >> is all lowercase for function names, all uppercase for >> macro names. In this sense, I submitted a number of merge

Re: [cmake-developers] Preferred case for macro names?

2018-11-12 Thread Craig Scott
On Tue, Nov 13, 2018 at 9:51 AM Joachim Wuttke wrote: > My understanding was that prevalent usage in modern CMake > is all lowercase for function names, all uppercase for > macro names. In this sense, I submitted a number of merge > requests where function and macro names are normalized, and >