[CMake] Should header files be listed for a target?

2019-09-11 Thread Avraham Shukron
Hi! I'm pretty new to cmake and I came across a question which I could not find any information about in the official documentation or blog posts. When adding a target through add_library / add_executable - should the header files of the target also be listed? The question also applies to

Re: [CMake] Should header files be listed for a target?

2019-09-11 Thread Avraham Shukron
On Wed, Sep 11, 2019 at 9:49 PM Kyle Edwards wrote: > You can list them or not list them. CMake will recognize them as header > files and ignore them (not attempt to compile them.) It's a matter of > personal preference. CMake's own CMake script lists them, but there are > plenty of projects

Re: [CMake] Single library with both shared and static binaries

2019-09-26 Thread Avraham Shukron
g a PIC static library, this is an approach they > can take. > > Regards, > > Juan > > On Wed, Sep 25, 2019 at 8:43 AM Kyle Edwards via CMake > wrote: > >> On Tue, 2019-09-24 at 23:41 +0300, Avraham Shukron wrote: >> > Hi! >> > >> > I have a l

Re: [CMake] Project Structure and add_subdirectory()

2019-09-27 Thread Avraham Shukron
I think option 2 (keeping track on transitive dependencies) should be out of the question. It is bound to fail. Superbuild setup makes sense where all the components are part of a bigger whole. But if each application may depend on a different "flavor" of a dependency library, I think it should

Re: [CMake] Fwd: Linking GSL to cmake using command line

2019-09-24 Thread Avraham Shukron
Hi Sachi! Could you paste a minimal CMakeLists.txt file that demonstrate the problem, along with details about your OS version and how did you install GSL? Thanks! On Tue, Sep 24, 2019 at 7:55 PM Raymond Wan wrote: > Hi Sachi and everyone, > > Sorry, I didn't realise her original message

Re: [CMake] Project Structure and add_subdirectory()

2019-09-28 Thread Avraham Shukron
dependencies will be built. Of course, if you build the "all" target, everything will be built, but that could easily be avoided with EXCLUDE_FROM_ALL when adding the `components` subdirectory. > > *From:* Avraham Shukron > *Sent:* Friday, September 27, 2019 5:23 PM > *To

Re: [CMake] Fwd: Linking GSL to cmake using command line

2019-09-24 Thread Avraham Shukron
ind GSL and set it up > # > macro(find_gsl) > find_package(GSL REQUIRED) > list(APPEND VR_INCLUDE_DIRS ${GSL_INCLUDE_DIRS}) > list(APPEND VR_LIBS ${GSL_LIBRARIES}) > endmacro() > > # > > Thank you! > Best Regards, > Sachi > > On Tue, Sep 24, 2019 at 1:08 PM

[CMake] Single library with both shared and static binaries

2019-09-24 Thread Avraham Shukron
Hi! I have a library which I want to distribute in both shared object and static library forms. Is there a modern way to do it without creating two completely separate library targets? Since I want to be a good CMake citizen I use `target_*` and `set_target_properties` as much as possible, and

Re: [CMake] Fwd: Linking GSL to cmake using command line

2019-09-24 Thread Avraham Shukron
Thanks! > Best regards, > Sachi > > > > On Sep 24, 2019, at 3:08 PM, Avraham Shukron > wrote: > > The macro looks fine (assuming you actually call it somewhere). > And I also assume that the line that fails is the find_package(GSL > REQUIRED) > >