Re: [Cocci] Clarification for source code style reformatting

2014-04-02 Thread SF Markus Elfring
The output is apparently correct and compilable. It is just not kernel style. I'm not sure there is a defect really, just wanted to bring it up. Maybe the first transform could be better written. It seems that the shown differences in source code formatting come from your first semantic

Re: [Cocci] Clarification for source code style reformatting

2014-04-02 Thread Julia Lawall
On Wed, 2 Apr 2014, SF Markus Elfring wrote: The output is apparently correct and compilable. It is just not kernel style. I'm not sure there is a defect really, just wanted to bring it up. Maybe the first transform could be better written. It seems that the shown differences in

Re: [Cocci] Clarification for source code style reformatting

2014-04-02 Thread SF Markus Elfring
The intent of Coccinelle is that the output should follow the Linux coding guidelines. I would find it also useful to support other source code format styles. How do you think about corresponding configuration options for the pretty-printing functionality? Regards, Markus

Re: [Cocci] trivial linux code style reformatting

2014-04-02 Thread SF Markus Elfring
Indeed, it works mostly better, because Coccinelle takes charge of the interaction between the ) and the {, but if ther is some specific spacing in E, that will be lost. Would you like to clarify this implementation detail a bit more? Are there any chances that this software will become able

Re: [Cocci] Clarification for source code style reformatting

2014-04-02 Thread Julia Lawall
On Wed, 2 Apr 2014, SF Markus Elfring wrote: The intent of Coccinelle is that the output should follow the Linux coding guidelines. I would find it also useful to support other source code format styles. How do you think about corresponding configuration options for the pretty-printing