Re: [Cocci] [RFC] drop owner assignment from platform_drivers

2014-10-11 Thread Wolfram Sang
> I missed the one code path you pointed out, and that should be fixed, > but that doesn't mean that the original patch should be reverted, as it > is the way we want things to be, let's just fix up the bug and move on. OK, that is a clear statement. So, what is your opinion on the original clea

Re: [Cocci] [RFC] drop owner assignment from platform_drivers

2014-10-11 Thread Greg KH
On Sat, Oct 11, 2014 at 06:56:51PM +0200, Wolfram Sang wrote: > > > > You got me wondering, though, that it could not be correct to call > > > platform_driver_register() from the platform core instead of module > > > init. I will check tomorrow. Still, this would be a bug independent of > > > my s

Re: [Cocci] [RFC] drop owner assignment from platform_drivers

2014-10-11 Thread Russell King - ARM Linux
On Sat, Oct 11, 2014 at 06:56:51PM +0200, Wolfram Sang wrote: > > > > You got me wondering, though, that it could not be correct to call > > > platform_driver_register() from the platform core instead of module > > > init. I will check tomorrow. Still, this would be a bug independent of > > > my s

Re: [Cocci] [RFC] drop owner assignment from platform_drivers

2014-10-11 Thread Wolfram Sang
> > You got me wondering, though, that it could not be correct to call > > platform_driver_register() from the platform core instead of module > > init. I will check tomorrow. Still, this would be a bug independent of > > my series. Although I'd need to respin it if platform_driver_probe() > > nee