Re: Coccinelle: semantic patch for missing of_node_put

2019-06-04 Thread Markus Elfring
> let add_function f c = > if not (List.mem f !relevant_functions) > then > begin > let s = String.concat " " > ( > (List.map String.lowercase_ascii >(List.filter > (function x -> >Str.string_match >

Re: Coccinelle: semantic patch for missing of_node_put

2019-06-04 Thread Markus Elfring
>> Thus I imagine that an other documentation format would be safer >> and more helpful for the determination of a corresponding API >> system property. > > Our script will remove '* ','\ n','\t' and so on from the comments in the > function header > and then merge them into one line, * Would

Re: [Cocci] Coccinelle: semantic patch for missing of_node_put

2019-06-04 Thread wen.yang99
> > We currently use the following Ocaml script to automatically > > collect functions that need to be considered. > > > > @initialize:ocaml@ > > @@ > > > > let relevant_str = "use of_node_put() on it when done" > > I suggest to reconsider this search pattern. > > The mentioned words are

Re: Coccinelle: semantic patch for missing of_node_put

2019-06-04 Thread Markus Elfring
> We currently use the following Ocaml script to automatically > collect functions that need to be considered. > > @initialize:ocaml@ > @@ > > let relevant_str = "use of_node_put() on it when done" I suggest to reconsider this search pattern. The mentioned words are distributed over text lines