On Sat, 26 Oct 2019, Joe Perches wrote:
> On Sat, 2019-10-26 at 15:54 +0800, zhanglin wrote:
> > memset() the structure ethtool_wolinfo that has padded bytes
> > but the padded bytes have not been zeroed out.
> []
> > diff --git a/net/core/ethtool.c b/net/core/ethtool.c
> []
> > @@ -1471,11
On Sat, 2019-10-26 at 15:54 +0800, zhanglin wrote:
> memset() the structure ethtool_wolinfo that has padded bytes
> but the padded bytes have not been zeroed out.
[]
> diff --git a/net/core/ethtool.c b/net/core/ethtool.c
[]
> @@ -1471,11 +1471,13 @@ static int ethtool_reset(struct net_device *dev,
> Would you like to update the provided software documentation together with
> the small extension of this bash script?
>
> Update candidates:
Please reconsider also the section “Using Coccinelle with a single semantic
patch”:
> Allow defining the environment variable “COCCI” as a directory
> to search SmPL scripts. Start a corresponding file determination
> if it contains an acceptable path.
Would the paragraph formatting be nicer as an enumeration
as I suggested it previously?
Would you like to update the provided
> I would need the semantic patch to understand the problem.
Please take another look at the corresponding clarification request
with the topic “Checking pretty-printing around a transformation for
array_size()”.
https://lore.kernel.org/cocci/384c6657-5ddc-ff47-14e2-2ffad3129...@web.de/
On Sat, 26 Oct 2019, Markus Elfring wrote:
> > But I find the source code formatting occasionally questionable
> > according to the Linux coding style.
>
> elfring@Sonne:~/Projekte/Coccinelle/Probe> spatch
> ../janitor/use_array_size_for_kmemdup2.cocci task_test6.c
> …
> @@ -1,6 +1,6 @@
>
> But I find the source code formatting occasionally questionable
> according to the Linux coding style.
elfring@Sonne:~/Projekte/Coccinelle/Probe> spatch
../janitor/use_array_size_for_kmemdup2.cocci task_test6.c
…
@@ -1,6 +1,6 @@
void* my_task(void)
{
void* copy;
-copy = kmemdup(ohs,
Allow defining the environment variable “COCCI” as a directory
to search SmPL scripts. Start a corresponding file determination
if it contains an acceptable path.
Signed-off-by: zhongshiqi
---
Changes in v4:
1:rewrite change description in another wording
Changes in v3:
