Re: [Cocci] [v4] coccicheck: Support search for SmPL scripts within selecteddirectory hierarchy

2019-10-31 Thread zhong.shiqi
> I suggest to improve the case distinction for the make (and environment) > variable “COCCI” also by adjusting the document outline. > * Empty string > * Directory selection > * File name specification > > See also: >

Re: [Cocci] [PATCH v5] coccicheck: Support search for SmPL scripts withinselected directory hierarchy

2019-10-31 Thread zhong.shiqi
> I got the impression that you are struggling with difficulties (for unknown > reasons) > around adding space characters at some places. > How would you like to improve this situation? Thanks for your concern,but i haven't struggled with anything.I think i'm used to adding space characters.

Re: [Cocci] Moving exception handling code to the end of a function implementation with SmPL?

2019-10-31 Thread Markus Elfring
>>> Unfortunately, I stumble on the error message “replacement: already >>> tagged token: >>> C code context” then. > > This is what I would expect. I came along different application imaginations. > You could use one rule with an exists to put a position variable in the place > where you

Re: [Cocci] Moving exception handling code to the end of a function implementation with SmPL?

2019-10-31 Thread Julia Lawall
On Thu, 31 Oct 2019, Markus Elfring wrote: > > Unfortunately, I stumble on the error message “replacement: already > > tagged token: > > C code context” then. This is what I would expect. You could use one rule with an exists to put a position variable in the place where you want to put

Re: [Cocci] Moving exception handling code to the end of a function implementation with SmPL?

2019-10-31 Thread Markus Elfring
> Unfortunately, I stumble on the error message “replacement: already tagged > token: > C code context” then. It might be that the transformation approach was too generic for the implementation of the function “megasas_mgmt_ioctl_fw”.

Re: [Cocci] xusb-tegra186: Adding a function call behind a label with SmPL?

2019-10-31 Thread Markus Elfring
>> @addition@ >> expression object; >> @@ >>  object = kzalloc(...) >>  ... when any >>  device_unregister(...); >>  out: >> +kfree(object); >>  return ERR_PTR(...); > > There is no reason why a patch should be generated in this case. We come along different software development views also for