Re: [Cocci] Coccinelle: null: Optimise disjunctions in SmPL script “eno.cocci”

2020-10-25 Thread Markus Elfring
>> This analysis result indicates a clear ranking for such function calls. >> Thus reorder the SmPL disjunction items according to their usage incidence. > > Did you actually test this before and after the change and see a > difference in performance? Would you become interested to configure a

Re: [Cocci] Coccinelle: null: Optimise disjunctions in SmPL script “eno.cocci”

2020-10-25 Thread Markus Elfring
>> Would you become interested to configure a representative test environment >> for safe comparisons of corresponding run time characteristics >> of the affected software? > > In what sense could the comparison possibly be unsafe? * Our test systems are obviously different. Thus concerns can

[Cocci] [PATCH] Coccinelle: api: Optimise disjunction in SmPL script “pm_runtime.cocci”

2020-10-25 Thread Markus Elfring
From: Markus Elfring Date: Sun, 25 Oct 2020 14:10:58 +0100 A disjunction is applied by this script for the semantic patch language. This construct uses short-circuit evaluation. It has got the consequence that the last element of the specified condition will only be checked if all previous parts

Re: [Cocci] Coccinelle: null: Optimise disjunctions in SmPL script “eno.cocci”

2020-10-25 Thread Markus Elfring
> In the patch case, the user and system time are essentially identical. > In the context case, the difference in user time is 2 seconds out of 9.5 > minutes, 0.3%. This was just a single test run example. > In the patch case, the real time is a bit slower. I wonder about such an

Re: [Cocci] Coccinelle: null: Optimise disjunctions in SmPL script “eno.cocci”

2020-10-25 Thread Julia Lawall
On Sun, 25 Oct 2020, Markus Elfring wrote: > >> Would you become interested to configure a representative test environment > >> for safe comparisons of corresponding run time characteristics > >> of the affected software? > > > > In what sense could the comparison possibly be unsafe? > > * Our

Re: [Cocci] Coccinelle: null: Optimise disjunctions in SmPL script “eno.cocci”

2020-10-25 Thread Julia Lawall
On Sun, 25 Oct 2020, Markus Elfring wrote: > >> This analysis result indicates a clear ranking for such function calls. > >> Thus reorder the SmPL disjunction items according to their usage incidence. > > > > Did you actually test this before and after the change and see a > > difference in

Re: [Cocci] [PATCH] Coccinelle: null: Optimise disjunctions in SmPL script “eno.cocci”

2020-10-25 Thread Julia Lawall
On Sun, 25 Oct 2020, Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 25 Oct 2020 18:54:36 +0100 > > A disjunction is applied by this script for the semantic patch language. > This construct uses short-circuit evaluation. It has got the consequence > that the last element of the

[Cocci] [PATCH] Coccinelle: null: Optimise disjunctions in SmPL script “eno.cocci”

2020-10-25 Thread Markus Elfring
From: Markus Elfring Date: Sun, 25 Oct 2020 18:54:36 +0100 A disjunction is applied by this script for the semantic patch language. This construct uses short-circuit evaluation. It has got the consequence that the last element of the specified condition will only be checked if all previous parts