Re: [Cocci] [PATCH v2 0/2] of: of_device.h cleanups

2021-02-11 Thread Greg Kroah-Hartman
On Thu, Feb 11, 2021 at 05:27:43PM -0600, Rob Herring wrote: > This is a couple of cleanups for of_device.h. They fell out from my > attempt at decoupling of_device.h and of_platform.h which is a mess > and I haven't finished, but there's no reason to wait on these. Reviewed-by: Greg

[Cocci] [PATCH 1/2] of: Remove of_dev_{get,put}()

2021-02-11 Thread Rob Herring
of_dev_get() and of_dev_put are just wrappers for get_device()/put_device() on a platform_device. There's also already platform_device_{get,put}() wrappers for this purpose. Let's update the few users and remove of_dev_{get,put}(). Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul

[Cocci] [PATCH 0/2] of: of_device.h cleanups

2021-02-11 Thread Rob Herring
This is a couple of cleanups for of_device.h. They fell out from my attempt at decoupling of_device.h and of_platform.h which is a mess and I haven't finished, but there's no reason to wait on these. Rob Rob Herring (2): of: Remove of_dev_{get,put}() driver core: platform: Drop

[Cocci] [PATCH 2/2] driver core: platform: Drop of_device_node_put() wrapper

2021-02-11 Thread Rob Herring
of_device_node_put() is just a wrapper for of_node_put(). The platform driver core is already polluted with of_node pointers and the only 'get' already uses of_node_get() (though typically the get would happen in of_device_alloc()). Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" Cc: Frank

[Cocci] Missing package for Ubuntu 20.04 LTS?

2021-02-11 Thread Taylor Blau
Hi, The Git project recently noticed that our static analysis builds were failing after upgrading to Ubuntu 20.04 due to being unable to find the coccinelle package in the focal suite. https://lore.kernel.org/git/YCGrmsg8J7XT32TM@nand.local/ Searching for coccinelle [1] turns up hits in the

Re: [Cocci] Backward compatibility issue

2021-02-11 Thread Julia Lawall
On Thu, 11 Feb 2021, Denis Efremov wrote: > Hi, one of my patterns started to fail tests on latest coccinelle. > I've bisected the commit that introduces "error". It's: > commit db60e916633d2cb3ae31140364783fdf85ed10f4 > "make information about SmPL iterator and declarer names available to the

[Cocci] Backward compatibility issue

2021-02-11 Thread Denis Efremov
Hi, one of my patterns started to fail tests on latest coccinelle. I've bisected the commit that introduces "error". It's: commit db60e916633d2cb3ae31140364783fdf85ed10f4 "make information about SmPL iterator and declarer names available to the C parser" To reproduce the error: $ cd linux $ git