Re: [Cocci] [PATCH v2 0/2] of: of_device.h cleanups

2021-02-11 Thread Greg Kroah-Hartman
On Thu, Feb 11, 2021 at 05:27:43PM -0600, Rob Herring wrote: > This is a couple of cleanups for of_device.h. They fell out from my > attempt at decoupling of_device.h and of_platform.h which is a mess > and I haven't finished, but there's no reason to wait on these. Reviewed-by: G

Re: [Cocci] [PATCH v2] scripts: coccicheck: Change default value for parallelism

2020-08-14 Thread Greg Kroah-Hartman
time is > minimal > > > > respectively for two separate runs. … > > Can such information trigger further considerations for benchmarking > approaches? > > Regards, > Markus Hi, This is the semi-friendly patch-bot of Greg Kroah-Hartman. Markus, you seem to have sent

Re: [Cocci] [v3] documentation: coccinelle: Improve command example for make C={1, 2}

2020-08-11 Thread Greg Kroah-Hartman
ion. > > How do you think about to clarify the influence of a macro like > “KBUILD_CHECKSRC” > (or the specification “$(call cmd,force_checksrc)”)? > > Will a cross reference for the applied make scripts help to achieve > a better common understanding (and corresponding

Re: [Cocci] [PATCH v4] documentation: coccinelle: Improve command example for make C={1, 2}

2020-08-11 Thread Greg Kroah-Hartman
Hi, This is the semi-friendly patch-bot of Greg Kroah-Hartman. Markus, you seem to have sent a nonsensical or otherwise pointless review comment to a patch submission on a Linux kernel developer mailing list. I strongly suggest that you not do this anymore. Please do not bother developers who

[Cocci] [PATCH 5.4 23/67] scripts: add dummy report mode to add_namespace.cocci

2020-08-10 Thread Greg Kroah-Hartman
kernel.org Cc: cocci@systeme.lip6.fr Cc: sta...@vger.kernel.org Signed-off-by: Matthias Maennich Reported-by: Shuah Khan Acked-by: Julia Lawall Link: https://lore.kernel.org/r/20200604164145.173925-1-maenn...@google.com Signed-off-by: Greg Kroah-Hartman --- scripts/coccinelle/misc/add_na

[Cocci] [PATCH 5.7 21/79] scripts: add dummy report mode to add_namespace.cocci

2020-08-10 Thread Greg Kroah-Hartman
kernel.org Cc: cocci@systeme.lip6.fr Cc: sta...@vger.kernel.org Signed-off-by: Matthias Maennich Reported-by: Shuah Khan Acked-by: Julia Lawall Link: https://lore.kernel.org/r/20200604164145.173925-1-maenn...@google.com Signed-off-by: Greg Kroah-Hartman --- scripts/coccinelle/misc/add_na

[Cocci] [PATCH 5.8 21/38] scripts: add dummy report mode to add_namespace.cocci

2020-08-10 Thread Greg Kroah-Hartman
kernel.org Cc: cocci@systeme.lip6.fr Cc: sta...@vger.kernel.org Signed-off-by: Matthias Maennich Reported-by: Shuah Khan Acked-by: Julia Lawall Link: https://lore.kernel.org/r/20200604164145.173925-1-maenn...@google.com Signed-off-by: Greg Kroah-Hartman --- scripts/coccinelle/misc/add_na

Re: [Cocci] [PATCH] scripts: add dummy report mode to add_namespace.cocci

2020-08-06 Thread Greg Kroah-Hartman
On Thu, Aug 06, 2020 at 01:48:26PM -0600, Shuah Khan wrote: > On 6/22/20 10:14 AM, Shuah Khan wrote: > > On 6/22/20 9:06 AM, Greg Kroah-Hartman wrote: > > > On Mon, Jun 22, 2020 at 08:46:18AM -0600, Shuah Khan wrote: > > > > On 6/22/20 2:03 AM, Matthias Maennich w

Re: [Cocci] [PATCH] scripts: add dummy report mode to add_namespace.cocci

2020-06-22 Thread Greg Kroah-Hartman
On Mon, Jun 22, 2020 at 08:46:18AM -0600, Shuah Khan wrote: > On 6/22/20 2:03 AM, Matthias Maennich wrote: > > On Thu, Jun 04, 2020 at 02:39:18PM -0600, Shuah Khan wrote: > > > On 6/4/20 1:31 PM, Julia Lawall wrote: > > > > > > > > > > > > On Thu, 4 Jun 2020, Matthias Maennich wrote: > > > > >

Re: [Cocci] console: Complete exception handling in newport_probe()

2020-04-23 Thread Greg Kroah-Hartman
On Fri, Apr 24, 2020 at 01:02:45AM +0800, Dejin Zheng wrote: > On Thu, Apr 23, 2020 at 05:23:29PM +0200, Markus Elfring wrote: > > >> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/scripts/coccinelle/free/iounmap.cocci > > >> > > >> How do you think about to extend

Re: [Cocci] [RFC] scripts: Fix coccicheck failed

2019-10-06 Thread Greg Kroah-Hartman
On Sun, Oct 06, 2019 at 07:34:49AM +0200, Markus Elfring wrote: > >> Would you like to increase your software development attention for > >> efficient system configuration on this issue? > > > > No. > > Thanks for this information. > > I am still curious if other contributors will care more for

Re: [PATCH v2 09/29] docs: driver-model: convert docs to ReST and rename to *.rst

2019-06-21 Thread Greg Kroah-Hartman
On Tue, Jun 18, 2019 at 05:53:27PM -0300, Mauro Carvalho Chehab wrote: > Convert the various documents at the driver-model, preparing > them to be part of the driver-api book. > > The conversion is actually: > - add blank lines and identation in order to identify paragraphs; > - fix tables

Re: [PATCH] drivers: Inline code in devm_platform_ioremap_resource() from two functions

2019-06-14 Thread Greg Kroah-Hartman
On Fri, Jun 14, 2019 at 11:22:40AM +0200, Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 14 Jun 2019 11:05:33 +0200 > > Two function calls were combined in this function implementation. > Inline corresponding code so that extra error checks can be avoided here. > > Signed-off-by:

Re: [Cocci] [Outreachy kernel] Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

2017-11-22 Thread Greg Kroah-Hartman
On Wed, Nov 22, 2017 at 10:20:49PM +0100, Julia Lawall wrote: > > > On Wed, 22 Nov 2017, Joe Perches wrote: > > > On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote: > > > There is no need to #define the license of the driver, just put it in > > >

Re: [Cocci] [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

2017-11-22 Thread Greg Kroah-Hartman
On Wed, Nov 22, 2017 at 09:05:36AM -0800, Joe Perches wrote: > On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote: > > There is no need to #define the license of the driver, just put it in > > the MODULE_LICENSE() line directly as a text string. > > > > T

Re: [Cocci] [PATCH 1/2] firmware: Google VPD: import lib_vpd source files

2017-04-11 Thread Greg Kroah-Hartman
On Tue, Apr 11, 2017 at 11:15:54AM -0700, Joe Perches wrote: > On Tue, 2017-04-11 at 16:09 +0200, Greg Kroah-Hartman wrote: > > Care to use "real" kernel variable types please? u8, u16, and others > > are you friend, uint8_t really isn't what we prefer, and check

Re: [Cocci] [PATCH 1/1] staging - rtl8188eu: Deletion of unnecessary checks before three function calls

2014-10-31 Thread Greg Kroah-Hartman
On Thu, Oct 23, 2014 at 09:20:29PM +0200, SF Markus Elfring wrote: From 45970693cad6c12da2d5ac7da3d2bd7a566170d7 Mon Sep 17 00:00:00 2001 From: Markus Elfring elfr...@users.sourceforge.net Date: Thu, 23 Oct 2014 20:55:13 +0200 Subject: [PATCH] staging - rtl8188eu: Deletion of unnecessary