Re: [Cocci] [PATCH] coccinelle: api: detect duplicate chip data arrays

Hi Joe, On Thu, Oct 5, 2017 at 12:30 PM, Joe Perches wrote: > On Thu, 2017-10-05 at 21:19 +0200, Julia Lawall wrote: >> On Thu, 5 Oct 2017, Joe Perches wrote: >> > On Thu, 2017-10-05 at 21:13 +0200, Julia Lawall wrote: >> > > On Fri, 6 Oct 2017, Masahiro Yamada wrote: >> > > >

Re: [Cocci] [PATCH] coccinelle: api: detect duplicate chip data arrays

Hi Julia, On Thu, Oct 5, 2017 at 12:25 PM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Thu, 5 Oct 2017, Liam Breck wrote: > >> Hi, sorry for slow reply... >> >> Can we patch something to make this script run by default on >> bq7_battery_i

Re: [Cocci] [PATCH] coccinelle: api: detect duplicate chip data arrays

Hi Joe, On Thu, Oct 5, 2017 at 12:15 PM, Joe Perches wrote: > On Thu, 2017-10-05 at 21:13 +0200, Julia Lawall wrote: >> >> On Fri, 6 Oct 2017, Masahiro Yamada wrote: >> >> > 2017-10-01 21:42 GMT+09:00 Julia Lawall : >> > > This semantic patch detects

Re: [Cocci] [PATCH] coccinelle: api: detect duplicate chip data arrays

Hi, sorry for slow reply... Can we patch something to make this script run by default on bq7_battery_i2c build? If so let's do that. Also maybe the name of the script should include "bq27xxx_data"? Few more comments below... On Sun, Oct 1, 2017 at 5:42 AM, Julia Lawall

Re: [Cocci] [PATCH v3 0/5] bq27xxx_battery data memory update

On Wed, Sep 27, 2017 at 3:02 AM, Julia Lawall wrote: > The github version of Coccinelle finally supports the semantic patch for Should we add something to the script that aborts if the correct Coccinelle version is not running? > your code. I have attached the semantic

Re: [Cocci] [PATCH v3 0/5] bq27xxx_battery data memory update

On Wed, Sep 27, 2017 at 5:16 AM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Wed, 27 Sep 2017, Liam Breck wrote: > >> Hi Julia, thanks so much for your help! >> >> On Wed, Sep 27, 2017 at 3:02 AM, Julia Lawall <julia.law...@lip6.fr> wrote: >

Re: [Cocci] [PATCH v3 0/5] bq27xxx_battery data memory update

Hi Julia, thanks so much for your help! On Wed, Sep 27, 2017 at 3:02 AM, Julia Lawall wrote: > The github version of Coccinelle finally supports the semantic patch for > your code. I have attached the semantic patch. I wonder what should be > done with this? Do you want

Re: [Cocci] [PATCH v3 0/5] bq27xxx_battery data memory update

On Wed, Sep 20, 2017 at 2:45 AM, Julia Lawall wrote: >> > Also, Coccinelle is comparing the list, but I guess you would prefer that >> > it compare the set, to check for the cases where the names are the same >> > but appear in a different order. >> >> Yes, ideally it would

Re: [Cocci] [PATCH v3 0/5] bq27xxx_battery data memory update

On Wed, Sep 20, 2017 at 2:14 AM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Tue, 19 Sep 2017, Liam Breck wrote: > >> On Tue, Sep 19, 2017 at 3:00 PM, Julia Lawall <julia.law...@lip6.fr> wrote: >> > >> > >> > On Tue, 19 Sep 2017, L

Re: [Cocci] [PATCH v3 0/5] bq27xxx_battery data memory update

On Tue, Sep 19, 2017 at 3:00 PM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Tue, 19 Sep 2017, Liam Breck wrote: > >> Hi Julia, >> >> I think Sebastian referred this to you in hopes of receiving a script >> that would find duplicate arrays, similar

Re: [Cocci] [PATCH v3 0/5] bq27xxx_battery data memory update

/power/supply/bq27xxx_battery.c?h=for-next#n743 The defines can be sed'd to pointers with 0 value, and array comparisons where 1 pointer is 0 can be skipped. Thanks On Sun, Sep 17, 2017 at 10:33 PM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Sun, 17 Sep 2017, Liam Breck

Re: [Cocci] [PATCH v3 0/5] bq27xxx_battery data memory update

Hi Julia, any luck on this? On Thu, Aug 31, 2017 at 4:43 AM, Liam Breck <l...@networkimprov.net> wrote: > On Thu, Aug 31, 2017 at 4:33 AM, Julia Lawall <julia.law...@lip6.fr> wrote: >> >> >> On Thu, 31 Aug 2017, Liam Breck wrote: >> >>> On Thu,

Re: [Cocci] [PATCH v3 0/5] bq27xxx_battery data memory update

On Thu, Aug 31, 2017 at 4:33 AM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Thu, 31 Aug 2017, Liam Breck wrote: > >> On Thu, Aug 31, 2017 at 2:54 AM, Julia Lawall <julia.law...@lip6.fr> wrote: >> > >> > >> > On Tue, 2

Re: [Cocci] [PATCH v3 0/5] bq27xxx_battery data memory update

On Thu, Aug 31, 2017 at 2:54 AM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Tue, 29 Aug 2017, Liam Breck wrote: > >> Coccinelle folks, >> >> On Tue, Aug 29, 2017 at 5:29 PM, Sebastian Reichel >> <sebastian.reic...@collabora.co.uk> wrote:

Re: [Cocci] [PATCH v3 0/5] bq27xxx_battery data memory update

Coccinelle folks, On Tue, Aug 29, 2017 at 5:29 PM, Sebastian Reichel <sebastian.reic...@collabora.co.uk> wrote: > Hi, > > On Tue, Aug 29, 2017 at 04:07:12PM -0700, Liam Breck wrote: >> I don't see a Julia in CC list... > > <_< let's try that again. > >>