Re: [Cocci] [PATCH] scripts: coccinelle: remove check to move constants to right

2016-04-20 Thread Michal Marek
On Sat, Mar 19, 2016 at 06:43:08PM +0100, Julia Lawall wrote: > On Sat, 19 Mar 2016, Wolfram Sang wrote: > > > The header mentions this check depends on personal taste. I agree. > > Running coccicheck on patches before I apply them, this SmPL produced > > enough false positives for me that I'd rat

Re: [Cocci] [PATCH] scripts: coccinelle: remove check to move constants to right

2016-03-30 Thread Wolfram Sang
On Sat, Mar 19, 2016 at 06:43:08PM +0100, Julia Lawall wrote: > On Sat, 19 Mar 2016, Wolfram Sang wrote: > > > The header mentions this check depends on personal taste. I agree. > > Running coccicheck on patches before I apply them, this SmPL produced > > enough false positives for me that I'd rat

Re: [Cocci] [PATCH] scripts: coccinelle: remove check to move constants to right

2016-03-19 Thread Julia Lawall
On Sat, 19 Mar 2016, Wolfram Sang wrote: > On Sat, Mar 19, 2016 at 06:43:08PM +0100, Julia Lawall wrote: > > On Sat, 19 Mar 2016, Wolfram Sang wrote: > > > > > The header mentions this check depends on personal taste. I agree. > > > Running coccicheck on patches before I apply them, this SmPL p

Re: [Cocci] [PATCH] scripts: coccinelle: remove check to move constants to right

2016-03-19 Thread Wolfram Sang
On Sat, Mar 19, 2016 at 06:43:08PM +0100, Julia Lawall wrote: > On Sat, 19 Mar 2016, Wolfram Sang wrote: > > > The header mentions this check depends on personal taste. I agree. > > Running coccicheck on patches before I apply them, this SmPL produced > > enough false positives for me that I'd rat

[Cocci] [PATCH] scripts: coccinelle: remove check to move constants to right

2016-03-19 Thread Wolfram Sang
The header mentions this check depends on personal taste. I agree. Running coccicheck on patches before I apply them, this SmPL produced enough false positives for me that I'd rather see it removed. Signed-off-by: Wolfram Sang --- scripts/coccinelle/misc/compare_const_fl.cocci | 171

Re: [Cocci] [PATCH] scripts: coccinelle: remove check to move constants to right

2016-03-19 Thread Julia Lawall
On Sat, 19 Mar 2016, Wolfram Sang wrote: > The header mentions this check depends on personal taste. I agree. > Running coccicheck on patches before I apply them, this SmPL produced > enough false positives for me that I'd rather see it removed. An improvement is coming up, that should be more ac