Re: [Cocci] [PATCH 00/13] cocci: Align the C AST and SmPL AST for enum

2020-03-09 Thread Jaskaran Singh
On Mon, 2020-03-09 at 15:15 +0100, Julia Lawall wrote: > > On Sun, 8 Mar 2020, Jaskaran Singh wrote: > > > The C AST and SmPL AST differs with respect to the enum type. > > > > For an enumerator, the C AST is as follows: > > Enum -> list of (name, (info, expression)) > > > > For the same,

Re: [Cocci] [PATCH 00/13] cocci: Align the C AST and SmPL AST for enum

2020-03-09 Thread Julia Lawall
On Sun, 8 Mar 2020, Jaskaran Singh wrote: > The C AST and SmPL AST differs with respect to the enum type. > > For an enumerator, the C AST is as follows: > Enum -> list of (name, (info, expression)) > > For the same, the SmPL AST is as follows: > EnumDef -> list of expression > > While

Re: [Cocci] [PATCH 00/13] cocci: Align the C AST and SmPL AST for enum

2020-03-09 Thread Markus Elfring
> The C AST and SmPL AST differs with respect to the enum type. I suggest to consider wording variants. “The … and … differ ….” > collateral evolutions caused by changed in the SmPL visitors are “… by changes in …” Regards, Markus ___ Cocci mailing

[Cocci] [PATCH 00/13] cocci: Align the C AST and SmPL AST for enum

2020-03-08 Thread Jaskaran Singh
The C AST and SmPL AST differs with respect to the enum type. For an enumerator, the C AST is as follows: Enum -> list of (name, (info, expression)) For the same, the SmPL AST is as follows: EnumDef -> list of expression While the SmPL parser does make sure that enumerators