Re: [Cocci] [PATCH 1/1] scripts/coccinelle: use BIT() macro if possible

2014-04-27 Thread Javier Martinez Canillas
Hello Julia, On Sun, Apr 27, 2014 at 11:36 AM, Julia Lawall julia.law...@lip6.fr wrote: On Sun, 27 Apr 2014, Javier Martinez Canillas wrote: Hello Wolfram, Thanks a lot for your feedback. On Sun, Apr 27, 2014 at 7:14 AM, Wolfram Sang w...@the-dreams.de wrote: On Sun, Apr 27, 2014 at

Re: [Cocci] [PATCH 1/1] scripts/coccinelle: use BIT() macro if possible

2014-04-27 Thread Javier Martinez Canillas
On Sun, Apr 27, 2014 at 12:29 PM, Julia Lawall julia.law...@lip6.fr wrote: On Sun, 27 Apr 2014, Javier Martinez Canillas wrote: Using the BIT() macro instead of manually shifting bits makes the code less error prone and also more readable. Signed-off-by: Javier Martinez Canillas

Re: [Cocci] [PATCH 1/1] scripts/coccinelle: use BIT() macro if possible

2014-04-26 Thread Wolfram Sang
On Sun, Apr 27, 2014 at 02:29:46AM +0200, Javier Martinez Canillas wrote: Using the BIT() macro instead of manually shifting bits makes the code less error prone and also more readable. Does it? It is a taste thing, yet I don't think it makes the code that much more readable that it is worth