Re: [Cocci] Checking the occurrence of trailing spaces in a semantic patch

2019-11-01 Thread Markus Elfring
> How would you like to improve the pretty-printing for the Coccinelle software? I can reproduce this glitch by the combination of test files like the following, can't you? @adjustment@ expression result; @@ if (...) -{ -result = -ENODEV; goto - out_kfree_ioc + e_nodev ; -} static

Re: [Cocci] Checking the occurrence of trailing spaces in a semantic patch

2019-11-01 Thread Markus Elfring
> And the unwanted space characters are where? At the end of the shown three lines. Would you like to try the following commands out on the updated source file? * git diff --check … drivers/scsi/megaraid/megaraid_sas_base.c:8275: trailing whitespace. … * scripts/checkpatch.pl --types

Re: [Cocci] Checking the occurrence of trailing spaces in a semantic patch

2019-11-01 Thread Julia Lawall
On Fri, 1 Nov 2019, Markus Elfring wrote: > > The following SmPL script variant can generate an usable test result. > > Yesterday I noticed during the preparation of a corresponding commit > that unwanted space characters were added at three places in the generated > patch. > >

Re: [Cocci] Checking the occurrence of trailing spaces in a semantic patch

2019-11-01 Thread Markus Elfring
> The following SmPL script variant can generate an usable test result. Yesterday I noticed during the preparation of a corresponding commit that unwanted space characters were added at three places in the generated patch. elfring@Sonne:~/Projekte/Linux/next-patched> spatch --in-place