Re: [Cocci] Problem with partial patch generation

On Mon, 15 Feb 2021, Denis Efremov wrote: > > > On 2/15/21 2:47 PM, Julia Lawall wrote: > > > > > > On Mon, 15 Feb 2021, Denis Efremov wrote: > > > >> Hi, > >> > >> I wrote a simple rule (swap.cocci): > >> > >> virtual patch > >> > >> @depends on patch@ > >> identifier tmp; > >> expression a, b

Re: [Cocci] Problem with partial patch generation

On 2/15/21 2:47 PM, Julia Lawall wrote: > > > On Mon, 15 Feb 2021, Denis Efremov wrote: > >> Hi, >> >> I wrote a simple rule (swap.cocci): >> >> virtual patch >> >> @depends on patch@ >> identifier tmp; >> expression a, b; >> type T; >> @@ >> >> ( >> - T tmp; >> | >> - T tmp = 0; >> | >> - T

Re: [Cocci] Problem with partial patch generation

On Mon, 15 Feb 2021, Denis Efremov wrote: > Hi, > > I wrote a simple rule (swap.cocci): > > virtual patch > > @depends on patch@ > identifier tmp; > expression a, b; > type T; > @@ > > ( > - T tmp; > | > - T tmp = 0; > | > - T *tmp = NULL; > ) > ... when != tmp > - tmp = a; > - a = b; > - b = t

Re: [Cocci] Problem with partial patch generation

On Mon, 15 Feb 2021, Denis Efremov wrote: > Hi, > > I wrote a simple rule (swap.cocci): > > virtual patch > > @depends on patch@ > identifier tmp; > expression a, b; > type T; > @@ > > ( > - T tmp; > | > - T tmp = 0; > | > - T *tmp = NULL; > ) > ... when != tmp > - tmp = a; > - a = b; > - b = t

[Cocci] Problem with partial patch generation

Hi, I wrote a simple rule (swap.cocci): virtual patch @depends on patch@ identifier tmp; expression a, b; type T; @@ ( - T tmp; | - T tmp = 0; | - T *tmp = NULL; ) ... when != tmp - tmp = a; - a = b; - b = tmp; + swap(a, b); ... when != tmp I would expect it to remove a local variable only if