Re: [Cocci] [PATCH] parsing_c: Add space for tokens after *

2020-01-16 Thread Jaskaran Singh
On Thu, 2020-01-16 at 17:01 +0530, Jaskaran Singh wrote: > On Thu, 2020-01-16 at 11:59 +0100, Julia Lawall wrote: > > On Thu, 16 Jan 2020, Jaskaran Singh wrote: > > > > > On Thu, 2020-01-16 at 11:40 +0100, Markus Elfring wrote: > > > > > In certain cases, there is no space added after the Pointer

Re: [Cocci] [PATCH] parsing_c: Add space for tokens after *

2020-01-16 Thread Jaskaran Singh
On Thu, 2020-01-16 at 11:59 +0100, Julia Lawall wrote: > > On Thu, 16 Jan 2020, Jaskaran Singh wrote: > > > On Thu, 2020-01-16 at 11:40 +0100, Markus Elfring wrote: > > > > In certain cases, there is no space added after the Pointer > > > > type. > > > > > > Will such a pretty-printing detail

Re: [Cocci] [PATCH] parsing_c: Add space for tokens after *

2020-01-16 Thread Julia Lawall
On Thu, 16 Jan 2020, Jaskaran Singh wrote: > On Thu, 2020-01-16 at 11:40 +0100, Markus Elfring wrote: > > > In certain cases, there is no space added after the Pointer type. > > > > Will such a pretty-printing detail matter also for the clarification > > of > > a topic like “Make change

Re: [Cocci] [PATCH] parsing_c: Add space for tokens after *

2020-01-16 Thread Markus Elfring
> In certain cases, there is no space added after the Pointer type. Will such a pretty-printing detail matter also for the clarification of a topic like “Make change influence configurable for coding style rules”? https://github.com/coccinelle/coccinelle/issues/37 Regards, Markus

Re: [Cocci] [PATCH] parsing_c: Add space for tokens after *

2020-01-16 Thread Julia Lawall
On Thu, 16 Jan 2020, Jaskaran Singh wrote: > In certain cases, there is no space added after the Pointer type. > Examples of such cases are * const, * __attr and * const *. > > In the Pointer case of pp_type_with_ident_rest and pp_type_left, if > the * is followed by anything within the type,