Re: [Cocci] coccinelle: api/devm_platform_ioremap_resource: remove useless script

2019-10-29 Thread Julia Lawall
On Tue, 29 Oct 2019, Masahiro Yamada wrote: > Hi Julia > > On Fri, Oct 25, 2019 at 5:38 PM Julia Lawall wrote: > > > > > > > > On Fri, 25 Oct 2019, Andy Shevchenko wrote: > > > > > On Fri, Oct 25, 2019 at 12:40:52AM +0900, Masahiro Yamada wrote: > > > > On Sun, Oct 20, 2019 at 7:13 AM Joe

Re: [Cocci] coccinelle: api/devm_platform_ioremap_resource: remove useless script

2019-10-29 Thread Masahiro Yamada
Hi Julia On Fri, Oct 25, 2019 at 5:38 PM Julia Lawall wrote: > > > > On Fri, 25 Oct 2019, Andy Shevchenko wrote: > > > On Fri, Oct 25, 2019 at 12:40:52AM +0900, Masahiro Yamada wrote: > > > On Sun, Oct 20, 2019 at 7:13 AM Joe Perches wrote: > > > > On Sat, 2019-10-19 at 21:43 +0100, Marc

Re: [Cocci] coccinelle: api/devm_platform_ioremap_resource: remove useless script

2019-10-25 Thread Andy Shevchenko
On Fri, Oct 25, 2019 at 12:40:52AM +0900, Masahiro Yamada wrote: > On Sun, Oct 20, 2019 at 7:13 AM Joe Perches wrote: > > On Sat, 2019-10-19 at 21:43 +0100, Marc Zyngier wrote: > Alexandre Belloni used > https://lore.kernel.org/lkml/9bbcce19c777583815c92ce3c2ff2...@www.loen.fr/ > as a reference,

Re: [Cocci] coccinelle: api/devm_platform_ioremap_resource: remove useless script

2019-10-25 Thread Julia Lawall
On Fri, 25 Oct 2019, Andy Shevchenko wrote: > On Fri, Oct 25, 2019 at 12:40:52AM +0900, Masahiro Yamada wrote: > > On Sun, Oct 20, 2019 at 7:13 AM Joe Perches wrote: > > > On Sat, 2019-10-19 at 21:43 +0100, Marc Zyngier wrote: > > > Alexandre Belloni used > >

Re: [Cocci] coccinelle: api/devm_platform_ioremap_resource: remove useless script

2019-10-24 Thread Markus Elfring
> I always appreciate the code refactoring > that reduces the object size. Would you like to compare effects around conversions for the mentioned wrapper function any more? Regards, Markus ___ Cocci mailing list Cocci@systeme.lip6.fr

Re: [Cocci] coccinelle: api/devm_platform_ioremap_resource: remove useless script

2019-10-24 Thread Masahiro Yamada
On Sun, Oct 20, 2019 at 7:13 AM Joe Perches wrote: > > On Sat, 2019-10-19 at 21:43 +0100, Marc Zyngier wrote: > > Providing Coccinelle scripts that scream about perfectly valid code is > > pointless, and the result is actively harmful. > > Doubtful. > > If the new code is smaller object code and

Re: coccinelle: api/devm_platform_ioremap_resource: remove useless script

2019-10-20 Thread Marc Zyngier
On Sun, 20 Oct 2019 06:38:30 +0100, Julia Lawall wrote: > > > If said script was providing a correct semantic patch instead of being > > an incentive for people to churn untested patches that span the whole > > tree, that'd be a different story. But that's not what this is about. > > What is

Re: coccinelle: api/devm_platform_ioremap_resource: remove useless script

2019-10-19 Thread Markus Elfring
>>> I think part of the issue is that the script reports a WARNING Would anybody like to change this category to “INFO”? >> How much does this information influence really the stress tolerance >> and change resistance (or acceptance) for the presented collateral evolution? >>

Re: coccinelle: api/devm_platform_ioremap_resource: remove useless script

2019-10-19 Thread Julia Lawall
> If said script was providing a correct semantic patch instead of being > an incentive for people to churn untested patches that span the whole > tree, that'd be a different story. But that's not what this is about. What is the actual incorrectness with the script? An option could be to adjust

Re: coccinelle: api/devm_platform_ioremap_resource: remove useless script

2019-10-19 Thread Joe Perches
On Sat, 2019-10-19 at 21:43 +0100, Marc Zyngier wrote: > Providing Coccinelle scripts that scream about perfectly valid code is > pointless, and the result is actively harmful. Doubtful. If the new code is smaller object code and correct than the conversion is worthwhile. fyi: There are

Re: coccinelle: api/devm_platform_ioremap_resource: remove useless script

2019-10-19 Thread Marc Zyngier
On Sat, 19 Oct 2019 12:35:49 +0100, Markus Elfring wrote: > > > I think part of the issue is that the script reports a WARNING > > How much does this information influence really the stress tolerance > and change resistance (or acceptance) for the presented collateral evolution? >

Re: [PATCH] coccinelle: api/devm_platform_ioremap_resource: remove useless script

2019-10-19 Thread Markus Elfring
> Markus has been black-listed by several core maintainers already, I am still curious if this communication filter will ever be adjusted in more positive directions. > I think you're wasting your time arguing. I hope that also this software development discussion can become more constructive.

Re: [PATCH] coccinelle: api/devm_platform_ioremap_resource: remove useless script

2019-10-19 Thread Bartosz Golaszewski
sob., 19 paź 2019 o 14:09 Alexandre Belloni napisał(a): > > On 19/10/2019 11:00:47+0200, Markus Elfring wrote: > > > While it is useful for new drivers to use devm_platform_ioremap_resource, > > > > This is nice. > > > > > > > this script is currently used to spam maintainers, > > > > This view

Re: [Cocci] coccinelle: api/devm_platform_ioremap_resource: remove useless script

2019-10-19 Thread Markus Elfring
> What are the additional effects? I suggest to take another look at the commit 7945f929f1a77a1c8887a97ca07f87626858ff42 ("drivers: provide devm_platform_ioremap_resource()" from 2019-02-20) which triggered the discussed software evolution.

Re: [PATCH] coccinelle: api/devm_platform_ioremap_resource: remove useless script

2019-10-19 Thread Alexandre Belloni
On 19/10/2019 11:00:47+0200, Markus Elfring wrote: > > While it is useful for new drivers to use devm_platform_ioremap_resource, > > This is nice. > > > > this script is currently used to spam maintainers, > > This view is unfortunate. > > Do we stumble on a target conflict again? > > > >

Re: [Cocci] coccinelle: api/devm_platform_ioremap_resource: remove useless script

2019-10-19 Thread Markus Elfring
> I think part of the issue is that the script reports a WARNING How much does this information influence really the stress tolerance and change resistance (or acceptance) for the presented collateral evolution?

Re: [PATCH] coccinelle: api/devm_platform_ioremap_resource: remove useless script

2019-10-19 Thread Markus Elfring
> While it is useful for new drivers to use devm_platform_ioremap_resource, This is nice. > this script is currently used to spam maintainers, This view is unfortunate. Do we stumble on a target conflict again? > often updating very old drivers. This can also happen. > The net benefit is