Re: [Cocci] semantic patch feasibility

2014-04-26 Thread SF Markus Elfring
Besides moving the function pointers assigned to the structure gpio_chip fields to the new struct gpio_chip_ops, a pointer to the new struct gpio_chip_ops has to be assigned to the struct gpio_chip .ops field. Will any macros become relevant for such a source code reorganisation? So where

Re: [Cocci] Extract an interface with SmPL

2014-04-26 Thread Julia Lawall
Would you like to extend it with approaches for source code refactoring? I think it would be best that he stick to the problem at hand. Probably the only change that will have to be made in the spatch is the regular expression to filter the function names and the name of the two data

Re: [Cocci] Extract an interface with SmPL

2014-04-26 Thread Javier Martinez Canillas
On Sat, Apr 26, 2014 at 6:06 PM, Julia Lawall julia.law...@lip6.fr wrote: Would you like to extend it with approaches for source code refactoring? I think it would be best that he stick to the problem at hand. Agreed, I prefer to first finish this task and maybe add the spatch to the

Re: [Cocci] [PATCH 1/1] scripts/coccinelle: use BIT() macro if possible

2014-04-26 Thread Wolfram Sang
On Sun, Apr 27, 2014 at 02:29:46AM +0200, Javier Martinez Canillas wrote: Using the BIT() macro instead of manually shifting bits makes the code less error prone and also more readable. Does it? It is a taste thing, yet I don't think it makes the code that much more readable that it is worth