Re: [Cocci] [PATCH v2 net] nfp: cast sizeof() to int when comparing with error code

2018-06-25 Thread Joe Perches
On Tue, 2018-06-26 at 09:16 +0800, Chengguang Xu wrote: > sizeof() will return unsigned value so in the error check > negative error code will be always larger than sizeof(). This looks like a general class of error in the kernel where a signed result that could be returning a -errno is tested

Re: [Cocci] Parse error with genl-const.cocci

2018-06-25 Thread Johannes Berg
Julia, > I updated the github version of Coccinelle such that > patches/0027-genl-const/genl-const.cocci > will almost parse correctly. The only thing that remains is to change > attribute into attribute name. I'm not sure why, but for some reason I thought back then (https://git.k

Re: [Cocci] Support for C++ delete expressions

2018-06-25 Thread Julia Lawall
On Mon, 25 Jun 2018, SF Markus Elfring wrote: > > delete [] is now supported by the C++ parser (ie with option --c++). > > This is nice. > > > > Note that no C++ specific operators are supported by the semantic > > patch language. > > How will the software situation evolve further for

[Cocci] coccinelle computes patch very slowly

2018-06-25 Thread Michele Martone
Dear Coccinelle Team, While patching source files of a few thousand lines long, I noticed prohibitively long patch compute times (seemed hanged). This effectively prevented spatch from being usable. I attach a minimalistic program and patch replicating the problem. It seems like presence of