Re: [Cocci] [v6] coccinelle: semantic code search for missing put_device()

2019-02-17 Thread Julia Lawall
On Mon, 18 Feb 2019, wen.yan...@zte.com.cn wrote: > > > when != e = id achieves this behavior. > > > > I can not agree to this view completely because of the meaning that is > > connected > > with these variable identifiers. > > > > Both metavariables share the kind “expression”. So I can imagi

Re: [Cocci] [v6] coccinelle: semantic code search for missing put_device()

2019-02-17 Thread wen.yang99
> > when != e = id achieves this behavior. > > I can not agree to this view completely because of the meaning that is > connected > with these variable identifiers. > > Both metavariables share the kind “expression”. So I can imagine > that there is an intersection for the source code match poss

Re: [Cocci] [v6] coccinelle: semantic code search for missing put_device()

2019-02-17 Thread Markus Elfring
>> … >> +@search exists@ >> +local idexpression id; >> +expression x,e,e1; >> +position p1,p2; >> … >> +@@ >> + >> +id = of_find_device_by_node@p1(x) >> +... when != e = id >> … >> >> Or: >> >> … >> + ... when != id = e >> … >> >> >> Which SmPL specification will achieve the desired software behavi

Re: [Cocci] [v6] coccinelle: semantic code search for missing put_device()

2019-02-17 Thread Julia Lawall
On Sun, 17 Feb 2019, Markus Elfring wrote: > >> If you would insist on the specification of such an assignment exclusion > >> for a SmPL ellipsis: > >> Can we agree on a correct order? > > > > I don't get your point. > > I propose to take another closer look at a bit of SmPL code. > > > > There

Re: [Cocci] [v6] coccinelle: semantic code search for missing put_device()

2019-02-17 Thread Markus Elfring
>> If you would insist on the specification of such an assignment exclusion >> for a SmPL ellipsis: >> Can we agree on a correct order? > > I don't get your point. I propose to take another closer look at a bit of SmPL code. > There is no correct order. I have got an other software development

Re: [Cocci] [v6] coccinelle: semantic code search for missing put_device()

2019-02-17 Thread Julia Lawall
On Sun, 17 Feb 2019, Markus Elfring wrote: > >> Would you dare to interpret my update suggestion (reordering of two > >> identifiers) > >> as a required SmPL script correction? > > > > I didn't suggest to reorder anything. > > This is obvious according to your acknowledgement for the sixth ver

Re: [Cocci] [v6] coccinelle: semantic code search for missing put_device()

2019-02-17 Thread Markus Elfring
>> Would you dare to interpret my update suggestion (reordering of two >> identifiers) >> as a required SmPL script correction? > > I didn't suggest to reorder anything. This is obvious according to your acknowledgement for the sixth version of this evolving SmPL script. > Both are needed. If

Re: [Cocci] [PATCH v6] coccinelle: semantic code search for missing put_device()

2019-02-17 Thread Julia Lawall
On Sun, 17 Feb 2019, Markus Elfring wrote: > >>> +@search exists@ > >>> +local idexpression id; > >>> +expression x,e,e1; > >>> +position p1,p2; > >>> +type T,T1,T2; > >>> +@@ > >>> + > >>> +id = of_find_device_by_node@p1(x) > >>> +... when != e = id > >> > >> I suggest to increase your softwar

Re: [Cocci] [PATCH v6] coccinelle: semantic code search for missing put_device()

2019-02-17 Thread Markus Elfring
>>> +@search exists@ >>> +local idexpression id; >>> +expression x,e,e1; >>> +position p1,p2; >>> +type T,T1,T2; >>> +@@ >>> + >>> +id = of_find_device_by_node@p1(x) >>> +... when != e = id >> >> I suggest to increase your software development attention also for >> another implementation detail. >>

Re: [Cocci] [PATCH v6] coccinelle: semantic code search for missing put_device()

2019-02-17 Thread Julia Lawall
On Sun, 17 Feb 2019, Markus Elfring wrote: > > +@search exists@ > > +local idexpression id; > > +expression x,e,e1; > > +position p1,p2; > > +type T,T1,T2; > > +@@ > > + > > +id = of_find_device_by_node@p1(x) > > +... when != e = id > > I suggest to increase your software development attention

Re: [Cocci] [PATCH v6] coccinelle: semantic code search for missing put_device()

2019-02-17 Thread Markus Elfring
> +@search exists@ > +local idexpression id; > +expression x,e,e1; > +position p1,p2; > +type T,T1,T2; > +@@ > + > +id = of_find_device_by_node@p1(x) > +... when != e = id I suggest to increase your software development attention also for another implementation detail. Source code analysis trigger