> > Do you mean that the C file/res file should conform to the Linux style?
>
> I think it would be nicer if it did.
Is the interest for the clarification of a topic like “Make change influence
configurable for coding style rules” growing?
https://github.com/coccinelle/coccinelle/issues/37
Regard
On Sun, 9 Feb 2020, Jaskaran Singh wrote:
> On Sun, 2020-02-09 at 17:48 +0100, Julia Lawall wrote:
> > On Sun, 9 Feb 2020, Jaskaran Singh wrote:
> >
> > > Pointer to const pointer and its variants would not match
> > > previously.
> > > Add a test case for matching these types.
> > >
> > > Sign
On Sun, 2020-02-09 at 17:48 +0100, Julia Lawall wrote:
> On Sun, 9 Feb 2020, Jaskaran Singh wrote:
>
> > Pointer to const pointer and its variants would not match
> > previously.
> > Add a test case for matching these types.
> >
> > Signed-off-by: Jaskaran Singh
> > ---
> > tests/constptr.c
On Sun, 9 Feb 2020, Jaskaran Singh wrote:
> Pointer to const pointer and its variants would not match previously.
> Add a test case for matching these types.
>
> Signed-off-by: Jaskaran Singh
> ---
> tests/constptr.c | 7 +++
> tests/constptr.cocci | 19 +++
> tests/cons
On Sun, 9 Feb 2020, Jaskaran Singh wrote:
> For a pointer, the C parser constructed an AST dissimilar from that
> of the Cocci AST. This caused failures in matching with certain
> pointer types. For example, for the following case:
>
> char *1 const *2 id;
>
> The C AST constructed would be:
> con
A space is now added between the * and qualifier. Reflect this
change in the ptrconstptr test case.
Signed-off-by: Jaskaran Singh
---
tests/ptrconstptr.res | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/ptrconstptr.res b/tests/ptrconstptr.res
index f5b2210c..1d0c3c1d 1
Pointer to const pointer and its variants would not match previously.
Add a test case for matching these types.
Signed-off-by: Jaskaran Singh
---
tests/constptr.c | 7 +++
tests/constptr.cocci | 19 +++
tests/constptr.res | 7 +++
3 files changed, 33 insertions(+)
For a pointer, the C parser constructed an AST dissimilar from that
of the Cocci AST. This caused failures in matching with certain
pointer types. For example, for the following case:
char *1 const *2 id;
The C AST constructed would be:
const Pointer1 -> Pointer2 -> char
The Cocci AST constructe
This series is to address the type matching problem in Coccinelle.
Patch 1/3 is for aligning the C and Cocci AST so that
pointer to const pointer and its variants can be matched.
Patch 2/3 reflects the pretty printing changes made in
1/3 in the ptrconstptr test case. A space is added between
the
On Sun, 9 Feb 2020, Jaskaran Singh wrote:
> For a pointer, the C parser constructed an AST dissimilar from that
> of the Cocci AST. This caused failures in matching with certain
> pointer types. For example, for the following case:
>
> char *1 const *2 id;
>
> The C AST constructed would be:
> con
A space is now added between the * and qualifier. Reflect this
change in the ptrconstptr test case.
Signed-off-by: Jaskaran Singh
---
tests/ptrconstptr.res | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/ptrconstptr.res b/tests/ptrconstptr.res
index f5b2210c..1d0c3c1d 1
Pointer to const pointer and its variants would not match previously.
Add a test case for matching these types.
Signed-off-by: Jaskaran Singh
---
tests/constptr.c | 7 +++
tests/constptr.cocci | 19 +++
tests/constptr.res | 7 +++
3 files changed, 33 insertions(+)
For a pointer, the C parser constructed an AST dissimilar from that
of the Cocci AST. This caused failures in matching with certain
pointer types. For example, for the following case:
char *1 const *2 id;
The C AST constructed would be:
const Pointer1 -> Pointer2 -> char
The Cocci AST constructe
This series is to address the type matching problem in Coccinelle.
Patch 1/3 is for aligning the C and Cocci AST so that
pointer to const pointer and its variants can be matched.
Patch 2/3 reflects the pretty printing changes made in
1/3 in the ptrconstptr test case. A space is added between
the
>> https://en.wikipedia.org/wiki/AST
>
> Not necessary. Anyone who is looking at the Coccinelle commits should
> know what an AST is.
I would appreciate to reduce the potential for confusion around
the application of parsing technologies.
Regards,
Markus
_
On Sun, 9 Feb 2020, Markus Elfring wrote:
> > For a pointer, the C parser constructed an AST dissimilar from that
>
> I find it helpful to mention the meaning of the term “AST” without
> abbreviation
> for a nicer patch description.
> https://en.wikipedia.org/wiki/AST
Not necessary. Anyone who
> For a pointer, the C parser constructed an AST dissimilar from that
I find it helpful to mention the meaning of the term “AST” without abbreviation
for a nicer patch description.
https://en.wikipedia.org/wiki/AST
Regards,
Markus
___
Cocci mailing list
> + const char *const *y;
> }
>
> There should be a space between * and const on the + line.
Will such a detail become more interesting for the clarification
around coding styles?
https://github.com/coccinelle/coccinelle/issues/37
Regards,
Markus
_
On Sun, 9 Feb 2020, Markus Elfring wrote:
> > Like what?
>
> Do find my corresponding previous suggestion reasonable?
> https://lore.kernel.org/cocci/702596c2-84bf-13ca-b014-8784bbb98...@web.de/
> https://systeme.lip6.fr/pipermail/cocci/2020-February/006842.html
I have absolutely no preference ei
> Like what?
Do find my corresponding previous suggestion reasonable?
https://lore.kernel.org/cocci/702596c2-84bf-13ca-b014-8784bbb98...@web.de/
https://systeme.lip6.fr/pipermail/cocci/2020-February/006842.html
Regards,
Markus
___
Cocci mailing list
Coc
On Sun, 9 Feb 2020, Markus Elfring wrote:
> > This series is to address …
>
> Under which circumstances would you choose an adjusted wording for the message
> in the cover letter?
Like what?
If you are referring to something that occurs 5 lines below what you have
quoted, please include the spec
> This series is to address …
Under which circumstances would you choose an adjusted wording for the message
in the cover letter?
Regards,
Markus
___
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
On Sun, 2020-02-09 at 09:07 +0100, Julia Lawall wrote:
> On Sun, 9 Feb 2020, Jaskaran Singh wrote:
>
> > On Sun, 2020-02-09 at 08:20 +0100, Julia Lawall wrote:
> > > On Fri, 7 Feb 2020, Jaskaran Singh wrote:
> > >
> > > > Pointer to const pointer and its variants would not match
> > > > previousl
On Sun, 9 Feb 2020, Jaskaran Singh wrote:
> On Sun, 2020-02-09 at 08:20 +0100, Julia Lawall wrote:
> > On Fri, 7 Feb 2020, Jaskaran Singh wrote:
> >
> > > Pointer to const pointer and its variants would not match
> > > previously.
> > > Add a test case for matching these types.
> >
> > I don't get
On Sun, 2020-02-09 at 08:20 +0100, Julia Lawall wrote:
> On Fri, 7 Feb 2020, Jaskaran Singh wrote:
>
> > Pointer to const pointer and its variants would not match
> > previously.
> > Add a test case for matching these types.
>
> I don't get any matches for this test. If I split the semantic patc
25 matches
Mail list logo
