Re: [Cocci] console: Complete exception handling in newport_probe()

2020-04-23 Thread Markus Elfring
> Please note you are responding to someone who many kernel maintainers, > myself included, have on their blacklist You configured your communication filters for some reasons in this way. > as they are totally unhelpful. The development views can vary also around my software contributions. It

Re: [Cocci] console: Complete exception handling in newport_probe()

2020-04-23 Thread Greg Kroah-Hartman
On Fri, Apr 24, 2020 at 01:02:45AM +0800, Dejin Zheng wrote: > On Thu, Apr 23, 2020 at 05:23:29PM +0200, Markus Elfring wrote: > > >> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/scripts/coccinelle/free/iounmap.cocci > > >> > > >> How do you think about to extend

Re: [Cocci] console: Complete exception handling in newport_probe()

2020-04-23 Thread Markus Elfring
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/scripts/coccinelle/free/iounmap.cocci … > Sorry, I do not know how to use the SmPL script. I proposed to take another look at the header of such a file. I imagine that provided information can trigger further development

Re: [Cocci] console: Complete exception handling in newport_probe()

2020-04-23 Thread Markus Elfring
>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/scripts/coccinelle/free/iounmap.cocci >> >> How do you think about to extend presented software analysis approaches? >> > Sorry, I am not familiar with it, I don't know. Do you find the comments helpful at the beginning of

Re: [Cocci] [PATCH v1] console: fix an issue about ioremap leak.

2020-04-23 Thread Markus Elfring
> if do_take_over_console() return an error in the newport_probe(), > due to the io virtual address is not released, it will cause a leak. How do you think about a wording variant like the following? Subject: [PATCH v2] console: Complete exception handling in newport_probe() Change