Re: [Cocci] [RFC PATCH 00/25] cocci: Improve C parsing of attributes

2020-04-25 Thread Jaskaran Singh
On Fri, 2020-04-24 at 14:02 +0200, Markus Elfring wrote:
> > This patch series aims to improve parsing of attributes in C by
> > Coccinelle's C parser.
> 
> How do you think about to use the wording “in C source code by”?
> 
> 
> > These parsing errors were discovered by running a build of
> > Coccinelle's
> 
> Would you like to omit the word “These”?
> 

Hi Markus,

Could you please keep your feedback relevant to the actual patch itself
(or the commit messages)? Maybe pull the patches, apply them, run them
yourself, see if something breaks? Feedback like this really isn't
relevant, unless these minor typos/grammartical errors cause a _lot_
of confusion.

> 
> > Coccinelle currently manages attributes similar to comments,
> 
> Will this aspect trigger further software development considerations?
> 

I don't know.

> 
> > so to explicity state what the attributes are to the C parser,
> > a MACROANNOTATION hint was used in Coccinelle's standard.h file.
> 
> I find such information suspicious at first glance.
> Additional background information from an update step like
> “[RFC PATCH 12/25] parsing_c: cpp_token_c: Introduce MACROANNOTATION
> hint”
> might make the proposed data processing approach more reasonable.
> https://lore.kernel.org/cocci/20200424091801.13871-13-jaskaransingh7654...@gmail.com/
> https://systeme.lip6.fr/pipermail/cocci/2020-April/007217.html
> 
> 
> > Separate patches will be sent for the above.
> 
> I am curious how the software evolution will be continued here.
> 

Good to know.

Cheers,
Jaskaran.

> Regards,
> Markus

___
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci


Re: [Cocci] [RFC PATCH 00/25] cocci: Improve C parsing of attributes

2020-04-24 Thread Markus Elfring
> This patch series aims to improve parsing of attributes in C by
> Coccinelle's C parser.

How do you think about to use the wording “in C source code by”?


> These parsing errors were discovered by running a build of Coccinelle's

Would you like to omit the word “These”?


> Coccinelle currently manages attributes similar to comments,

Will this aspect trigger further software development considerations?


> so to explicity state what the attributes are to the C parser,
> a MACROANNOTATION hint was used in Coccinelle's standard.h file.

I find such information suspicious at first glance.
Additional background information from an update step like
“[RFC PATCH 12/25] parsing_c: cpp_token_c: Introduce MACROANNOTATION hint”
might make the proposed data processing approach more reasonable.
https://lore.kernel.org/cocci/20200424091801.13871-13-jaskaransingh7654...@gmail.com/
https://systeme.lip6.fr/pipermail/cocci/2020-April/007217.html


> Separate patches will be sent for the above.

I am curious how the software evolution will be continued here.

Regards,
Markus
___
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci


[Cocci] [RFC PATCH 00/25] cocci: Improve C parsing of attributes

2020-04-24 Thread Jaskaran Singh
This patch series aims to improve parsing of attributes in C by
Coccinelle's C parser.

These parsing errors were discovered by running a build of Coccinelle's
master branch on gitlab to parse the source code of Linux v5.5-rc4 and Linux
v5.6-rc7. Coccinelle currently manages attributes similar to comments, so
to explicity state what the attributes are to the C parser, a
MACROANNOTATION hint was used in Coccinelle's standard.h file. The hint
enables the parser to correctly identify attributes, and thus potentially
handle them differently in the AST.

Upon collection of these parsing errors, The GNU C Compiler's
grammar was taken as a reference for introducing attributes in correct
places in Coccinelle's C parser.

Upon applying the MACROANNOTATION hint to a majority of the attributes in
Coccinelle's standard.h file and parsing the source code of Linux
v5.6-rc7, the difference between the stats (of --parse-c) before and
after applying this patch series are as follows:

Before:

NB total files = 28268; perfect = 25697; pbs = 2570; timeout = 0; 
=> 90%
nb good = 19160664,  nb passed = 135235 => 0.70% passed
nb good = 19160664,  nb bad = 129685 => 99.33% good or passed

After:

NB total files = 28268; perfect = 25699; pbs = 2568; timeout = 0; 
=> 90%
nb good = 19160856,  nb passed = 71716 => 0.37% passed
nb good = 19160856,  nb bad = 129493 => 99.33% good or passed

Fixes for a few test case failures that arise from applying the new
productions are also included. The test cases that failed were:

unstruct
nocast

What this patch series does not do:
- Add attributes from all the new productions into the C AST. Some of
  these are dropped.
- Reflect changes from the C parser in the SmPL parser.

Separate patches will be sent for the above.

Jaskaran Singh (25):
  parsing_c: parse_c: Ignore TMacroAttr and TMacroEndAttr in passed tokens
  parsing_c: parsing_hacks: Label end attributes correctly
  parsing_c: parsing_hacks: Commentize attributes before qualif/type
  parsing_c: parser: Add rule for multiple end attributes
  parsing_c: parser: Add expression statement attributes
  parsing_c: parser: Add attribute production in spec_qualif_list
  parsing_c: parser: Add init_declarator_attrs rule
  parsing_c: parser: Add field declaration end attributes production
  parsing_c: parser: Handle struct/union/enum end attributes
  parsing_c: parser: Add MacroDecl end attributes production
  parsing_c: parser: cpp_other end attributes production
  parsing_c: cpp_token_c: Introduce MACROANNOTATION hint
  cocci: standard.h: Annotate attributes with MACROANNOTATION
  parsing_c: visitor_c: Add vk_attribute and vk_attribute_s
  parsing_c: lib_parsing_c: Add ii_of_attr
  engine: Add distrf_attr to PARAM functor
  engine: cocci_vs_c: Add allminus argument to attribute_list
  parsing_c: parser: Make abstract_declarator pass attributes
  cocci: Add parameter attributes to C AST
  parsing_c: parser: Place parameter attributes in C AST
  parsing_c: visitor_c: Visit parameter attributes
  parsing_c: unparse_hrule: Add parameter attributes in record
  parsing_c: type_c: Add parameter attributes to record
  engine: cocci_vs_c: "Match" parameter attributes
  engine: c_vs_c: Match parameter attributes

 engine/c_vs_c.ml|   12 ++-
 engine/cocci_vs_c.ml|   85 +-
 engine/cocci_vs_c.mli   |3 
 engine/pattern_c.ml |1 
 engine/transformation_c.ml  |5 +
 ocaml/coccilib.mli  |1 
 parsing_c/ast_c.ml  |1 
 parsing_c/ast_c.mli |1 
 parsing_c/cpp_token_c.ml|2 
 parsing_c/lib_parsing_c.ml  |1 
 parsing_c/lib_parsing_c.mli |1 
 parsing_c/parse_c.ml|4 -
 parsing_c/parser_c.mly  |  165 +---
 parsing_c/parsing_hacks.ml  |   37 +
 parsing_c/type_c.ml |1 
 parsing_c/unparse_hrule.ml  |3 
 parsing_c/visitor_c.ml  |7 +
 parsing_c/visitor_c.mli |3 
 standard.h  |  116 +++---
 19 files changed, 342 insertions(+), 107 deletions(-)



___
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci