Re: [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script

2018-06-18 Thread Masahiro Yamada
2018-06-15 14:06 GMT+09:00 Julia Lawall : > > > On Thu, 14 Jun 2018, Kees Cook wrote: > >> On Fri, Sep 1, 2017 at 2:40 AM, Elena Reshetova >> wrote: >> > atomic_as_refcounter.cocci script allows detecting >> > cases when refcount_t type and API should be used >> > instead of atomic_t. >> > >> >

Re: [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script

2018-06-14 Thread Julia Lawall
On Thu, 14 Jun 2018, Kees Cook wrote: > On Fri, Sep 1, 2017 at 2:40 AM, Elena Reshetova > wrote: > > atomic_as_refcounter.cocci script allows detecting > > cases when refcount_t type and API should be used > > instead of atomic_t. > > > > Signed-off-by: Elena Reshetova > > Acked-by: Julia

Re: [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script

2018-06-14 Thread Kees Cook
On Fri, Sep 1, 2017 at 2:40 AM, Elena Reshetova wrote: > atomic_as_refcounter.cocci script allows detecting > cases when refcount_t type and API should be used > instead of atomic_t. > > Signed-off-by: Elena Reshetova > Acked-by: Julia Lawall Reviewed-by: Kees Cook Oops, I think this got

[Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script

2017-09-01 Thread Elena Reshetova
atomic_as_refcounter.cocci script allows detecting cases when refcount_t type and API should be used instead of atomic_t. Signed-off-by: Elena Reshetova Acked-by: Julia Lawall --- scripts/coccinelle/api/atomic_as_refcounter.cocci | 131

Re: [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script

2017-08-31 Thread Reshetova, Elena
> On Wed, 30 Aug 2017, Reshetova, Elena wrote: > > > > > > > > > On Wed, 30 Aug 2017, Elena Reshetova wrote: > > > > > > > atomic_as_refcounter.cocci script allows detecting > > > > cases when refcount_t type and API should be used > > > > instead of atomic_t. > > > > > > > > Signed-off-by: Elena

Re: [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script

2017-08-30 Thread Julia Lawall
On Wed, 30 Aug 2017, Reshetova, Elena wrote: > > > > > On Wed, 30 Aug 2017, Elena Reshetova wrote: > > > > > atomic_as_refcounter.cocci script allows detecting > > > cases when refcount_t type and API should be used > > > instead of atomic_t. > > > > > > Signed-off-by: Elena Reshetova

Re: [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script

2017-08-30 Thread Reshetova, Elena
> > On Wed, 30 Aug 2017, Elena Reshetova wrote: > > > atomic_as_refcounter.cocci script allows detecting > > cases when refcount_t type and API should be used > > instead of atomic_t. > > > > Signed-off-by: Elena Reshetova > > Acked-by: Julia Lawall

Re: [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script

2017-08-30 Thread Julia Lawall
On Wed, 30 Aug 2017, Elena Reshetova wrote: > atomic_as_refcounter.cocci script allows detecting > cases when refcount_t type and API should be used > instead of atomic_t. > > Signed-off-by: Elena Reshetova Acked-by: Julia Lawall > --- >

[Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script

2017-08-30 Thread Elena Reshetova
atomic_as_refcounter.cocci script allows detecting cases when refcount_t type and API should be used instead of atomic_t. Signed-off-by: Elena Reshetova --- scripts/coccinelle/api/atomic_as_refcounter.cocci | 131 ++ 1 file changed, 131

Re: [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script

2017-08-29 Thread Reshetova, Elena
> > +identifier fname =~ ".*free.*"; > > +identifier fname2 =~ ".*destroy.*"; > > +identifier fname3 =~ ".*del.*"; > > +identifier fname4 =~ ".*queue_work.*"; > > +identifier fname5 =~ ".*schedule_work.*"; > > +identifier fname6 =~ ".*call_rcu.*"; > > Personally, I find the above regular

Re: [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script

2017-08-17 Thread Julia Lawall
> +identifier fname =~ ".*free.*"; > +identifier fname2 =~ ".*destroy.*"; > +identifier fname3 =~ ".*del.*"; > +identifier fname4 =~ ".*queue_work.*"; > +identifier fname5 =~ ".*schedule_work.*"; > +identifier fname6 =~ ".*call_rcu.*"; Personally, I find the above regular expressions much easier

[Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script

2017-08-16 Thread Elena Reshetova
atomic_as_refcounter.cocci script allows detecting cases when refcount_t type and API should be used instead of atomic_t. Signed-off-by: Elena Reshetova --- scripts/coccinelle/api/atomic_as_refcounter.cocci | 133 ++ 1 file changed, 133

Re: [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script

2017-08-15 Thread Reshetova, Elena
> On Mon, 14 Aug 2017, Elena Reshetova wrote: > > > atomic_as_refcounter.cocci script allows detecting > > cases when refcount_t type and API should be used > > instead of atomic_t. > > > > Signed-off-by: Elena Reshetova > > --- > >

Re: [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script

2017-08-14 Thread Julia Lawall
On Mon, 14 Aug 2017, Elena Reshetova wrote: > atomic_as_refcounter.cocci script allows detecting > cases when refcount_t type and API should be used > instead of atomic_t. > > Signed-off-by: Elena Reshetova > --- > scripts/coccinelle/api/atomic_as_refcounter.cocci |

[Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script

2017-08-14 Thread Elena Reshetova
atomic_as_refcounter.cocci script allows detecting cases when refcount_t type and API should be used instead of atomic_t. Signed-off-by: Elena Reshetova --- scripts/coccinelle/api/atomic_as_refcounter.cocci | 148 ++ 1 file changed, 148

Re: [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script

2017-08-07 Thread Reshetova, Elena
> On Tue, 18 Jul 2017, Elena Reshetova wrote: > > > atomic_as_refcounter.cocci script allows detecting > > cases when refcount_t type and API should be used > > instead of atomic_t. > > > > Signed-off-by: Elena Reshetova > > --- > >

Re: [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script

2017-08-04 Thread Julia Lawall
On Tue, 18 Jul 2017, Elena Reshetova wrote: > atomic_as_refcounter.cocci script allows detecting > cases when refcount_t type and API should be used > instead of atomic_t. > > Signed-off-by: Elena Reshetova > --- > scripts/coccinelle/api/atomic_as_refcounter.cocci |

Re: [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script

2017-07-18 Thread Kees Cook
On Tue, Jul 18, 2017 at 12:48 AM, Elena Reshetova wrote: > atomic_as_refcounter.cocci script allows detecting > cases when refcount_t type and API should be used > instead of atomic_t. > > Signed-off-by: Elena Reshetova > --- >

[Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script

2017-07-18 Thread Elena Reshetova
atomic_as_refcounter.cocci script allows detecting cases when refcount_t type and API should be used instead of atomic_t. Signed-off-by: Elena Reshetova --- scripts/coccinelle/api/atomic_as_refcounter.cocci | 102 ++ 1 file changed, 102