Re: [Cocci] [PATCH v4] documentation: coccinelle: Improve command example for make C={1, 2}
On Tue, 11 Aug 2020, Sumera Priyadarsini wrote: > Modify coccinelle documentation to further clarify > the usage of the makefile C variable by coccicheck. > > Signed-off-by: Sumera Priyadarsini Acked-by: Julia Lawall Thanks. > > --- > Changes in v4: > - Modify commit message to clarify C is a variable > --- > Documentation/dev-tools/coccinelle.rst | 15 +++ > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/Documentation/dev-tools/coccinelle.rst > b/Documentation/dev-tools/coccinelle.rst > index 6c791af1c859..74c5e6aeeff5 100644 > --- a/Documentation/dev-tools/coccinelle.rst > +++ b/Documentation/dev-tools/coccinelle.rst > @@ -175,13 +175,20 @@ For example, to check drivers/net/wireless/ one may > write:: > make coccicheck M=drivers/net/wireless/ > > To apply Coccinelle on a file basis, instead of a directory basis, the > -following command may be used:: > +C variable is used by the makefile to select which files to work with. > +This variable can be used to run scripts for the entire kernel, a > +specific directory, or for a single file. > > -make C=1 CHECK="scripts/coccicheck" > +For example, to check drivers/bluetooth/bfusb.c, the value 1 is > +passed to the C variable to check files that make considers > +need to be compiled.:: > > -To check only newly edited code, use the value 2 for the C flag, i.e.:: > +make C=1 CHECK=scripts/coccicheck drivers/bluetooth/bfusb.o > > -make C=2 CHECK="scripts/coccicheck" > +The value 2 is passed to the C variable to check files regardless of > +whether they need to be compiled or not.:: > + > +make C=2 CHECK=scripts/coccicheck drivers/bluetooth/bfusb.o > > In these modes, which work on a file basis, there is no information > about semantic patches displayed, and no commit message proposed. > -- > 2.17.1 > > ___ > Cocci mailing list > Cocci@systeme.lip6.fr > https://systeme.lip6.fr/mailman/listinfo/cocci > ___ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci
Re: [Cocci] [PATCH v4] documentation: coccinelle: Improve command example for make C={1, 2}
On Tue, Aug 11, 2020 at 10:00:20AM +0200, Markus Elfring wrote: > > +This variable can be used to run scripts for the entire kernel, a > > +specific directory, or for a single file. > > I imagine that this wording can be improved another bit (as I indicated it > before). Hi, This is the semi-friendly patch-bot of Greg Kroah-Hartman. Markus, you seem to have sent a nonsensical or otherwise pointless review comment to a patch submission on a Linux kernel developer mailing list. I strongly suggest that you not do this anymore. Please do not bother developers who are actively working to produce patches and features with comments that, in the end, are a waste of time. Patch submitter, please ignore Markus's suggestion; you do not need to follow it at all. The person/bot/AI that sent it is being ignored by almost all Linux kernel maintainers for having a persistent pattern of behavior of producing distracting and pointless commentary, and inability to adapt to feedback. Please feel free to also ignore emails from them. thanks, greg k-h's patch email bot ___ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci
[Cocci] [PATCH v4] documentation: coccinelle: Improve command example for make C={1, 2}
Modify coccinelle documentation to further clarify the usage of the makefile C variable by coccicheck. Signed-off-by: Sumera Priyadarsini --- Changes in v4: - Modify commit message to clarify C is a variable --- Documentation/dev-tools/coccinelle.rst | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/Documentation/dev-tools/coccinelle.rst b/Documentation/dev-tools/coccinelle.rst index 6c791af1c859..74c5e6aeeff5 100644 --- a/Documentation/dev-tools/coccinelle.rst +++ b/Documentation/dev-tools/coccinelle.rst @@ -175,13 +175,20 @@ For example, to check drivers/net/wireless/ one may write:: make coccicheck M=drivers/net/wireless/ To apply Coccinelle on a file basis, instead of a directory basis, the -following command may be used:: +C variable is used by the makefile to select which files to work with. +This variable can be used to run scripts for the entire kernel, a +specific directory, or for a single file. -make C=1 CHECK="scripts/coccicheck" +For example, to check drivers/bluetooth/bfusb.c, the value 1 is +passed to the C variable to check files that make considers +need to be compiled.:: -To check only newly edited code, use the value 2 for the C flag, i.e.:: +make C=1 CHECK=scripts/coccicheck drivers/bluetooth/bfusb.o -make C=2 CHECK="scripts/coccicheck" +The value 2 is passed to the C variable to check files regardless of +whether they need to be compiled or not.:: + +make C=2 CHECK=scripts/coccicheck drivers/bluetooth/bfusb.o In these modes, which work on a file basis, there is no information about semantic patches displayed, and no commit message proposed. -- 2.17.1 ___ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci
