Re: [Cocci] [RFC] coccicheck: add a test for repeat memory fetches

2017-01-10 Thread Vaishali Thakkar
On Wednesday 11 January 2017 05:34 AM, Kees Cook wrote: On Tue, Jan 10, 2017 at 1:14 PM, Julia Lawall wrote: OK, I have the impression that what you are looking for is the following, that currently does not seem to work well. Still maybe it gives an idea. The basic

Re: [Cocci] [RFC] coccicheck: add a test for repeat memory fetches

2017-01-10 Thread Kees Cook
On Tue, Jan 10, 2017 at 1:14 PM, Julia Lawall wrote: > OK, I have the impression that what you are looking for is the following, > that currently does not seem to work well. Still maybe it gives an idea. > > The basic pattern is the following sequence: > > 1. copy_from_user

Re: [Cocci] [RFC] coccicheck: add a test for repeat memory fetches

2017-01-10 Thread Julia Lawall
OK, I have the impression that what you are looking for is the following, that currently does not seem to work well. Still maybe it gives an idea. The basic pattern is the following sequence: 1. copy_from_user 2. test on a field of the copied value 3. another copy_from_user 4. a use of the same

Re: [Cocci] [RFC] coccicheck: add a test for repeat memory fetches

2017-01-10 Thread Kees Cook
On Tue, Jan 10, 2017 at 11:30 AM, Julia Lawall wrote: > > > On Tue, 10 Jan 2017, Kees Cook wrote: > >> On Tue, Jan 10, 2017 at 10:28 AM, Julia Lawall wrote: >> >> +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2159 >> >>

Re: [Cocci] [RFC] coccicheck: add a test for repeat memory fetches

2017-01-10 Thread Kees Cook
On Tue, Jan 10, 2017 at 11:23 AM, Kees Cook wrote: > On Tue, Jan 10, 2017 at 10:28 AM, Julia Lawall wrote: >>> +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2159 >>> +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2257 >>>

Re: [Cocci] [RFC] coccicheck: add a test for repeat memory fetches

2017-01-10 Thread Kees Cook
On Tue, Jan 10, 2017 at 10:28 AM, Julia Lawall wrote: >> +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2159 >> +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2257 >> +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2302 >>

Re: [Cocci] [RFC] coccicheck: add a test for repeat memory fetches

2017-01-10 Thread Julia Lawall
> +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2159 > +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2257 > +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2302 > +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2342 > +./drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:2365 >

Re: [Cocci] [RFC] coccicheck: add a test for repeat memory fetches

2017-01-10 Thread Pengfei Wang
> 在 2017年1月10日，下午2:06，Julia Lawall 写道： > > > > On Mon, 9 Jan 2017, Kees Cook wrote: > >> Okay, this adds a few tests, for people to examine. >> >> reusercopy-cook.cocci: >> My original test, with recent updates from Julia. >> >> reusercopy-wang.cocci: >> This is

Re: [Cocci] [RFC] coccicheck: add a test for repeat memory fetches

2017-01-10 Thread Vaishali Thakkar
On Tue, Jan 10, 2017 at 1:31 PM, Julia Lawall wrote: > > > On Tue, 10 Jan 2017, Pengfei Wang wrote: > >> >> > 在 2017年1月10日，下午2:06，Julia Lawall 写道： >> > >> > >> > >> > On Mon, 9 Jan 2017, Kees Cook wrote: >> > >> >> Okay, this adds a few tests, for