> Second the commit log could be more concise as:
I like your desire for choosing a more appropriate commit message.
> Allow defining COCCI as a directory that contains .cocci files.
I would prefer to concentrate the patch subject on other information.
> In general, at least in simple cases,
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=13b86bc4cd648eae69fdcf3d04b2750c76350053#n656
>
> Huh? I was talking about the log message, not the subject line.
Thanks for this clarification.
> With that degree of
>> How do you think about to use the subject “[PATCH] coccicheck:
>> Support search for SmPL scripts within selected directory hierarchy”?
>
> I would like to use subject as you said.
Thanks for your positive feedback.
> But it seems a little bit long,
I hope that this suggestion is still
I find that the commit message should still be considerably improved.
How do you think about to use the subject “[PATCH] coccicheck:
Support search for SmPL scripts within selected directory hierarchy”?
> Put a modification in scripts/coccicheck which supports users in
> configuring COCCI
On Thu, 24 Oct 2019, Markus Elfring wrote:
> > Second the commit log could be more concise as:
>
> I like your desire for choosing a more appropriate commit message.
>
>
> > Allow defining COCCI as a directory that contains .cocci files.
>
> I would prefer to concentrate the patch subject on
> >> How do you think about to use the subject “[PATCH] coccicheck:
> >> Support search for SmPL scripts within selected directory hierarchy”?
> >
> > I would like to use subject as you said.
>
> Thanks for your positive feedback.
>
>
> > But it seems a little bit long,
>
> I hope that this
On Thu, 24 Oct 2019, zhongshiqi wrote:
> Put a modification in scripts/coccicheck which supports users in
> configuring COCCI parameter as a directory to traverse files in
> directory whose next level directory contains rule files with Suffix of
> cocci.
While I thought the original was fine,
Put a modification in scripts/coccicheck which supports users in
configuring COCCI parameter as a directory to traverse files in
directory whose next level directory contains rule files with Suffix of
cocci.
Signed-off-by: zhongshiqi
---
Changes in v2:
1.fix patch subject according to
> I find that the commit message should still be considerably improved.
> How do you think about to use the subject “[PATCH] coccicheck:
> Support search for SmPL scripts within selected directory hierarchy”?
I would like to use subject as you said.
But it seems a little bit long, does it matter?
> On Thu, 24 Oct 2019, zhongshiqi wrote:
>
> > Put a modification in scripts/coccicheck which supports users in
> > configuring COCCI parameter as a directory to traverse files in
> > directory whose next level directory contains rule files with Suffix of
> > cocci.
>
> While I thought the
> How do you think about to use the subject "[PATCH] coccicheck: Support search
> in a selected directory"?
I am unsure about such a reduced variant.
Its acceptance will depend also on other Linux contributors as usual.
Regards,
Markus
___
Cocci
> I always appreciate the code refactoring
> that reduces the object size.
Would you like to compare effects around conversions for
the mentioned wrapper function any more?
Regards,
Markus
___
Cocci mailing list
Cocci@systeme.lip6.fr
On Sun, Oct 20, 2019 at 7:13 AM Joe Perches wrote:
>
> On Sat, 2019-10-19 at 21:43 +0100, Marc Zyngier wrote:
> > Providing Coccinelle scripts that scream about perfectly valid code is
> > pointless, and the result is actively harmful.
>
> Doubtful.
>
> If the new code is smaller object code and
Allow defining COCCI as a directory to search SmPL scripts. Start a
corresponding file determination if the environment variable “COCCI”
contains an acceptable path.
Signed-off-by: zhongshiqi
---
Changes in v3:
1:rewrite change description
2:fix patch subject
3:modify
14 matches
Mail list logo
