Re: [Cocci] [PATCH net-next v1] can: ti_hecc: convert to devm_platform_ioremap_resource_byname()

2020-04-20 Thread Dejin Zheng
On Sun, Apr 19, 2020 at 06:19:12PM +0200, Markus Elfring wrote: > > use devm_platform_ioremap_resource_byname() to simplify code, > > it contains platform_get_resource_byname() and > > devm_ioremap_resource(), and also remove some duplicate error > > message. > > How do you think about a wording

Re: [Cocci] console: Complete exception handling in newport_probe()

2020-04-28 Thread Dejin Zheng
On Thu, Apr 23, 2020 at 05:23:29PM +0200, Markus Elfring wrote: > >> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/scripts/coccinelle/free/iounmap.cocci > >> > >> How do you think about to extend presented software analysis approaches? > >> > > Sorry, I am not familiar

Re: [Cocci] [PATCH v1] console: fix an issue about ioremap leak.

2020-04-28 Thread Dejin Zheng
On Thu, Apr 23, 2020 at 01:10:14PM +0200, Markus Elfring wrote: > > if do_take_over_console() return an error in the newport_probe(), > > due to the io virtual address is not released, it will cause a leak. > > How do you think about a wording variant like the following? > >Subject: >