Re: [Cocci] [PATCH v5 0/3] cocci: Align the C AST and Cocci AST for pointer

2020-02-12 Thread Julia Lawall
On Tue, 11 Feb 2020, Jaskaran Singh wrote:

> This series is to address the type matching problem in Coccinelle.
>
> Patch 1/3 is for aligning the C and Cocci AST so that
> pointer to const pointer and its variants can be matched.
>
> Patch 2/3 reflects the pretty printing changes made in
> 1/3 in the ptrconstptr test case. A space is added between
> the * and const.
>
> Patch 3/3 consists of a test case for matching a pointer to
> const pointer and its variants.

All applied, thanks.

julia

>
> Changes in v5:
> --
> - Remove unnecessary parantheses and return of unit in Patch 1/3.
> - Have the test case in Patch 3/3 conform more closely with the
>   Linux kernel coding style.
>
> Changes in v4:
> --
> - Fix coding style w/r/t placement of comment with List.iter and
>   the qualifier printing function.
>
> Changes in v3:
> --
> - Add a space between the * and qualifier in Patch 1/3.
> - Add Patch 2/3 to add a space between * and const in the test
>   case ptrconstptr.
>
> Changes in v2:
> --
> - Change body and subject of Patch 2/2 as per suggestion of Markus
>   Elfring.
>
> [PATCH v5 1/3] parsing_c: Align C AST and Cocci AST for pointer
> [PATCH v5 2/3] tests: Add space between * and const in
> [PATCH v5 3/3] tests: Add test case to match const pointer variants
>
>  parsing_c/parser_c.mly  |4 ++--
>  parsing_c/pretty_print_c.ml |   15 ++-
>  tests/constptr.c|7 +++
>  tests/constptr.cocci|   19 +++
>  tests/constptr.res  |7 +++
>  tests/ptrconstptr.res   |2 +-
>  6 files changed, 46 insertions(+), 8 deletions(-)
>
>
___
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci


[Cocci] [PATCH v5 0/3] cocci: Align the C AST and Cocci AST for pointer

2020-02-11 Thread Jaskaran Singh
This series is to address the type matching problem in Coccinelle.

Patch 1/3 is for aligning the C and Cocci AST so that
pointer to const pointer and its variants can be matched.

Patch 2/3 reflects the pretty printing changes made in 
1/3 in the ptrconstptr test case. A space is added between
the * and const.

Patch 3/3 consists of a test case for matching a pointer to
const pointer and its variants.

Changes in v5:
--
- Remove unnecessary parantheses and return of unit in Patch 1/3.
- Have the test case in Patch 3/3 conform more closely with the
  Linux kernel coding style.

Changes in v4:
--
- Fix coding style w/r/t placement of comment with List.iter and
  the qualifier printing function.

Changes in v3:
--
- Add a space between the * and qualifier in Patch 1/3.
- Add Patch 2/3 to add a space between * and const in the test
  case ptrconstptr.

Changes in v2:
--
- Change body and subject of Patch 2/2 as per suggestion of Markus
  Elfring.

[PATCH v5 1/3] parsing_c: Align C AST and Cocci AST for pointer
[PATCH v5 2/3] tests: Add space between * and const in
[PATCH v5 3/3] tests: Add test case to match const pointer variants

 parsing_c/parser_c.mly  |4 ++--
 parsing_c/pretty_print_c.ml |   15 ++-
 tests/constptr.c|7 +++
 tests/constptr.cocci|   19 +++
 tests/constptr.res  |7 +++
 tests/ptrconstptr.res   |2 +-
 6 files changed, 46 insertions(+), 8 deletions(-)

___
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci