Re: [Cocci] coccinelle: api/devm_platform_ioremap_resource: remove useless script

2019-10-29 Thread Julia Lawall
On Tue, 29 Oct 2019, Masahiro Yamada wrote: > Hi Julia > > On Fri, Oct 25, 2019 at 5:38 PM Julia Lawall wrote: > > > > > > > > On Fri, 25 Oct 2019, Andy Shevchenko wrote: > > > > > On Fri, Oct 25, 2019 at 12:40:52AM +0900, Masahiro Yamada wrote: > > > > On Sun, Oct 20, 2019 at 7:13 AM Joe

Re: [Cocci] coccinelle: api/devm_platform_ioremap_resource: remove useless script

2019-10-29 Thread Masahiro Yamada
Hi Julia On Fri, Oct 25, 2019 at 5:38 PM Julia Lawall wrote: > > > > On Fri, 25 Oct 2019, Andy Shevchenko wrote: > > > On Fri, Oct 25, 2019 at 12:40:52AM +0900, Masahiro Yamada wrote: > > > On Sun, Oct 20, 2019 at 7:13 AM Joe Perches wrote: > > > > On Sat, 2019-10-19 at 21:43 +0100, Marc

Re: [Cocci] coccinelle: api/devm_platform_ioremap_resource: remove useless script

2019-10-25 Thread Andy Shevchenko
On Fri, Oct 25, 2019 at 12:40:52AM +0900, Masahiro Yamada wrote: > On Sun, Oct 20, 2019 at 7:13 AM Joe Perches wrote: > > On Sat, 2019-10-19 at 21:43 +0100, Marc Zyngier wrote: > Alexandre Belloni used > https://lore.kernel.org/lkml/9bbcce19c777583815c92ce3c2ff2...@www.loen.fr/ > as a reference,

Re: [Cocci] coccinelle: api/devm_platform_ioremap_resource: remove useless script

2019-10-25 Thread Julia Lawall
On Fri, 25 Oct 2019, Andy Shevchenko wrote: > On Fri, Oct 25, 2019 at 12:40:52AM +0900, Masahiro Yamada wrote: > > On Sun, Oct 20, 2019 at 7:13 AM Joe Perches wrote: > > > On Sat, 2019-10-19 at 21:43 +0100, Marc Zyngier wrote: > > > Alexandre Belloni used > >

Re: [Cocci] coccinelle: api/devm_platform_ioremap_resource: remove useless script

2019-10-24 Thread Markus Elfring
> I always appreciate the code refactoring > that reduces the object size. Would you like to compare effects around conversions for the mentioned wrapper function any more? Regards, Markus ___ Cocci mailing list Cocci@systeme.lip6.fr

Re: [Cocci] coccinelle: api/devm_platform_ioremap_resource: remove useless script

2019-10-24 Thread Masahiro Yamada
On Sun, Oct 20, 2019 at 7:13 AM Joe Perches wrote: > > On Sat, 2019-10-19 at 21:43 +0100, Marc Zyngier wrote: > > Providing Coccinelle scripts that scream about perfectly valid code is > > pointless, and the result is actively harmful. > > Doubtful. > > If the new code is smaller object code and

Re: [Cocci] coccinelle: api/devm_platform_ioremap_resource: remove useless script

2019-10-19 Thread Markus Elfring
> What are the additional effects? I suggest to take another look at the commit 7945f929f1a77a1c8887a97ca07f87626858ff42 ("drivers: provide devm_platform_ioremap_resource()" from 2019-02-20) which triggered the discussed software evolution.

Re: [Cocci] coccinelle: api/devm_platform_ioremap_resource: remove useless script

2019-10-19 Thread Markus Elfring
> I think part of the issue is that the script reports a WARNING How much does this information influence really the stress tolerance and change resistance (or acceptance) for the presented collateral evolution?