Re: Proper NSOperation isCancelled handling

2009-02-13 Thread Ken Thomases
On Feb 12, 2009, at 1:29 PM, Alex Curylo wrote: So I'm a bit confused about how my NSOperation subclass should implement the cancel method. Why are you overriding it? The -cancel method is not supposed to actively bring the operation to a stop. It's only supposed to set a flag. The

Re: Proper NSOperation isCancelled handling

2009-02-13 Thread Alex Curylo
On 13-Feb-09, at 12:31 AM, Ken Thomases wrote: Why are you overriding it? The -cancel method is not supposed to actively bring the operation to a stop. It's only supposed to set a flag. The operation's work methods (-start, -main, and whatever they call) should be periodically checking

Re: Proper NSOperation isCancelled handling

2009-02-13 Thread Kyle Sluder
On Fri, Feb 13, 2009 at 8:55 AM, Alex Curylo a...@alexcurylo.com wrote: Because all -start does is initiate an NSURLConnection. If it's failing to connect or whatever, I want the operation to stop when the user says so, not whenever -didFailWithError gets around to being called. That's not

Re: Proper NSOperation isCancelled handling

2009-02-13 Thread Ken Heglund
On Feb 13, 2009, at 8:23 AM, Kyle Sluder wrote: On Fri, Feb 13, 2009 at 8:55 AM, Alex Curylo a...@alexcurylo.com wrote: Because all -start does is initiate an NSURLConnection. If it's failing to connect or whatever, I want the operation to stop when the user says so, not whenever

Proper NSOperation isCancelled handling

2009-02-12 Thread Alex Curylo
So I'm a bit confused about how my NSOperation subclass should implement the cancel method. The documentation says that isCancelled is a KVO-compliant property. So I figured that calling [super cancel] ought to take care of that. But it doesn't. Doesn't appear to do anything, actually,