Re: DO NOT REPLY [Bug 17673] - sendPage function in Flow causesan NPE.

2003-03-11 Thread Ugo Cei
[I was sure I had already replied to this message, but I cannot see i in the list.] Carsten Ziegeler wrote: Addition: It should be in the redirector, I will commit a fix in three minutes, can you please test it? Carsten It works. Nice job, thank you. Ugo

Re: DO NOT REPLY [Bug 17673] - sendPage function in Flow causesan NPE.

2003-03-11 Thread Ugo Cei
Carsten Ziegeler wrote: Addition: It should be in the redirector, I will commit a fix in three minutes, can you please test it? Carsten Tested, and it passes with flying colors. Well, at least my application now works again with the latest CVS code, so I assume everything is OK ;-). Thank you fo

Re: DO NOT REPLY [Bug 17673] - sendPage function in Flow causesan NPE.

2003-03-11 Thread Ugo Cei
Carsten Ziegeler wrote: Thanks, so we can close the bug? Carsten Well, in my daytime job I am pushing for a policy whereby we don't close bugs until we have a repeatable test case ... but last time I heard someone mentioning the lack of unit tests in Cocoon, he was more or less appointed commit

Re: DO NOT REPLY [Bug 17673] - sendPage function in Flow causesan NPE.

2003-03-11 Thread Ugo Cei
[I tried to reply twice to this mail from home, but it looks like my provider has some problems. Don't be confused if you see some more replies appearing in the coming days ...] Carsten Ziegeler wrote: Addition: It should be in the redirector, I will commit a fix in three minutes, can you please

Re: DO NOT REPLY [Bug 17673] - sendPage function in Flow causesan NPE.

2003-03-10 Thread Ugo Cei
Carsten Ziegeler wrote: Addition: It should be in the redirector, I will commit a fix in three minutes, can you please test it? Carsten Not now, I'm going out of the office in 1 minute. I hope to be back before late and test it then. Thank you. Ugo -- Ugo Cei - Consorzio di Bioingegneria e Info

Re: DO NOT REPLY [Bug 17673] - sendPage function in Flow causesan NPE.

2003-03-10 Thread Ugo Cei
Carsten Ziegeler wrote: Hmm, usually yes - but as only few people are debugging cocoon anyway, installing the checks keeps everyone happy and noone searches for the real bug. And there's also the problem that "assert" is available only in JDK 1.4, unless we want to introduce some compatibility la

Re: DO NOT REPLY [Bug 17673] - sendPage function in Flow causesan NPE.

2003-03-10 Thread Ugo Cei
Carsten Ziegeler wrote: Ugo Cei wrote: Is this a case of not enough defensive programming or do the NPEs that occur when the checks are not in place a symptom of a problem somewhere else that the checks merely hide from view? Yes, this should be the case, the problem should lie somewhere else. That

Re: DO NOT REPLY [Bug 17673] - sendPage function in Flow causesan NPE.

2003-03-10 Thread Ugo Cei
[EMAIL PROTECTED] wrote: --- Additional Comments From [EMAIL PROTECTED] 2003-03-10 09:30 --- I have a patch (attached) that hopefully fixes this bug. What it does is to wrap the call to this.rootNode.invoke in o.a.c.components.treeprocessor.TreeProcessor with a call to CocoonComponentManag