Re: [code-quality] Custom pylint checkers for Python 2/3 compatibility

2014-08-08 Thread Claudiu Popa
On Fri, Aug 8, 2014 at 10:20 PM, Brett Cannon wrote: > > Any issue if I just make it part of my Python 3 checker pull request? It's > obviously easier when I have my own checkers to make sure I'm not screwing > it up. =) Nope, it's fine with me if it'll be in your Python 3 checker pull request.

Re: [code-quality] Custom pylint checkers for Python 2/3 compatibility

2014-08-08 Thread Brett Cannon
On Fri Aug 08 2014 at 2:59:04 PM Claudiu Popa wrote: > On Fri, Aug 8, 2014 at 9:09 PM, Brett Cannon wrote: > > > > I just realized I should have checked setup.py to see if 2to3 was being > > used, which it is. =) So it seems that I will have to port Pylint over > to a > > Python 2/3 source-compa

Re: [code-quality] Custom pylint checkers for Python 2/3 compatibility

2014-08-08 Thread Claudiu Popa
On Fri, Aug 8, 2014 at 9:09 PM, Brett Cannon wrote: > > I just realized I should have checked setup.py to see if 2to3 was being > used, which it is. =) So it seems that I will have to port Pylint over to a > Python 2/3 source-compatible code base in order to pass any checks with my > set of checke

Re: [code-quality] Custom pylint checkers for Python 2/3 compatibility

2014-08-08 Thread Brett Cannon
On Fri Aug 08 2014 at 2:01:18 PM Brett Cannon wrote: > I've started work on a pull request to add my Python 3 checkers into > Pylint: https://bitbucket.org/brettsky/pylint . The work isn't quite > done, but I have run into one issue where one of my checker is causing > various regression tests to

Re: [code-quality] Custom pylint checkers for Python 2/3 compatibility

2014-08-08 Thread Brett Cannon
I've started work on a pull request to add my Python 3 checkers into Pylint: https://bitbucket.org/brettsky/pylint . The work isn't quite done, but I have run into one issue where one of my checker is causing various regression tests to fail across the board due to strings not being specified as ei

Re: [code-quality] Custom pylint checkers for Python 2/3 compatibility

2014-07-26 Thread Brett Cannon
Sure. I will try to make time next week to make a pull request against Pylint with a checkers/python3.py or something. On Fri Jul 25 2014 at 6:14:21 PM Claudiu Popa wrote: > Hello Brett. > > At a quick glance, the patch looks really good, even with the scarce > documentation that we have. :-) >

[code-quality] Custom pylint checkers for Python 2/3 compatibility

2014-07-25 Thread Claudiu Popa
Hello Brett. At a quick glance, the patch looks really good, even with the scarce documentation that we have. :-) Maybe you can turn this into a pull request for Pylint, so that we may have in the near future a mode that only checks Python 2/3 compatibility? That way would be easier for review, to

[code-quality] Custom pylint checkers for Python 2/3 compatibility

2014-07-25 Thread Brett Cannon
The Python 2/3 checkers I emailed this list about back in June I think are now at a beta stage and can be viewed at https://github.com/brettcannon/caniusepython3/blob/pylint/caniusepython3/pylint_checker.py along with tests at https://github.com/brettcannon/caniusepython3/blob/pylint/caniusepython3