Re: [code-quality] Adding python function arguments related customized rule in pylint

2015-08-30 Thread Ahirnish Pareek
Thanks for the suggestion Claudio. I'll do the same. On Mon, Aug 31, 2015 at 12:06 PM, Claudiu Popa wrote: > On Thu, Aug 27, 2015 at 1:11 PM, Ahirnish Pareek > wrote: > > Hi, > > > > I was being told to share my plugin in the current state. It would be > > helpful if someone take a look about i

Re: [code-quality] Adding python function arguments related customized rule in pylint

2015-08-27 Thread Ahirnish Pareek
Hi, I was being told to share my plugin in the current state. It would be helpful if someone take a look about it in my previous mail and provide feedback. Thanks. On Tue, Aug 11, 2015 at 11:20 AM, Ahirnish Pareek wrote: > Hi, > > The idea of plugin is very simple and I felt the need of it in

Re: [code-quality] Adding python function arguments related customized rule in pylint

2015-08-10 Thread Ahirnish Pareek
Hi, The idea of plugin is very simple and I felt the need of it in my organization's code base where we use python 2.7 to write the tests. There are a lot of functions which looks like this: def foo( var1, name1=value, *args ): The problem that I want to deal with is that we should not have keyw

Re: [code-quality] Adding python function arguments related customized rule in pylint

2015-08-05 Thread Florian Bruhin
* Ahirnish Pareek [2015-08-05 13:49:39 +0530]: > I have never patched anything to the open-source code and I am confused as > to what are the right steps to follow. I need to patch a function argument > related checker into the pylint code base. Can someone point me to the > steps need to follow t

Re: [code-quality] Adding python function arguments related customized rule in pylint

2015-08-05 Thread Ahirnish Pareek
Hi, I have never patched anything to the open-source code and I am confused as to what are the right steps to follow. I need to patch a function argument related checker into the pylint code base. Can someone point me to the steps need to follow to ensure my changes go upstream? Thanks. On Fri,

Re: [code-quality] Adding python function arguments related customized rule in pylint

2015-07-03 Thread Claudiu Popa
On Thu, Jul 2, 2015 at 9:45 AM, Ahirnish Pareek wrote: > Hi all, > > I was wondering if there's a pattern to calculate Pylint's message-id > numbers? I know that first alphabet indicates if its a warning, error, > convention, refactor or fatal but how do we come up with 4-digit number > after that

Re: [code-quality] Adding python function arguments related customized rule in pylint

2015-07-01 Thread Ahirnish Pareek
Hi all, I was wondering if there's a pattern to calculate Pylint's message-id numbers? I know that first alphabet indicates if its a warning, error, convention, refactor or fatal but how do we come up with 4-digit number after that? Like - E1605. E = Error but what is 1605? Thanks. On Wed, Jul

Re: [code-quality] Adding python function arguments related customized rule in pylint

2015-07-01 Thread Claudiu Popa
On Wed, Jul 1, 2015 at 2:32 PM, Ahirnish Pareek wrote: > Thanks Claudiu. > > I was looking for this only. > > Yes, I meant type(function) from Python. My organization doesnt have > asteroid in its python's site-packages. We are still importing from > logilab.astng module. Thanks for the help! >

Re: [code-quality] Adding python function arguments related customized rule in pylint

2015-07-01 Thread Ahirnish Pareek
Thanks Claudiu. I was looking for this only. Yes, I meant type(function) from Python. My organization doesnt have asteroid in its python's site-packages. We are still importing from logilab.astng module. Thanks for the help! On Wed, Jul 1, 2015 at 3:31 PM, Claudiu Popa wrote: > Hi, > > On Wed

Re: [code-quality] Adding python function arguments related customized rule in pylint

2015-07-01 Thread Claudiu Popa
Hi, On Wed, Jul 1, 2015 at 12:40 PM, Ahirnish Pareek wrote: > Hi all, > > I was going through the checkers/typecheck.py for reference but could not > understand it concretely. > > I am basically unable to find how to retrieve arguments from Astng Function > node. > > I am using visit_function() i

Re: [code-quality] Adding python function arguments related customized rule in pylint

2015-07-01 Thread Ahirnish Pareek
Hi all, I was going through the *checkers/typecheck.py* for reference but could not understand it concretely. I am basically unable to find how to retrieve arguments from Astng Function node. I am using visit_function() inside a checker class to visit all function nodes but not able to get list

Re: [code-quality] Adding python function arguments related customized rule in pylint

2015-06-29 Thread Claudiu Popa
On Mon, Jun 29, 2015 at 12:32 PM, Ahirnish Pareek wrote: > Hi all, > > I want to add a customized check to my pylintrc file to check and report > cases whenever I define a function in a python file like this: > > def foo( var1, name1=value, *args ): > > The problem that I want to deal with is that