[GitHub] incubator-trafodion pull request: [TRAFODION-1860]sqgen failed to ...

[mkby]

GitHub user mkby opened a pull request:

https://github.com/apache/incubator-trafodion/pull/358

[TRAFODION-1860]sqgen failed to execute on CentOS7

remove dependency of ctime.pl

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mkby/incubator-trafodion master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/358.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #358


commit 4ad51c730a98d2fff01a84ad86516a33cdbf55f6
Author: Eason 
Date:   2016-03-03T03:55:58Z

[TRAFODION-1860]sqgen failed to execute on CentOS7

remove dependency of ctime.pl




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[mashengchen]

Github user mashengchen commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/348#discussion_r54833403
  
--- Diff: core/sql/pom.xml.apache ---
@@ -0,0 +1,131 @@
+
--- End diff --

no idea to use one pom.xml, we have to make 3 version (vanilla,cdh,hdp), so 
have to use three pom.xml


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[mashengchen]

Github user mashengchen commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/348#discussion_r54833294
  
--- Diff: 
core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/regionserver/transactional/TrxTransactionState.java.tmpl
 ---
@@ -77,96 +94,29 @@
  * Holds the state of a transaction. This includes a buffer of all writes, 
a record of all reads / scans, and
  * information about which other transactions we need to check against.
  */
-public class TrxTransactionState  extends TransactionState{
-
-static boolean sb_sqm_98_1 = false;
-static boolean sb_sqm_98_4 = false;
-static boolean sb_sqm_98_9 = false;
-static java.lang.reflect.Constructor c98_1 = null;
-static java.lang.reflect.Constructor c98_4 = null;
-static java.lang.reflect.Constructor c98_9 = null;
+public class TrxTransactionState extends TransactionState {
 
-static Class keepDeletedCellsClazz = null;
-static Class scaninfoClazz = null;
-static Constructor scaninfoConstructor = null;
-static Object[] scaninfoArgs = null;
+static java.lang.reflect.Constructor c1_0 = null;
 
 static {
 String version = VersionInfo.getVersion();// the hbase version 
string, eg. "0.6.3-dev"
 LOG.info("Got info of Class ScanQueryMatcher for HBase version :" 
+ version);
-
--- End diff --

i don't think there will happen this rid.. cause we have a 1.3 branch to 
support backward version(hbase 0.98)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[selvaganesang]

Github user selvaganesang commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/348#discussion_r54829734
  
--- Diff: 
core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/regionserver/transactional/TrxTransactionState.java.tmpl
 ---
@@ -77,96 +94,29 @@
  * Holds the state of a transaction. This includes a buffer of all writes, 
a record of all reads / scans, and
  * information about which other transactions we need to check against.
  */
-public class TrxTransactionState  extends TransactionState{
-
-static boolean sb_sqm_98_1 = false;
-static boolean sb_sqm_98_4 = false;
-static boolean sb_sqm_98_9 = false;
-static java.lang.reflect.Constructor c98_1 = null;
-static java.lang.reflect.Constructor c98_4 = null;
-static java.lang.reflect.Constructor c98_9 = null;
+public class TrxTransactionState extends TransactionState {
 
-static Class keepDeletedCellsClazz = null;
-static Class scaninfoClazz = null;
-static Constructor scaninfoConstructor = null;
-static Object[] scaninfoArgs = null;
+static java.lang.reflect.Constructor c1_0 = null;
 
 static {
 String version = VersionInfo.getVersion();// the hbase version 
string, eg. "0.6.3-dev"
 LOG.info("Got info of Class ScanQueryMatcher for HBase version :" 
+ version);
-
--- End diff --

Are we getting rid of the backward compatibility here by removing this code.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[zellerh]

Github user zellerh commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/348#discussion_r54829297
  
--- Diff: core/sql/pom.xml.apache ---
@@ -0,0 +1,131 @@
+
--- End diff --

Rather than having multiple pom.xml files, could we use profiles in a 
single pom.xml? Just asking, I can imagine very well that it won't work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[zellerh]

Github user zellerh commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/348#discussion_r54828709
  
--- Diff: 
core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/regionserver/transactional/TrxTransactionState.java.tmpl
 ---
@@ -21,15 +21,27 @@
 * @@@ END COPYRIGHT @@@
 **/
 
+/**
--- End diff --

...and here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[zellerh]

Github user zellerh commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/348#discussion_r54828604
  
--- Diff: 
core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/regionserver/transactional/MemoryUsageChore.java.tmpl
 ---
@@ -21,6 +21,16 @@
 * @@@ END COPYRIGHT @@@
 **/
 
+/**
--- End diff --

Same here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[zellerh]

Github user zellerh commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/348#discussion_r54828151
  
--- Diff: core/sqf/sql/scripts/install_local_hadoop ---
@@ -579,17 +591,15 @@ fi
 #
 
 # See JIRA TRAFODION-1512 that will eliminate this check
-if [ -d $MY_LOCAL_SW_DIST ]; then
   
-  HADOOP_MIRROR_URL=http://archive.cloudera.com/cdh5/cdh/5
-  HADOOP_TAR=hadoop-2.5.0-cdh5.3.0.tar.gz
-else
-  
HADOOP_MIRROR_URL=http://download.nextag.com/apache/hadoop/common/hadoop-2.5.2
-  HADOOP_TAR=hadoop-2.5.2.tar.gz
-fi
+HADOOP_MIRROR_URL=http://archive.cloudera.com/cdh5/cdh/5
+HADOOP_TAR=hadoop-2.6.0-cdh5.4.4.tar.gz
 
-if [[ "$SQ_HBASE_DISTRO" = "HDP" ]]; then
-HADOOP_TAR=hadoop-2.6.0.2.2.0.0-2041.tar.gz
+if [[ "$HBASE_DISTRO" = "HDP" ]]; then
+HADOOP_TAR=hadoop-2.7.1.2.3.2.0-2950.tar.gz
--- End diff --

Yes, but this is optional. It also should work without MY_LOCAL_SW_DIST, 
where it downloads the files from the web.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[zellerh]

Github user zellerh commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/348#discussion_r54828073
  
--- Diff: core/sqf/sql/scripts/install_local_hadoop ---
@@ -391,7 +391,19 @@ else
 MY_START_PORT=`expr 24000 + $MY_START_PORT '*' 200`
   elif [ $MY_START_PORT == "rand" ]; then
 # pick a random number between 12000 and 24000 that is divisible by 200
-MY_START_PORT=`expr $RANDOM '%' 60 '*' 200 + 12000`
+lv_number=0   #initialize
--- End diff --

Thanks, from what you told me off-line it looks that this may be a merge 
conflict from another branch and changing it back is the right conflict 
resolution.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[zellerh]

Github user zellerh commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/348#discussion_r54819549
  
--- Diff: 
core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/client/transactional/SsccTransactionalScanner.java.tmpl
 ---
@@ -21,6 +21,26 @@
 * @@@ END COPYRIGHT @@@
 **/
 
+// @@@ START COPYRIGHT @@@
--- End diff --

Probably need to remove one of the two copyright notices?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[mashengchen]

Github user mashengchen commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/348#discussion_r54819507
  
--- Diff: core/sqf/sql/scripts/install_local_hadoop ---
@@ -579,17 +591,15 @@ fi
 #
 
 # See JIRA TRAFODION-1512 that will eliminate this check
-if [ -d $MY_LOCAL_SW_DIST ]; then
   
-  HADOOP_MIRROR_URL=http://archive.cloudera.com/cdh5/cdh/5
-  HADOOP_TAR=hadoop-2.5.0-cdh5.3.0.tar.gz
-else
-  
HADOOP_MIRROR_URL=http://download.nextag.com/apache/hadoop/common/hadoop-2.5.2
-  HADOOP_TAR=hadoop-2.5.2.tar.gz
-fi
+HADOOP_MIRROR_URL=http://archive.cloudera.com/cdh5/cdh/5
+HADOOP_TAR=hadoop-2.6.0-cdh5.4.4.tar.gz
 
-if [[ "$SQ_HBASE_DISTRO" = "HDP" ]]; then
-HADOOP_TAR=hadoop-2.6.0.2.2.0.0-2041.tar.gz
+if [[ "$HBASE_DISTRO" = "HDP" ]]; then
--- End diff --

it's just for someone why want to install hbase version beside CDH. they 
can config it by do 'export HBASE_DISTRO=APACHE/HDP'.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[zellerh]

Github user zellerh commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/348#discussion_r54819019
  
--- Diff: core/sqf/sql/scripts/install_local_hadoop ---
@@ -602,15 +612,24 @@ MYSQL_TAR=mysql-5.6.10-linux-glibc2.5-x86_64.tar.gz
 MYSQL_JDBC_URL=http://cdn.mysql.com/archives/mysql-connector-java-5.1
 MYSQL_JDBC_TAR=mysql-connector-java-5.1.23.tar.gz
 
-HIVE_MIRROR_URL=https://archive.apache.org/dist/hive/hive-0.13.1
-HIVE_PREFIX=apache-hive-0.13.1-bin
+HIVE_MIRROR_URL=http://archive.cloudera.com/cdh5/cdh/5
+HIVE_PREFIX=hive-1.1.0-cdh5.4.4
 HIVE_TAR=${HIVE_PREFIX}.tar.gz
 
+if [[ "$HBASE_DISTRO" = "APACHE" ]]; then
+HIVE_PREFIX=apache-hive-1.2.0-bin
+HIVE_TAR=${HIVE_PREFIX}.tar.gz
+fi
+
+
 HBASE_MIRROR_URL=http://archive.cloudera.com/cdh5/cdh/5
+HBASE_TAR=hbase-1.0.0-cdh5.4.4.tar.gz
 
-HBASE_TAR=hbase-0.98.6-cdh5.3.0.tar.gz
-if [[ "$SQ_HBASE_DISTRO" = "HDP" ]]; then
-HBASE_TAR=hbase-0.98.4.2.2.0.0-2041-hadoop2.tar.gz
+if [[ "$HBASE_DISTRO" = "HDP" ]]; then
+HBASE_TAR=hbase-1.1.2.2.3.2.0-2950.tar.gz
--- End diff --

Same here, also set HBASE_MIRROR_URL? You may not see this as a problem if 
you are using cached objects.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[zellerh]

Github user zellerh commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/348#discussion_r54818214
  
--- Diff: core/sqf/sql/scripts/install_local_hadoop ---
@@ -391,7 +391,19 @@ else
 MY_START_PORT=`expr 24000 + $MY_START_PORT '*' 200`
   elif [ $MY_START_PORT == "rand" ]; then
 # pick a random number between 12000 and 24000 that is divisible by 200
-MY_START_PORT=`expr $RANDOM '%' 60 '*' 200 + 12000`
+lv_number=0   #initialize
--- End diff --

Sorry, I don't quite understand the reason for this change. Isn't the new 
code doing what the old code did, just more complicated? Also, it extends the 
range up to 31200. We wanted to keep the range fro 24000 to 32000 reserved for 
installations that use the -p fromDisplay option. Please don't change this 
algorithm unless there is a very good reason for doing so.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1706

[zellerh]

Github user zellerh commented on a diff in the pull request:

https://github.com/apache/incubator-trafodion/pull/348#discussion_r54816839
  
--- Diff: 
core/sqf/hbase_utilities/src/main/java/org/trafodion/utility/backuprestore/TrafExportSnapshot.java
 ---
@@ -114,7 +119,10 @@
   private static final String INPUT_FOLDER_PREFIX = "export-files.";
 
   // Export Map-Reduce Counters, to keep track of the progress
-  public enum Counter { MISSING_FILES, COPY_FAILED, BYTES_EXPECTED, 
BYTES_COPIED, FILES_COPIED };
+  public enum Counter {
--- End diff --

Should this use some enum imported from another class? 
org.apache.hadoop.hbase.snapshot.ExportSnapshot.Counter?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-1867] Allow parallel ...

[DaveBirdsall]

GitHub user DaveBirdsall opened a pull request:

https://github.com/apache/incubator-trafodion/pull/357

[TRAFODION-1867] Allow parallel plans for non-partitioned tables in U…

…PD STATS.

The problem is for large non-partitioned tables, UPDATE STATS will do a 
series of SELECTs to compute statistics for sets of columns. The plans for 
these SELECTs are presently forced to be serial for non-partitioned tables as a 
workaround for a long-ago compiler bug which seems to have been fixed. It's 
time to remove this workaround and thereby speed up UPDATE STATS.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DaveBirdsall/incubator-trafodion 
SerialUpdateStatsBug

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/357.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #357


commit 07bf4163bf3c5b8bc863332886464e69f44cea6b
Author: Dave Birdsall 
Date:   2016-03-02T22:52:19Z

[TRAFODION-1867] Allow parallel plans for non-partitioned tables in UPD 
STATS




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-1862] Transaction ID ...

[selvaganesang]

GitHub user selvaganesang opened a pull request:

https://github.com/apache/incubator-trafodion/pull/356

[TRAFODION-1862] Transaction ID is returned as -1 when using the in m…

…emory table for RMS stats

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/selvaganesang/incubator-trafodion 
trafodion-1862

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/356.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #356


commit 7c0156d1fc30d138cd23a8c3b7cedc98799c27ea
Author: selvaganesang 
Date:   2016-03-02T21:58:04Z

[TRAFODION-1862] Transaction ID is returned as -1 when using the in memory 
table for RMS stats




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-1668] Emergency build...

[svarnau]

GitHub user svarnau opened a pull request:

https://github.com/apache/incubator-trafodion/pull/354

[TRAFODION-1668] Emergency build fix

The earlier pull request passed test, but then it was a long time
before it merged. By time work for 1668 merged, it caused a build error.
The branch is now broken for all builds without this small change.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/svarnau/incubator-trafodion fix1668

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/354.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #354


commit 6b4db62477a80f2984fc6a6cfca1762ada1003fe
Author: Steve Varnau 
Date:   2016-03-02T17:08:24Z

[TRAFODION-1668] Emergency build fix

The earlier pull request passed test, but then it was a long time
before it merged. By time work for 1668 merged, it caused a build error.
The branch is now broken for all builds without this small change.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-1865] uninitialized b...

[traflm]

GitHub user traflm opened a pull request:

https://github.com/apache/incubator-trafodion/pull/353

[TRAFODION-1865] uninitialized buffer cause Monitor abort in CentOS 7

We tested on CentOS 7.2, by applying this change, sqstart success.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/traflm/incubator-trafodion TRAFODION-1865

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/353.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #353


commit dce27e574839c7f5f3f7fada71e0f10db4a6dff3
Author: Liu Ming 
Date:   2016-03-02T14:49:23Z

[TRAFODION-1865] uninitialized buffer cause Monitor abort in CentOS 7




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---